From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: [dpdk-dev] [PATCH v2] usertools: add status-dev argument to devbind
Date: Thu, 27 Apr 2017 18:55:37 +0100 [thread overview]
Message-ID: <20170427175537.26147-1-ferruh.yigit@intel.com> (raw)
In-Reply-To: <20170426115810.495-1-ferruh.yigit@intel.com>
Script displays status for all device types and output is much
longer than it used to be. This makes harder to read script output.
This patch adds new --status-dev argument to the script to select
a device group to display status.
Supported device groups:
net
crypto
event
mempool
Sample usage:
./usertools/dpdk-devbind.py --status-dev mempool
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
v2:
* new --status-dev long option added instead of --type that will work
together with existing status flag. Existing --status option behavior
kept untouched.
---
usertools/dpdk-devbind.py | 34 +++++++++++++++++++++++++++-------
1 file changed, 27 insertions(+), 7 deletions(-)
diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index bb4d536..1e8ed1f 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -86,7 +86,8 @@ def usage():
Display usage information and quit
-s, --status:
- Print the current status of all known network and crypto devices.
+ Print the current status of all known network, crypto, event
+ and mempool devices.
For each device, it displays the PCI domain, bus, slot and function,
along with a text description of the device. Depending upon whether the
device is being used by a kernel driver, the igb_uio driver, or no
@@ -99,6 +100,10 @@ def usage():
status display will always occur after the other operations have taken
place.
+ --status-dev:
+ Print the status of given device group. Supported device groups are:
+ "net", "crypto", "event" and "mempool"
+
-b driver, --bind=driver:
Select the driver to use or \"none\" to unbind the device
@@ -119,6 +124,9 @@ def usage():
To display current device status:
%(argv0)s --status
+To display current network device status:
+ %(argv0)s --status-dev net
+
To bind eth1 from the current driver and move to use igb_uio
%(argv0)s --bind=igb_uio eth1
@@ -598,16 +606,24 @@ def show_status():
Displays to the user what devices are bound to the igb_uio driver, the
kernel driver or to no driver'''
- show_device_status(network_devices, "Network")
- show_device_status(crypto_devices, "Crypto")
- show_device_status(eventdev_devices, "Eventdev")
- show_device_status(mempool_devices, "Mempool")
+ if status_dev == "net" or status_dev == "all":
+ show_device_status(network_devices, "Network")
+
+ if status_dev == "crypto" or status_dev == "all":
+ show_device_status(crypto_devices, "Crypto")
+
+ if status_dev == "event" or status_dev == "all":
+ show_device_status(eventdev_devices, "Eventdev")
+
+ if status_dev == "mempool" or status_dev == "all":
+ show_device_status(mempool_devices, "Mempool")
def parse_args():
'''Parses the command-line arguments given by the user and takes the
appropriate action for each'''
global b_flag
global status_flag
+ global status_dev
global force_flag
global args
if len(sys.argv) <= 1:
@@ -616,8 +632,8 @@ def parse_args():
try:
opts, args = getopt.getopt(sys.argv[1:], "b:us",
- ["help", "usage", "status", "force",
- "bind=", "unbind"])
+ ["help", "usage", "status", "status-dev=",
+ "force", "bind=", "unbind", ])
except getopt.GetoptError as error:
print(str(error))
print("Run '%s --usage' for further information" % sys.argv[0])
@@ -627,8 +643,12 @@ def parse_args():
if opt == "--help" or opt == "--usage":
usage()
sys.exit(0)
+ if opt == "--status-dev":
+ status_flag = True
+ status_dev = arg
if opt == "--status" or opt == "-s":
status_flag = True
+ status_dev = "all"
if opt == "--force":
force_flag = True
if opt == "-b" or opt == "-u" or opt == "--bind" or opt == "--unbind":
--
2.9.3
next prev parent reply other threads:[~2017-04-27 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 11:58 [dpdk-dev] [PATCH] usertools: reduce devbind status output Ferruh Yigit
2017-04-26 13:09 ` Thomas Monjalon
2017-04-27 17:55 ` Ferruh Yigit [this message]
2017-04-30 12:45 ` [dpdk-dev] [PATCH v2] usertools: add status-dev argument to devbind Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170427175537.26147-1-ferruh.yigit@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).