From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Allain Legacy <allain.legacy@windriver.com>; Matt Peters
<matt.peters@windriver.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: [dpdk-dev] [PATCH] net/avp: fix interrupt migration check
Date: Fri, 28 Apr 2017 07:49:03 +0100 [thread overview]
Message-ID: <20170428064903.19286-1-ferruh.yigit@intel.com> (raw)
Bitwise OR within if statement is always true, fix bitwise operator.
Coverity issue: 1423906
Fixes: 82e140b84995 ("net/avp: handle interrupt migration")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/avp/avp_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index 9ca2786..fe6849f 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -712,7 +712,7 @@ avp_dev_interrupt_handler(void *data)
RTE_PTR_ADD(registers,
RTE_AVP_INTERRUPT_STATUS_OFFSET));
- if (status | RTE_AVP_MIGRATION_INTERRUPT_MASK) {
+ if (status & RTE_AVP_MIGRATION_INTERRUPT_MASK) {
/* handle interrupt based on current status */
value = AVP_READ32(
RTE_PTR_ADD(registers,
--
2.9.3
next reply other threads:[~2017-04-28 6:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 6:49 Ferruh Yigit [this message]
2017-04-28 10:52 ` Legacy, Allain
2017-04-28 12:47 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428064903.19286-1-ferruh.yigit@intel.com \
--to=ferruh.yigit@intel.com \
--cc=allain.legacy@windriver.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).