From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <yuanhan.liu@linux.intel.com> Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 614E79E3 for <dev@dpdk.org>; Fri, 28 Apr 2017 10:30:47 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Apr 2017 01:30:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,387,1488873600"; d="scan'208";a="1124371050" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga001.jf.intel.com with ESMTP; 28 Apr 2017 01:30:45 -0700 Date: Fri, 28 Apr 2017 16:27:06 +0800 From: Yuanhan Liu <yuanhan.liu@linux.intel.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: dev@dpdk.org Message-ID: <20170428082706.GY11512@yliu-dev.sh.intel.com> References: <1493364114-7771-1-git-send-email-yuanhan.liu@linux.intel.com> <1679460.mJD8jeqIBn@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1679460.mJD8jeqIBn@xps> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] devtools: list stable commits do not have fixline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 28 Apr 2017 08:30:48 -0000 On Fri, Apr 28, 2017 at 10:15:46AM +0200, Thomas Monjalon wrote: > 28/04/2017 09:21, Yuanhan Liu: > > Some commits for stable releases (with Cc stable tag) may not have the > > fixline. For example: > > http://dpdk.org/dev/patchwork/patch/23955/ > > > > It disables a feature we have implemented in last release. The feature > > is done right. It's the QEMU implementaton being buggy, that we have to > > disable it to workaround those buggy QEMU releases (v2.7 - v2.9). Without > > such workaround, QEMU won't start when queue number >= 2. > > > > That said, we also have to backport it to stable releases, though there > > is no fixline (there was no DPDK bug to fix after all). > > How do we know where should it be backported? Good question. As a stable maintainer, I may not know. But the developer should know. For such case, he may add something like: Cc: stable@dpdk.org # for v17.02+ It's a trick used widely in kernel and QEMU community. > It is fixing a bug with a correct implementation because of > a buggy dependency. But it is still a bug. > So I think we should put a Fixes: line. I don't have strong objection to this. It just doesn't make too much sense to me: there is no bug in the DPDK implementation after all. But if you insist, I'm okay with it. > > > > There should be similar cases like this. Thus, this patch makes > > git-log-fixes.sh script also list those stable commits do not have > > fixline. > > I am against putting Cc: stable without Fixes: line. General, yes. And luckily, that should be rare. > However, this patch is harmless. Yes. Moreover, we should not miss some important fixes with it. --yliu