DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 0/4] Rel 17.08: add compile time checks to vpmds
@ 2017-04-28 16:21 Bruce Richardson
  2017-04-28 16:21 ` [dpdk-dev] [PATCH 1/4] net/ixgbe: add compile-time checks to vector driver Bruce Richardson
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Bruce Richardson @ 2017-04-28 16:21 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson

As previously discussed*, add some compile time checks to the vpmds to
help sanity-check their dependencies on the mbuf layout.

* http://dpdk.org/ml/archives/dev/2017-April/064988.html

Bruce Richardson (4):
  net/ixgbe: add compile-time checks to vector driver
  net/ixgbe: enable ixgbe vector PMD for i686
  net/i40e: add compile-time checks to vector driver
  net/fm10k: add compile-time checks to vector driver

 config/defconfig_i686-native-linuxapp-gcc |  5 -----
 drivers/net/fm10k/fm10k_rxtx_vec.c        | 15 +++++++++++++++
 drivers/net/i40e/i40e_rxtx_vec_sse.c      | 30 ++++++++++++++++++++++++++++++
 drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c    | 29 +++++++++++++++++++++++++++++
 4 files changed, 74 insertions(+), 5 deletions(-)

-- 
2.9.3

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH 1/4] net/ixgbe: add compile-time checks to vector driver
  2017-04-28 16:21 [dpdk-dev] [PATCH 0/4] Rel 17.08: add compile time checks to vpmds Bruce Richardson
@ 2017-04-28 16:21 ` Bruce Richardson
  2017-04-28 16:21 ` [dpdk-dev] [PATCH 2/4] net/ixgbe: enable ixgbe vector PMD for i686 Bruce Richardson
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Bruce Richardson @ 2017-04-28 16:21 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson

The vector PMD is very sensitive to the layout of the mbuf, especially on
the RX path. Add in some compile-time checks to make sure the mbuf layout
assumptions are valid, and to provide hints to anyone changing the mbuf
where things may need to be updated.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c
index 795ee33..83a96b5 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c
@@ -87,6 +87,8 @@ ixgbe_rxq_rearm(struct ixgbe_rx_queue *rxq)
 		mb1 = rxep[1].mbuf;
 
 		/* load buf_addr(lo 64bit) and buf_physaddr(hi 64bit) */
+		RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, buf_physaddr) !=
+				offsetof(struct rte_mbuf, buf_addr) + 8);
 		vaddr0 = _mm_loadu_si128((__m128i *)&(mb0->buf_addr));
 		vaddr1 = _mm_loadu_si128((__m128i *)&(mb1->buf_addr));
 
@@ -234,6 +236,11 @@ desc_to_olflags_v(__m128i descs[4], __m128i mbuf_init, uint8_t vlan_flags,
 
 #endif /* RTE_MACHINE_CPUFLAG_SSE4_2 */
 
+	/* write the rearm data and the olflags in one write */
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, ol_flags) !=
+			offsetof(struct rte_mbuf, rearm_data) + 8);
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, rearm_data) !=
+			RTE_ALIGN(offsetof(struct rte_mbuf, rearm_data), 16));
 	_mm_store_si128((__m128i *)&rx_pkts[0]->rearm_data, rearm0);
 	_mm_store_si128((__m128i *)&rx_pkts[1]->rearm_data, rearm1);
 	_mm_store_si128((__m128i *)&rx_pkts[2]->rearm_data, rearm2);
@@ -266,6 +273,15 @@ _recv_raw_pkts_vec(struct ixgbe_rx_queue *rxq, struct rte_mbuf **rx_pkts,
 				-rxq->crc_len, /* sub crc on pkt_len */
 				0, 0            /* ignore pkt_type field */
 			);
+	/*
+	 * compile-time check the above crc_adjust layout is correct.
+	 * NOTE: the first field (lowest address) is given last in set_epi16
+	 * call above.
+	 */
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, pkt_len) !=
+			offsetof(struct rte_mbuf, rx_descriptor_fields1) + 4);
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_len) !=
+			offsetof(struct rte_mbuf, rx_descriptor_fields1) + 8);
 	__m128i dd_check, eop_check;
 	__m128i mbuf_init;
 	uint8_t vlan_flags;
@@ -312,6 +328,19 @@ _recv_raw_pkts_vec(struct ixgbe_rx_queue *rxq, struct rte_mbuf **rx_pkts,
 		0xFF, 0xFF,  /* skip 32 bit pkt_type */
 		0xFF, 0xFF
 		);
+	/*
+	 * Compile-time verify the shuffle mask
+	 * NOTE: some field positions already verified above, but duplicated
+	 * here for completeness in case of future modifications.
+	 */
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, pkt_len) !=
+			offsetof(struct rte_mbuf, rx_descriptor_fields1) + 4);
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_len) !=
+			offsetof(struct rte_mbuf, rx_descriptor_fields1) + 8);
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, vlan_tci) !=
+			offsetof(struct rte_mbuf, rx_descriptor_fields1) + 10);
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, hash) !=
+			offsetof(struct rte_mbuf, rx_descriptor_fields1) + 12);
 
 	mbuf_init = _mm_set_epi64x(0, rxq->mbuf_initializer);
 
-- 
2.9.3

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH 2/4] net/ixgbe: enable ixgbe vector PMD for i686
  2017-04-28 16:21 [dpdk-dev] [PATCH 0/4] Rel 17.08: add compile time checks to vpmds Bruce Richardson
  2017-04-28 16:21 ` [dpdk-dev] [PATCH 1/4] net/ixgbe: add compile-time checks to vector driver Bruce Richardson
@ 2017-04-28 16:21 ` Bruce Richardson
  2017-04-28 16:21 ` [dpdk-dev] [PATCH 3/4] net/i40e: add compile-time checks to vector driver Bruce Richardson
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Bruce Richardson @ 2017-04-28 16:21 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson

The ixgbe vector PMD was disabled for i686 unnecessarily. Enable it.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 config/defconfig_i686-native-linuxapp-gcc | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/config/defconfig_i686-native-linuxapp-gcc b/config/defconfig_i686-native-linuxapp-gcc
index 9847bdb..60afe15 100644
--- a/config/defconfig_i686-native-linuxapp-gcc
+++ b/config/defconfig_i686-native-linuxapp-gcc
@@ -47,11 +47,6 @@ CONFIG_RTE_TOOLCHAIN_GCC=y
 CONFIG_RTE_LIBRTE_KNI=n
 
 #
-# Vectorized PMD is not supported on 32-bit
-#
-CONFIG_RTE_IXGBE_INC_VECTOR=n
-
-#
 # Solarflare PMD is not supported on 32-bit
 #
 CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
-- 
2.9.3

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH 3/4] net/i40e: add compile-time checks to vector driver
  2017-04-28 16:21 [dpdk-dev] [PATCH 0/4] Rel 17.08: add compile time checks to vpmds Bruce Richardson
  2017-04-28 16:21 ` [dpdk-dev] [PATCH 1/4] net/ixgbe: add compile-time checks to vector driver Bruce Richardson
  2017-04-28 16:21 ` [dpdk-dev] [PATCH 2/4] net/ixgbe: enable ixgbe vector PMD for i686 Bruce Richardson
@ 2017-04-28 16:21 ` Bruce Richardson
  2017-04-28 16:21 ` [dpdk-dev] [PATCH 4/4] net/fm10k: " Bruce Richardson
  2017-05-12 11:17 ` [dpdk-dev] [PATCH 0/4] Rel 17.08: add compile time checks to vpmds Ferruh Yigit
  4 siblings, 0 replies; 6+ messages in thread
From: Bruce Richardson @ 2017-04-28 16:21 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson

The vector PMD is very sensitive to the layout of the mbuf, especially on
the RX path. Add in some compile-time checks to make sure the mbuf layout
assumptions are valid, and to provide hints to anyone changing the mbuf
where things may need to be updated.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/i40e/i40e_rxtx_vec_sse.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/drivers/net/i40e/i40e_rxtx_vec_sse.c b/drivers/net/i40e/i40e_rxtx_vec_sse.c
index 8bc3399..28bdf4f 100644
--- a/drivers/net/i40e/i40e_rxtx_vec_sse.c
+++ b/drivers/net/i40e/i40e_rxtx_vec_sse.c
@@ -87,6 +87,8 @@ i40e_rxq_rearm(struct i40e_rx_queue *rxq)
 		mb1 = rxep[1].mbuf;
 
 		/* load buf_addr(lo 64bit) and buf_physaddr(hi 64bit) */
+		RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, buf_physaddr) !=
+				offsetof(struct rte_mbuf, buf_addr) + 8);
 		vaddr0 = _mm_loadu_si128((__m128i *)&mb0->buf_addr);
 		vaddr1 = _mm_loadu_si128((__m128i *)&mb1->buf_addr);
 
@@ -203,6 +205,12 @@ desc_to_olflags_v(struct i40e_rx_queue *rxq, __m128i descs[4] __rte_unused,
 	rearm1 = _mm_blend_epi16(mbuf_init, _mm_slli_si128(vlan0, 4), 0x10);
 	rearm2 = _mm_blend_epi16(mbuf_init, vlan0, 0x10);
 	rearm3 = _mm_blend_epi16(mbuf_init, _mm_srli_si128(vlan0, 4), 0x10);
+
+	/* write the rearm data and the olflags in one write */
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, ol_flags) !=
+			offsetof(struct rte_mbuf, rearm_data) + 8);
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, rearm_data) !=
+			RTE_ALIGN(offsetof(struct rte_mbuf, rearm_data), 16));
 	_mm_store_si128((__m128i *)&rx_pkts[0]->rearm_data, rearm0);
 	_mm_store_si128((__m128i *)&rx_pkts[1]->rearm_data, rearm1);
 	_mm_store_si128((__m128i *)&rx_pkts[2]->rearm_data, rearm2);
@@ -252,6 +260,15 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts,
 				-rxq->crc_len, /* sub crc on pkt_len */
 				0, 0            /* ignore pkt_type field */
 			);
+	/*
+	 * compile-time check the above crc_adjust layout is correct.
+	 * NOTE: the first field (lowest address) is given last in set_epi16
+	 * call above.
+	 */
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, pkt_len) !=
+			offsetof(struct rte_mbuf, rx_descriptor_fields1) + 4);
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_len) !=
+			offsetof(struct rte_mbuf, rx_descriptor_fields1) + 8);
 	__m128i dd_check, eop_check;
 
 	/* nb_pkts shall be less equal than RTE_I40E_MAX_RX_BURST */
@@ -296,6 +313,19 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts,
 		0xFF, 0xFF,  /* pkt_type set as unknown */
 		0xFF, 0xFF  /*pkt_type set as unknown */
 		);
+	/*
+	 * Compile-time verify the shuffle mask
+	 * NOTE: some field positions already verified above, but duplicated
+	 * here for completeness in case of future modifications.
+	 */
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, pkt_len) !=
+			offsetof(struct rte_mbuf, rx_descriptor_fields1) + 4);
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_len) !=
+			offsetof(struct rte_mbuf, rx_descriptor_fields1) + 8);
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, vlan_tci) !=
+			offsetof(struct rte_mbuf, rx_descriptor_fields1) + 10);
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, hash) !=
+			offsetof(struct rte_mbuf, rx_descriptor_fields1) + 12);
 
 	/* Cache is empty -> need to scan the buffer rings, but first move
 	 * the next 'n' mbufs into the cache
-- 
2.9.3

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH 4/4] net/fm10k: add compile-time checks to vector driver
  2017-04-28 16:21 [dpdk-dev] [PATCH 0/4] Rel 17.08: add compile time checks to vpmds Bruce Richardson
                   ` (2 preceding siblings ...)
  2017-04-28 16:21 ` [dpdk-dev] [PATCH 3/4] net/i40e: add compile-time checks to vector driver Bruce Richardson
@ 2017-04-28 16:21 ` Bruce Richardson
  2017-05-12 11:17 ` [dpdk-dev] [PATCH 0/4] Rel 17.08: add compile time checks to vpmds Ferruh Yigit
  4 siblings, 0 replies; 6+ messages in thread
From: Bruce Richardson @ 2017-04-28 16:21 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson

The vector PMD is very sensitive to the layout of the mbuf, especially on
the RX path. Add in some compile-time checks to make sure the mbuf layout
assumptions are valid, and to provide hints to anyone changing the mbuf
where things may need to be updated.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/fm10k/fm10k_rxtx_vec.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/net/fm10k/fm10k_rxtx_vec.c b/drivers/net/fm10k/fm10k_rxtx_vec.c
index 89cd958..c0a8e34 100644
--- a/drivers/net/fm10k/fm10k_rxtx_vec.c
+++ b/drivers/net/fm10k/fm10k_rxtx_vec.c
@@ -331,6 +331,8 @@ fm10k_rxq_rearm(struct fm10k_rx_queue *rxq)
 		*(uint64_t *)p1 = rxq->mbuf_initializer;
 
 		/* load buf_addr(lo 64bit) and buf_physaddr(hi 64bit) */
+		RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, buf_physaddr) !=
+				offsetof(struct rte_mbuf, buf_addr) + 8);
 		vaddr0 = _mm_loadu_si128((__m128i *)&mb0->buf_addr);
 		vaddr1 = _mm_loadu_si128((__m128i *)&mb1->buf_addr);
 
@@ -448,6 +450,19 @@ fm10k_recv_raw_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
 		0xFF, 0xFF,  /* skip high 16 bits pkt_type */
 		0xFF, 0xFF   /* Skip pkt_type field in shuffle operation */
 		);
+	/*
+	 * Compile-time verify the shuffle mask
+	 * NOTE: some field positions already verified above, but duplicated
+	 * here for completeness in case of future modifications.
+	 */
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, pkt_len) !=
+			offsetof(struct rte_mbuf, rx_descriptor_fields1) + 4);
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_len) !=
+			offsetof(struct rte_mbuf, rx_descriptor_fields1) + 8);
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, vlan_tci) !=
+			offsetof(struct rte_mbuf, rx_descriptor_fields1) + 10);
+	RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, hash) !=
+			offsetof(struct rte_mbuf, rx_descriptor_fields1) + 12);
 
 	/* Cache is empty -> need to scan the buffer rings, but first move
 	 * the next 'n' mbufs into the cache
-- 
2.9.3

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH 0/4] Rel 17.08: add compile time checks to vpmds
  2017-04-28 16:21 [dpdk-dev] [PATCH 0/4] Rel 17.08: add compile time checks to vpmds Bruce Richardson
                   ` (3 preceding siblings ...)
  2017-04-28 16:21 ` [dpdk-dev] [PATCH 4/4] net/fm10k: " Bruce Richardson
@ 2017-05-12 11:17 ` Ferruh Yigit
  4 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2017-05-12 11:17 UTC (permalink / raw)
  To: Bruce Richardson, dev

On 4/28/2017 5:21 PM, Bruce Richardson wrote:
> As previously discussed*, add some compile time checks to the vpmds to
> help sanity-check their dependencies on the mbuf layout.
> 
> * http://dpdk.org/ml/archives/dev/2017-April/064988.html
> 
> Bruce Richardson (4):
>   net/ixgbe: add compile-time checks to vector driver
>   net/ixgbe: enable ixgbe vector PMD for i686
>   net/i40e: add compile-time checks to vector driver
>   net/fm10k: add compile-time checks to vector driver

Series applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-05-12 11:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-28 16:21 [dpdk-dev] [PATCH 0/4] Rel 17.08: add compile time checks to vpmds Bruce Richardson
2017-04-28 16:21 ` [dpdk-dev] [PATCH 1/4] net/ixgbe: add compile-time checks to vector driver Bruce Richardson
2017-04-28 16:21 ` [dpdk-dev] [PATCH 2/4] net/ixgbe: enable ixgbe vector PMD for i686 Bruce Richardson
2017-04-28 16:21 ` [dpdk-dev] [PATCH 3/4] net/i40e: add compile-time checks to vector driver Bruce Richardson
2017-04-28 16:21 ` [dpdk-dev] [PATCH 4/4] net/fm10k: " Bruce Richardson
2017-05-12 11:17 ` [dpdk-dev] [PATCH 0/4] Rel 17.08: add compile time checks to vpmds Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).