From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <tiwei.bie@intel.com> Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 999961C00 for <dev@dpdk.org>; Thu, 11 May 2017 03:01:19 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2017 18:01:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,322,1491289200"; d="scan'208";a="259689561" Received: from debian.sh.intel.com (HELO debian) ([10.239.67.137]) by fmsmga004.fm.intel.com with ESMTP; 10 May 2017 18:01:17 -0700 Date: Thu, 11 May 2017 09:03:06 +0800 From: Tiwei Bie <tiwei.bie@intel.com> To: "Richardson, Bruce" <bruce.richardson@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org> Message-ID: <20170511010305.GA17016@debian> References: <20170509084707.29949-1-tiwei.bie@intel.com> <59AF69C657FD0841A61C55336867B5B066763FE9@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <59AF69C657FD0841A61C55336867B5B066763FE9@IRSMSX103.ger.corp.intel.com> User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH 0/2] Various fixes for contigmem X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 11 May 2017 01:01:20 -0000 On Wed, May 10, 2017 at 10:05:19PM +0800, Richardson, Bruce wrote: > > > -----Original Message----- > > From: Bie, Tiwei > > Sent: Tuesday, May 9, 2017 9:47 AM > > To: dev@dpdk.org > > Cc: Richardson, Bruce <bruce.richardson@intel.com> > > Subject: [PATCH 0/2] Various fixes for contigmem > > > > Tiwei Bie (2): > > contigmem: free the allocated memory when error occurs > > contigmem: don't zero the pages during each mmap > > > > lib/librte_eal/bsdapp/contigmem/contigmem.c | 186 > > ++++++++++++++++++++++++---- > > 1 file changed, 161 insertions(+), 25 deletions(-) > > > These look better solutions than the previous ones for multi-process. > > Acked-by: Bruce Richardson <bruce.richardson@intel.com> > > Given that this is not a new bug in this release, I don't think we should take the risk of applying the patches this late in the 17.05 release cycle. I therefore suggest that they be merged for 17.08 and once tested in that release, backported to 17.05 stable. > Yeah, I agree. It's not a minor change. Best regards, Tiwei Bie