DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ashwin Sekhar T K <ashwin.sekhar@caviumnetworks.com>
To: jerin.jacob@caviumnetworks.com, thomas@monjalon.net,
	maciej.czekaj@caviumnetworks.com, viktorin@rehivetech.com,
	jianbo.liu@linaro.org, bruce.richardson@intel.com,
	pablo.de.lara.guarch@intel.com, konstantin.ananyev@intel.com
Cc: dev@dpdk.org, Ashwin Sekhar T K <ashwin.sekhar@caviumnetworks.com>
Subject: [dpdk-dev] [PATCH v3 1/6] eal: pause while busy-waiting for slave
Date: Thu, 11 May 2017 22:45:42 -0700	[thread overview]
Message-ID: <20170512054547.753-2-ashwin.sekhar@caviumnetworks.com> (raw)
In-Reply-To: <20170512054547.753-1-ashwin.sekhar@caviumnetworks.com>

Instead of simply busy-waiting for slave in rte_eal_wait_lcore()
do rte_pause(). This will give power savings.

This also fixes warning -Wempty-body seen with armv8a clang
compilation.

Signed-off-by: Ashwin Sekhar T K <ashwin.sekhar@caviumnetworks.com>
Suggested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 lib/librte_eal/common/eal_common_launch.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/eal_common_launch.c b/lib/librte_eal/common/eal_common_launch.c
index 229c3a034..184846606 100644
--- a/lib/librte_eal/common/eal_common_launch.c
+++ b/lib/librte_eal/common/eal_common_launch.c
@@ -54,7 +54,8 @@ rte_eal_wait_lcore(unsigned slave_id)
 		return 0;
 
 	while (lcore_config[slave_id].state != WAIT &&
-	       lcore_config[slave_id].state != FINISHED);
+	       lcore_config[slave_id].state != FINISHED)
+		rte_pause();
 
 	rte_rmb();
 
-- 
2.12.2

  reply	other threads:[~2017-05-12  5:46 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-10 10:16 [dpdk-dev] [PATCH 0/6] add clang compilation support for armv8a linuxapp Ashwin Sekhar T K
2017-05-10 10:16 ` [dpdk-dev] [PATCH 1/6] hash: compile armv8a CRC32 support conditionally Ashwin Sekhar T K
2017-05-11  5:21   ` Jerin Jacob
2017-05-11 14:33   ` [dpdk-dev] [PATCH v2 0/6] Add clang compilation support for armv8a linuxapp Ashwin Sekhar T K
2017-05-11 14:33     ` [dpdk-dev] [PATCH v2 1/6] hash: compile armv8a CRC32 support conditionally Ashwin Sekhar T K
2017-05-11 14:33     ` [dpdk-dev] [PATCH v2 2/6] config: add clang support for armv8a linuxapp Ashwin Sekhar T K
2017-05-12  5:17       ` Jerin Jacob
2017-05-11 14:33     ` [dpdk-dev] [PATCH v2 3/6] net/thunderx: fix compile errors for armv8a clang Ashwin Sekhar T K
2017-05-11 14:33     ` [dpdk-dev] [PATCH v2 4/6] acl: fix warning seen with " Ashwin Sekhar T K
2017-05-11 14:33     ` [dpdk-dev] [PATCH v2 5/6] eal/arm: fix warnings " Ashwin Sekhar T K
2017-05-11 14:33     ` [dpdk-dev] [PATCH v2 6/6] eal: pause while busy-waiting for slave Ashwin Sekhar T K
2017-05-10 10:16 ` [dpdk-dev] [PATCH 2/6] config: add clang support for armv8a linuxapp Ashwin Sekhar T K
2017-05-11  5:24   ` Jerin Jacob
2017-05-11  5:37     ` Sekhar, Ashwin
2017-05-11  6:58       ` Jerin Jacob
2017-05-10 10:16 ` [dpdk-dev] [PATCH 3/6] net/thunderx: fix compile errors for armv8a clang Ashwin Sekhar T K
2017-05-11  5:28   ` Jerin Jacob
2017-05-10 10:16 ` [dpdk-dev] [PATCH 4/6] acl: fix warning seen with " Ashwin Sekhar T K
2017-05-11  5:32   ` Jerin Jacob
2017-05-10 10:16 ` [dpdk-dev] [PATCH 5/6] eal/arm: fix warnings " Ashwin Sekhar T K
2017-05-11  5:33   ` Jerin Jacob
2017-05-10 10:16 ` [dpdk-dev] [PATCH 6/6] eal: fix warning " Ashwin Sekhar T K
2017-05-11  5:52   ` Jerin Jacob
2017-05-11  5:59 ` [dpdk-dev] [PATCH 0/6] add clang compilation support for armv8a linuxapp Jerin Jacob
2017-05-11 14:09   ` Sekhar, Ashwin
2017-05-12  5:45 ` [dpdk-dev] [PATCH v3 0/6] Add " Ashwin Sekhar T K
2017-05-12  5:45   ` Ashwin Sekhar T K [this message]
2017-05-12  5:45   ` [dpdk-dev] [PATCH v3 2/6] hash: compile armv8a CRC32 support conditionally Ashwin Sekhar T K
2017-05-12  5:45   ` [dpdk-dev] [PATCH v3 3/6] net/thunderx: fix compile errors for armv8a clang Ashwin Sekhar T K
2017-05-12  5:45   ` [dpdk-dev] [PATCH v3 4/6] acl: fix warning seen with " Ashwin Sekhar T K
2017-05-12  5:45   ` [dpdk-dev] [PATCH v3 5/6] eal/arm: fix warnings " Ashwin Sekhar T K
2017-05-12  5:45   ` [dpdk-dev] [PATCH v3 6/6] config: add clang support for armv8a linuxapp Ashwin Sekhar T K
2017-05-12  6:10     ` Jianbo Liu
2017-05-15 10:24       ` Hemant Agrawal
2017-05-15 10:29   ` [dpdk-dev] [PATCH v3 0/6] Add clang compilation " Hemant Agrawal
2017-07-03 20:29     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170512054547.753-2-ashwin.sekhar@caviumnetworks.com \
    --to=ashwin.sekhar@caviumnetworks.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=jianbo.liu@linaro.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=maciej.czekaj@caviumnetworks.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=thomas@monjalon.net \
    --cc=viktorin@rehivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).