DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/testpmd: add TCP flags in flow API
@ 2017-05-18  9:06 Beilei Xing
  2017-05-18  9:14 ` Zhao1, Wei
  2017-05-18  9:22 ` Adrien Mazarguil
  0 siblings, 2 replies; 5+ messages in thread
From: Beilei Xing @ 2017-05-18  9:06 UTC (permalink / raw)
  To: adrien.mazarguil; +Cc: dev, wei.zhao1

This commit adds TCP flags support in flow API as
some drivers have SYN filter.

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
 app/test-pmd/cmdline_flow.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 0fd69f9..3e5803a 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -152,6 +152,7 @@ enum index {
 	ITEM_TCP,
 	ITEM_TCP_SRC,
 	ITEM_TCP_DST,
+	ITEM_TCP_FLAGS,
 	ITEM_SCTP,
 	ITEM_SCTP_SRC,
 	ITEM_SCTP_DST,
@@ -531,6 +532,7 @@ static const enum index item_udp[] = {
 static const enum index item_tcp[] = {
 	ITEM_TCP_SRC,
 	ITEM_TCP_DST,
+	ITEM_TCP_FLAGS,
 	ITEM_NEXT,
 	ZERO,
 };
@@ -1267,6 +1269,13 @@ static const struct token token_list[] = {
 		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_tcp,
 					     hdr.dst_port)),
 	},
+	[ITEM_TCP_FLAGS] = {
+		.name = "flags",
+		.help = "TCP flags",
+		.next = NEXT(item_tcp, NEXT_ENTRY(UNSIGNED), item_param),
+		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_tcp,
+					     hdr.tcp_flags)),
+	},
 	[ITEM_SCTP] = {
 		.name = "sctp",
 		.help = "match SCTP header",
-- 
2.5.5

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] app/testpmd: add TCP flags in flow API
  2017-05-18  9:06 [dpdk-dev] [PATCH] app/testpmd: add TCP flags in flow API Beilei Xing
@ 2017-05-18  9:14 ` Zhao1, Wei
  2017-06-08 21:10   ` Thomas Monjalon
  2017-05-18  9:22 ` Adrien Mazarguil
  1 sibling, 1 reply; 5+ messages in thread
From: Zhao1, Wei @ 2017-05-18  9:14 UTC (permalink / raw)
  To: Xing, Beilei, adrien.mazarguil; +Cc: dev

Test that patch use flow API of igb NIC syn filter, it is ok.
 
Acked-by: Wei Zhao <wei.zhao1@intel.com>

> -----Original Message-----
> From: Xing, Beilei
> Sent: Thursday, May 18, 2017 5:06 PM
> To: adrien.mazarguil@6wind.com
> Cc: dev@dpdk.org; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] app/testpmd: add TCP flags in flow API
> 
> This commit adds TCP flags support in flow API as some drivers have SYN
> filter.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
>  app/test-pmd/cmdline_flow.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 0fd69f9..3e5803a 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -152,6 +152,7 @@ enum index {
>  	ITEM_TCP,
>  	ITEM_TCP_SRC,
>  	ITEM_TCP_DST,
> +	ITEM_TCP_FLAGS,
>  	ITEM_SCTP,
>  	ITEM_SCTP_SRC,
>  	ITEM_SCTP_DST,
> @@ -531,6 +532,7 @@ static const enum index item_udp[] = {  static const
> enum index item_tcp[] = {
>  	ITEM_TCP_SRC,
>  	ITEM_TCP_DST,
> +	ITEM_TCP_FLAGS,
>  	ITEM_NEXT,
>  	ZERO,
>  };
> @@ -1267,6 +1269,13 @@ static const struct token token_list[] = {
>  		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_tcp,
>  					     hdr.dst_port)),
>  	},
> +	[ITEM_TCP_FLAGS] = {
> +		.name = "flags",
> +		.help = "TCP flags",
> +		.next = NEXT(item_tcp, NEXT_ENTRY(UNSIGNED),
> item_param),
> +		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_tcp,
> +					     hdr.tcp_flags)),
> +	},
>  	[ITEM_SCTP] = {
>  		.name = "sctp",
>  		.help = "match SCTP header",
> --
> 2.5.5

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] app/testpmd: add TCP flags in flow API
  2017-05-18  9:06 [dpdk-dev] [PATCH] app/testpmd: add TCP flags in flow API Beilei Xing
  2017-05-18  9:14 ` Zhao1, Wei
@ 2017-05-18  9:22 ` Adrien Mazarguil
  2017-06-08 21:13   ` Thomas Monjalon
  1 sibling, 1 reply; 5+ messages in thread
From: Adrien Mazarguil @ 2017-05-18  9:22 UTC (permalink / raw)
  To: Beilei Xing; +Cc: dev, wei.zhao1

On Thu, May 18, 2017 at 05:06:12PM +0800, Beilei Xing wrote:
> This commit adds TCP flags support in flow API as
> some drivers have SYN filter.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

-- 
Adrien Mazarguil
6WIND

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] app/testpmd: add TCP flags in flow API
  2017-05-18  9:14 ` Zhao1, Wei
@ 2017-06-08 21:10   ` Thomas Monjalon
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2017-06-08 21:10 UTC (permalink / raw)
  To: Zhao1, Wei; +Cc: dev, Xing, Beilei, adrien.mazarguil

18/05/2017 11:14, Zhao1, Wei:
> Test that patch use flow API of igb NIC syn filter, it is ok.
>  
> Acked-by: Wei Zhao <wei.zhao1@intel.com>

In this case, I think the appropriate tag is Tested-by ;)
Thanks

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] app/testpmd: add TCP flags in flow API
  2017-05-18  9:22 ` Adrien Mazarguil
@ 2017-06-08 21:13   ` Thomas Monjalon
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2017-06-08 21:13 UTC (permalink / raw)
  To: Beilei Xing; +Cc: dev, Adrien Mazarguil, wei.zhao1

18/05/2017 11:22, Adrien Mazarguil:
> On Thu, May 18, 2017 at 05:06:12PM +0800, Beilei Xing wrote:
> > This commit adds TCP flags support in flow API as
> > some drivers have SYN filter.
> > 
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-06-08 21:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-18  9:06 [dpdk-dev] [PATCH] app/testpmd: add TCP flags in flow API Beilei Xing
2017-05-18  9:14 ` Zhao1, Wei
2017-06-08 21:10   ` Thomas Monjalon
2017-05-18  9:22 ` Adrien Mazarguil
2017-06-08 21:13   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).