From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C9B727CA3 for ; Wed, 24 May 2017 10:42:45 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 May 2017 01:42:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,385,1491289200"; d="scan'208";a="1173630501" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga002.fm.intel.com with ESMTP; 24 May 2017 01:42:43 -0700 Date: Wed, 24 May 2017 16:42:50 +0800 From: Yuanhan Liu To: Jens Freimann Cc: "Wang, Zhihong" , "dev@dpdk.org" Message-ID: <20170524084250.GW2276@yliu-dev> References: <1495483268-60184-1-git-send-email-zhihong.wang@intel.com> <20170523115335.gtykyluswrsjuls3@dhcp-192-218.str.redhat.com> <8F6C2BD409508844A0EFC19955BE09415127D9EE@SHSMSX103.ccr.corp.intel.com> <20170524081419.GU2276@yliu-dev> <20170524083601.sd7sueoskpfeyxt7@dhcp-192-218.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170524083601.sd7sueoskpfeyxt7@dhcp-192-218.str.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] vhost: support rx_queue_count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 May 2017 08:42:46 -0000 On Wed, May 24, 2017 at 10:36:01AM +0200, Jens Freimann wrote: > On Wed, May 24, 2017 at 04:14:19PM +0800, Yuanhan Liu wrote: > > On Tue, May 23, 2017 at 12:51:56PM +0000, Wang, Zhihong wrote: > > > > > > > > > > -----Original Message----- > > > > From: Jens Freimann [mailto:jfreiman@redhat.com] > > > > Sent: Tuesday, May 23, 2017 7:54 PM > > > > To: Wang, Zhihong > > > > Cc: dev@dpdk.org; yuanhan.liu@linux.intel.com > > > > Subject: Re: [dpdk-dev] [PATCH] vhost: support rx_queue_count > > > > > > > > On Mon, May 22, 2017 at 04:01:08PM -0400, Zhihong Wang wrote: > > > > > This patch implements the ops rx_queue_count for vhost PMD by adding > > > > > a helper function rte_vhost_rx_queue_count in vhost lib. > > > > > > > > > > The ops ops rx_queue_count gets vhost RX queue avail count and helps > > > > > > > > s/ops ops/ops/ ? > > > > > > Thanks a lot! > > > > Seems you overlooked other comments, such as: > > > > > > > + vq = dev->virtqueue[qid]; > > > > > > > > check for vq == NULL? > > > > > > > > regards, > > > > Jens > > > > Besides, Jens, I'm not a big fan of "dev == NULL" over "!dev". I accept > > both :) > > Personally I'm with you on this, but it says different in http://dpdk.org/doc/guides/contributing/coding_style.html > Anyway, up to you :) Yes, I know that. To make every body happy, I would suggset you to follow the coding style. But if you have already choosen another way, I won't bother to ask you do the change. Unless, it becomes a must in future. --yliu