DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: cs5120282@cse.iitd.ac.in
Cc: dev@dpdk.org, cristian.dumitrescu@intel.com
Subject: Re: [dpdk-dev] Why DPDK is not using compressed TRIE for LPM6?
Date: Mon, 29 May 2017 10:30:09 +0100	[thread overview]
Message-ID: <20170529093008.GB32120@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <bc76760208b5b2c851e23b116d0a1384@cse.iitd.ac.in>

On Sat, May 27, 2017 at 12:34:57AM +0530, Atul Shree wrote:
> Hello All,
> 
> I was doing some experiments related to LPM6 look up and I have added 20K
> entries in the table. By looking at the rte_lpm6_lookup() code I found an
> opportunity to compress the TRIE and there is a significant improvement
> after compression.
> 

Although I'm maintainer for LPM library, I'm not the original author of
the LPM6 code. However, I'll give my thoughts here. Adding Cristian D. on
CC as he was involved in the original implementation, IIRC.

> Here are my questions:
> Q1: Why DPDK is not doing the compression?

It's probably not a deliberate omission, more likely that nobody has
done it.

> Q2. In the worst case the table will behave like an uncompressed TRIE and
> in other cases, there is a scope of improvement. Is it worth doing?
> 

If there is improvement in the normal case, with the worst-case perf
being no worse, it sounds like it may be worth doing. Feel free to
submit patches for evaluation on the list.

Regards,
/Bruce

  reply	other threads:[~2017-05-29  9:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-26 19:04 Atul Shree
2017-05-29  9:30 ` Bruce Richardson [this message]
2017-05-29 11:54   ` Vladimir Medvedkin
2017-05-29 12:42   ` Dumitrescu, Cristian
2017-05-31  6:10     ` Atul Shree
  -- strict thread matches above, loose matches on Subject: below --
2017-05-25  6:32 [dpdk-dev] Why DPDK is not using compressed TRIE for LPM6 ? ankit bhardwaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170529093008.GB32120@bricha3-MOBL3.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=cs5120282@cse.iitd.ac.in \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).