* [dpdk-dev] [PATCH] net/mlx5: fix wrong exception handling
@ 2017-05-30 1:02 Yongseok Koh
2017-05-30 7:48 ` Adrien Mazarguil
0 siblings, 1 reply; 3+ messages in thread
From: Yongseok Koh @ 2017-05-30 1:02 UTC (permalink / raw)
To: ferruh.yigit
Cc: dev, adrien.mazarguil, nelio.laranjeiro, Yongseok Koh, stable
A sanity check is required in priv_fdir_disable(). If resizing Rx queue
fails, this can cause a crash by referencing a NULL pointer.
Cc: stable@dpdk.org
Fixes: 76f5c99e6840 ("mlx5: support flow director")
Fixes: 0cdddf4d0626 ("net/mlx5: split Rx queue structure")
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
drivers/net/mlx5/mlx5_fdir.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_fdir.c b/drivers/net/mlx5/mlx5_fdir.c
index f80c58b4d..1cff41bab 100644
--- a/drivers/net/mlx5/mlx5_fdir.c
+++ b/drivers/net/mlx5/mlx5_fdir.c
@@ -733,9 +733,11 @@ priv_fdir_disable(struct priv *priv)
/* Destroy flow director context in each RX queue. */
for (i = 0; (i != priv->rxqs_n); i++) {
- struct rxq_ctrl *rxq_ctrl =
- container_of((*priv->rxqs)[i], struct rxq_ctrl, rxq);
+ struct rxq_ctrl *rxq_ctrl;
+ if (!(*priv->rxqs)[i])
+ continue;
+ rxq_ctrl = container_of((*priv->rxqs)[i], struct rxq_ctrl, rxq);
if (!rxq_ctrl->fdir_queue)
continue;
priv_fdir_queue_destroy(priv, rxq_ctrl->fdir_queue);
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong exception handling
2017-05-30 1:02 [dpdk-dev] [PATCH] net/mlx5: fix wrong exception handling Yongseok Koh
@ 2017-05-30 7:48 ` Adrien Mazarguil
2017-06-01 10:24 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Adrien Mazarguil @ 2017-05-30 7:48 UTC (permalink / raw)
To: Yongseok Koh; +Cc: ferruh.yigit, dev, nelio.laranjeiro, stable
On Mon, May 29, 2017 at 06:02:59PM -0700, Yongseok Koh wrote:
> A sanity check is required in priv_fdir_disable(). If resizing Rx queue
> fails, this can cause a crash by referencing a NULL pointer.
>
> Cc: stable@dpdk.org
> Fixes: 76f5c99e6840 ("mlx5: support flow director")
> Fixes: 0cdddf4d0626 ("net/mlx5: split Rx queue structure")
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
--
Adrien Mazarguil
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong exception handling
2017-05-30 7:48 ` Adrien Mazarguil
@ 2017-06-01 10:24 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-06-01 10:24 UTC (permalink / raw)
To: Adrien Mazarguil, Yongseok Koh; +Cc: dev, nelio.laranjeiro, stable
On 5/30/2017 8:48 AM, Adrien Mazarguil wrote:
> On Mon, May 29, 2017 at 06:02:59PM -0700, Yongseok Koh wrote:
>> A sanity check is required in priv_fdir_disable(). If resizing Rx queue
>> fails, this can cause a crash by referencing a NULL pointer.
>>
>> Cc: stable@dpdk.org
>> Fixes: 76f5c99e6840 ("mlx5: support flow director")
>> Fixes: 0cdddf4d0626 ("net/mlx5: split Rx queue structure")
>>
>> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-01 10:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-30 1:02 [dpdk-dev] [PATCH] net/mlx5: fix wrong exception handling Yongseok Koh
2017-05-30 7:48 ` Adrien Mazarguil
2017-06-01 10:24 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).