From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id AD3357CA9 for ; Thu, 1 Jun 2017 10:08:10 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id n195so20978781wmg.1 for ; Thu, 01 Jun 2017 01:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=4jg4uMMRO7SI9uvlOg8lIlVN3c+T3I9+CKqoGm4Cuho=; b=D5YsNdkpz3dvJgILbzbNc9IfvCUTWkTNTCXLU0WNBXCF6eE0aoxtdrrvO2XhFAubU2 TETIbEp5Xs3Y1lUHhyEM2x/zF5P06ItJWC2IdKrz42abOjs1dDsghZxRGtpICeJTuCxO g0A7Dg3GRQwONimSvnsCGhQW5BGTMr7KIR+NjilyqsomQqPF1YhXPL1wiPa/af232YRI v7zal4XxfZ7l8bBemeBWpt6ilZk6DJXTDBlg/xJj2PkiF59byfOWYftkOtLseCTPTF5p BnLgLQTGv7fv1a69fKPBiuqBUscOQ635fXgaqlBQ8jZfDdNVRbBA3bJaQXRl6xEhl3p1 W5RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=4jg4uMMRO7SI9uvlOg8lIlVN3c+T3I9+CKqoGm4Cuho=; b=gvXAf9uXr2QQplLwmq4w6was/Dj9TbIScNZ5J2KunRhvK28CtMryF4BSeNBVuRLgCa f8ZM+cvMUsfjnPkZaYzR2Y+4QOQizwTlxu+9O+gskQTP8FafiBvkjvKXqzK8zgxPNCU0 4zXwLO3WkKe+E1A8SMvibEejmHGgLokdXhKzj2xPZ1+rxgQ3ImelcPUBQFnP4hhUTp3G ZHfa0XNGvsJb6QGsWBE7fMPyV6oT74i+cWksEG4ghXKwyjZURTajZKEYXsqv24h3hyt1 lNPhzHkr6+0mkamn2ZAuRDei8coAfLDhYXweOMN1eqs/5i1WM4kUq2AHBs/dCjubfS2i X6+w== X-Gm-Message-State: AODbwcDmyUQQWGODDye8M0ILUwPpL5jidv8r7ZE7ECr4x5oDZS95xOyh zFhflfKNiWwqu9nZ X-Received: by 10.223.170.193 with SMTP id i1mr192618wrc.143.1496304490271; Thu, 01 Jun 2017 01:08:10 -0700 (PDT) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 203sm24684100wmv.18.2017.06.01.01.08.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Jun 2017 01:08:09 -0700 (PDT) Date: Thu, 1 Jun 2017 10:08:03 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Yongseok Koh Cc: ferruh.yigit@intel.com, dev@dpdk.org, adrien.mazarguil@6wind.com, stable@dpdk.org Message-ID: <20170601080803.GN31330@autoinstall.dev.6wind.com> References: <20170531174845.35951-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170531174845.35951-1-yskoh@mellanox.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix redundant free of Tx buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 08:08:11 -0000 On Wed, May 31, 2017 at 10:48:45AM -0700, Yongseok Koh wrote: > SW completion ring of Tx (txq->elts) stores individual mbufs even if a > multi-segmented packet is sent. rte_pktmbuf_free_seg() must be used when > cleaning up the completion ring. Otherwise, chained mbufs are redundantly > freed and finally it would cause a crash. > > CC: stable@dpdk.org > Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") > > Signed-off-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5_txq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c > index 6c1387e56..bf72468d5 100644 > --- a/drivers/net/mlx5/mlx5_txq.c > +++ b/drivers/net/mlx5/mlx5_txq.c > @@ -117,7 +117,7 @@ txq_free_elts(struct txq_ctrl *txq_ctrl) > struct rte_mbuf *elt = (*elts)[elts_tail]; > > assert(elt != NULL); > - rte_pktmbuf_free(elt); > + rte_pktmbuf_free_seg(elt); > #ifndef NDEBUG > /* Poisoning. */ > memset(&(*elts)[elts_tail], > -- > 2.11.0 Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND