DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, thomas@monjalon.net,
	cristian.dumitrescu@intel.com, yuanhan.liu@linux.intel.com,
	maxime.coquelin@redhat.com,
	Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: [dpdk-dev] [PATCH 3/4] examples/qos_sched: suppress GCC 7.1.1 warnings
Date: Fri,  2 Jun 2017 16:50:30 +0530	[thread overview]
Message-ID: <20170602112031.9112-3-jerin.jacob@caviumnetworks.com> (raw)
In-Reply-To: <20170602112031.9112-1-jerin.jacob@caviumnetworks.com>

This one is more of a compiler issue as application
checks the app_parse_opt_vals() return value.

Since this code is in slow path, adding a memset
to fix following "maybe-uninitialized" warning.

qos_sched/args.c: In function ‘app_parse_args’:
examples/qos_sched/args.c:254:32: error: ‘vals[0]’ may be
used uninitialized in this function [-Werror=maybe-uninitialized]
pconf->rx_port = (uint8_t)vals[0];
                            ~~~~^~~
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 examples/qos_sched/args.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c
index 476a0ee1c..2350d64f4 100644
--- a/examples/qos_sched/args.c
+++ b/examples/qos_sched/args.c
@@ -245,6 +245,7 @@ app_parse_flow_conf(const char *conf_str)
 	struct flow_conf *pconf;
 	uint64_t mask;
 
+	memset(vals, 0, sizeof(vals));
 	ret = app_parse_opt_vals(conf_str, ',', 6, vals);
 	if (ret < 4 || ret > 5)
 		return ret;
-- 
2.13.0

  parent reply	other threads:[~2017-06-02 11:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-02 11:20 [dpdk-dev] [PATCH 1/4] examples/l3fwd: add switch fall-through comments Jerin Jacob
2017-06-02 11:20 ` [dpdk-dev] [PATCH 2/4] examples/performance-thread: add " Jerin Jacob
2017-06-02 11:20 ` Jerin Jacob [this message]
2017-06-02 18:18   ` [dpdk-dev] [PATCH 3/4] examples/qos_sched: suppress GCC 7.1.1 warnings Dumitrescu, Cristian
2017-06-02 11:20 ` [dpdk-dev] [PATCH 4/4] examples/vhost: fix uninitialized desc indexes Jerin Jacob
2017-06-03  6:59   ` Maxime Coquelin
2017-06-05 12:57 ` [dpdk-dev] [PATCH 1/4] examples/l3fwd: add switch fall-through comments Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170602112031.9112-3-jerin.jacob@caviumnetworks.com \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=bruce.richardson@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=thomas@monjalon.net \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).