DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com,
	harry.van.haaren@intel.com, hemant.agrawal@nxp.com,
	gage.eads@intel.com, nipun.gupta@nxp.com,
	narender.vangati@intel.com, nikhil.rao@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 0/4] Remove PCI and VDEV dependency from eventdev library
Date: Wed, 7 Jun 2017 11:27:26 +0200	[thread overview]
Message-ID: <20170607092726.GO18840@bidouze.vm.6wind.com> (raw)
In-Reply-To: <20170607084333.6338-1-jerin.jacob@caviumnetworks.com>

Hi Jerin,

On Wed, Jun 07, 2017 at 02:13:29PM +0530, Jerin Jacob wrote:
> v3:
> Removed the bus dependency by spliting lib/librte_eventdev/rte_eventdev_pmd_pci.h
> and lib/librte_eventdev/rte_eventdev_pmd_vdev.h
> 

It works with the PCI bus now, good job.
Small problem however: to compile drivers/event/sw/sw_evdev.c, two includes were
missing:

#include <inttypes.h>
#include <rte_debug.h>

I added both to rte_eventdev_pmd_vdev.h to quickly fix this and test the
compilation otherwise, but maybe this is only necessary for sw_evdev.c.

Thanks

> Jerin Jacob (4):
>   eventdev: remove PCI dependency from generic data structures
>   eventdev: restructure event PMD release function
>   eventdev: make PCI probe and remove functions optional
>   eventdev: make vdev init and uninit functions optional
> 
>  drivers/event/octeontx/ssovf_evdev.h        |   2 +-
>  drivers/event/octeontx/ssovf_worker.h       |   1 +
>  drivers/event/skeleton/skeleton_eventdev.c  |  33 +++---
>  drivers/event/skeleton/skeleton_eventdev.h  |   3 +-
>  drivers/event/sw/sw_evdev.h                 |   2 +-
>  lib/librte_eventdev/Makefile                |   2 +
>  lib/librte_eventdev/rte_eventdev.c          | 148 -------------------------
>  lib/librte_eventdev/rte_eventdev.h          |   2 -
>  lib/librte_eventdev/rte_eventdev_pmd.h      | 101 +-----------------
>  lib/librte_eventdev/rte_eventdev_pmd_pci.h  | 160 ++++++++++++++++++++++++++++
>  lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 133 +++++++++++++++++++++++
>  11 files changed, 323 insertions(+), 264 deletions(-)
>  create mode 100644 lib/librte_eventdev/rte_eventdev_pmd_pci.h
>  create mode 100644 lib/librte_eventdev/rte_eventdev_pmd_vdev.h
> 
> -- 
> 2.13.0
> 

-- 
Gaëtan Rivet
6WIND

  parent reply	other threads:[~2017-06-07  9:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01 16:41 [dpdk-dev] [PATCH] eventdev: remove PCI dependency Jerin Jacob
2017-06-05 12:55 ` Gaëtan Rivet
2017-06-06  3:05   ` Jerin Jacob
2017-06-06  8:09     ` Gaëtan Rivet
2017-06-06  9:01       ` Jerin Jacob
2017-06-06 14:10 ` [dpdk-dev] [PATCH v2] " Jerin Jacob
2017-06-06 14:51   ` Gaëtan Rivet
2017-06-07  8:43   ` [dpdk-dev] [PATCH v2 0/4] Remove PCI and VDEV dependency from eventdev library Jerin Jacob
2017-06-07  8:43     ` [dpdk-dev] [PATCH v2 1/4] eventdev: remove PCI dependency from generic data structures Jerin Jacob
2017-06-09  8:37       ` [dpdk-dev] [PATCH v4 0/4] Remove PCI and VDEV dependency from eventdev library Jerin Jacob
2017-06-09  8:37         ` [dpdk-dev] [PATCH v4 1/4] eventdev: remove PCI dependency from generic data structures Jerin Jacob
2017-06-09  8:37         ` [dpdk-dev] [PATCH v4 2/4] eventdev: restructure event PMD release function Jerin Jacob
2017-06-09  8:37         ` [dpdk-dev] [PATCH v4 3/4] eventdev: make PCI probe and remove functions optional Jerin Jacob
2017-06-09  8:37         ` [dpdk-dev] [PATCH v4 4/4] eventdev: make vdev init and uninit " Jerin Jacob
2017-06-20 14:14         ` [dpdk-dev] [PATCH v4 0/4] Remove PCI and VDEV dependency from eventdev library Jerin Jacob
2017-06-07  8:43     ` [dpdk-dev] [PATCH v2 2/4] eventdev: restructure event PMD release function Jerin Jacob
2017-06-07  8:43     ` [dpdk-dev] [PATCH v2 3/4] eventdev: make PCI probe and remove functions optional Jerin Jacob
2017-06-07  8:43     ` [dpdk-dev] [PATCH v2 4/4] eventdev: make vdev init and uninit " Jerin Jacob
2017-06-07  9:27     ` Gaëtan Rivet [this message]
2017-06-08 17:05       ` [dpdk-dev] [PATCH v2 0/4] Remove PCI and VDEV dependency from eventdev library Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170607092726.GO18840@bidouze.vm.6wind.com \
    --to=gaetan.rivet@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=gage.eads@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=narender.vangati@intel.com \
    --cc=nikhil.rao@intel.com \
    --cc=nipun.gupta@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).