From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id D49F02BA1 for ; Wed, 7 Jun 2017 16:51:33 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jun 2017 07:51:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,311,1493708400"; d="scan'208";a="977907520" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.28]) by orsmga003.jf.intel.com with SMTP; 07 Jun 2017 07:51:30 -0700 Received: by (sSMTP sendmail emulation); Wed, 07 Jun 2017 15:51:30 +0100 Date: Wed, 7 Jun 2017 15:51:29 +0100 From: Bruce Richardson To: Ilya Maximets Cc: dev@dpdk.org Message-ID: <20170607145129.GA51124@bricha3-MOBL3.ger.corp.intel.com> References: <20170607104743.275149-2-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.1 (2017-04-11) Subject: Re: [dpdk-dev] [dpdk-dev,RFC] build for DPDK with meson and ninja X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2017 14:51:34 -0000 On Wed, Jun 07, 2017 at 05:36:41PM +0300, Ilya Maximets wrote: > Hi, Bruce. > > That's interesting approach. I tried this on my system and it works. > I also tried to do some modifications to add conditional support for > libnuma in rte_eal to build with my patches applied. It looks promising. > That is what I've got: > > ------------------------------------------------------------------------- > --- a/lib/librte_eal/linuxapp/eal/meson.build > +++ b/lib/librte_eal/linuxapp/eal/meson.build > @@ -46,8 +46,12 @@ if dpdk_conf.has('LIB_LIBRTE_EAL_XEN_DOM') > sources += ['eal_xen_memory.c'] > endif > > +cc = meson.get_compiler('c') > +libnuma = cc.find_library('numa', required: false) > +dpdk_conf.set10('RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES', libnuma.found()) > + > eal_lib = library('rte_eal', sources, > - dependencies: dependency('threads'), > + dependencies: [dependency('threads'), libnuma], > include_directories : [global_inc, eal_inc, local_inc], > c_args: '-D_GNU_SOURCE', > link_args: '-ldl', > ------------------------------------------------------------------------- > > Result: > Library numa found: YES > and > #define RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES 1 > (NO and 0 respectively with wrong library) > > Build works. I didn't try to install the binaries. > Great. Glad to see it works out that simply for you! > One found issue is that where is no 'meson' package in RHEL 7. I > checked build using meson from git. > > Best regards, Ilya Maximets. > Ok, thanks for reporting. I haven't investigated the distro support for meson yet, other than having it on Fedora and debian, which i use, but you can also get it easily using "pip3" for python3 - on Fedora this is in "python3-pip" package - with the cmd: "pip3 install meson". Regards, /Bruce