From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f173.google.com (mail-wr0-f173.google.com [209.85.128.173]) by dpdk.org (Postfix) with ESMTP id CFC2D2BA3 for ; Wed, 7 Jun 2017 22:03:38 +0200 (CEST) Received: by mail-wr0-f173.google.com with SMTP id v104so10480238wrb.0 for ; Wed, 07 Jun 2017 13:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=xI3BP8YYSwtPxRW3lAGSlub0SCsqzYUCX1A0KW34MfQ=; b=IJkLSai5SvJEDH7ZiuPbmtC56S0JKsEFSfjDMNmrGPbzxJ8uuPFdTtYlq5oVTKjK6P 3sIW2/koBcDfXUadLKDipMxpKh0/ItE2kxss0lUwRJ0N+42m64sXROYxgxz/sPcDXhW3 tXvyobYP7QvyiTtiER18v4JQwo1kKTfJZ/Hsea6+vtOznMej7LPVYHe17OcZ5EhtTyj5 bkdi6/YF+alOkdRYgEAZ5l1Falpt73m3yonvFCFojSOhKhQBm75Y9BcrknqDUmV2DZ1A ZDnsSmiPpHK3ShemdyIOQu+ApvQjTOrxl1AgGbQSvv6fFKYz7uA1SAITrHLsQMEB9p/2 CVbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=xI3BP8YYSwtPxRW3lAGSlub0SCsqzYUCX1A0KW34MfQ=; b=e5ttG/iAZSbU8Z9o1edfRuBkOwV4n2VYug/NwZ4H0bu7fhN/gr8se4NSpLwRICUhXD WFRUjmO/3lIfhWGas8Hy1Ct4v4nBfsHI4mp5IRSbhYV6MTtKQ7KfKUvJBJVYJmru5Q0I omEn1P6kSlFxacOkaKJ5h17ibib1oA1QgE4Qg3gB/bVG30UvAjMCgO/8n9mJSg7GqUy6 prUdEBTXgqep6YbJrMKS1JyfiZuZINEIl8rjEyAOhTgmQVeicS2eeVroo0tgPR+0gsDc seViBBFUe9D4EKt7S1stxiOZxLsg6a0Jt/39MlVUrfplmPhc5Um7RIu3GEnHm44s3KQy RE8Q== X-Gm-Message-State: AODbwcB/M0TOdT+n/ojJmQQzVbijlG1UKcRi/CaV1VUauxVPad8cZpbk O+6OB0gUpvoIoMgn668= X-Received: by 10.223.171.29 with SMTP id q29mr21964711wrc.12.1496865818234; Wed, 07 Jun 2017 13:03:38 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id q77sm3361349wmb.4.2017.06.07.13.03.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Jun 2017 13:03:37 -0700 (PDT) Date: Wed, 7 Jun 2017 22:03:31 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Jan Blunck Cc: dev , Stephen Hemminger , Maxime Coquelin , Jerin Jacob , David Marchand Message-ID: <20170607200331.GU18840@bidouze.vm.6wind.com> References: <1a54f0dd79200960921ca495aa7381817a599bc0.1495629122.git.gaetan.rivet@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 7/9] bus: add helper to find a bus from a device name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2017 20:03:39 -0000 On Wed, Jun 07, 2017 at 07:28:07PM +0200, Jan Blunck wrote: > On Wed, May 24, 2017 at 5:12 PM, Gaetan Rivet wrote: > > Find which bus should be able to parse this device name into an internal > > device representation. > > > > No, please don't add this. One should know to what bus a device > belongs to before plugging it. Artificially encoding the parent bus > into the device name is not the right thing to do. Please keep those > things separate. > The EAL has no way to know this currently. As you noted, it has to know onto which bus a device belongs before plugging it. > > Signed-off-by: Gaetan Rivet > > --- > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > > lib/librte_eal/common/eal_common_bus.c | 15 +++++++++++++++ > > lib/librte_eal/common/include/rte_bus.h | 12 ++++++++++++ > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + > > 4 files changed, 29 insertions(+) > > > > diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > index 3517d74..04fa882 100644 > > --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > @@ -202,5 +202,6 @@ DPDK_17.08 { > > global: > > > > rte_bus_from_name; > > + rte_bus_from_dev; > > > > } DPDK_17.05; > > diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c > > index 7977190..08fff60 100644 > > --- a/lib/librte_eal/common/eal_common_bus.c > > +++ b/lib/librte_eal/common/eal_common_bus.c > > @@ -242,3 +242,18 @@ rte_bus_from_name(const char *str) > > return NULL; > > return rte_bus_find(bus_cmp_name, str); > > } > > + > > +static int > > +bus_can_parse(const struct rte_bus *bus, const void *_name) > > +{ > > + const char *name = _name; > > + > > + return (bus->parse && !bus->parse(name, NULL)); > > +} > > + > > +/* find a bus capable of parsing a device description */ > > +struct rte_bus * > > +rte_bus_from_dev(const char *str) > > +{ > > + return rte_bus_find(bus_can_parse, str); > > +} > > diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h > > index 5b87ac4..0b48e66 100644 > > --- a/lib/librte_eal/common/include/rte_bus.h > > +++ b/lib/librte_eal/common/include/rte_bus.h > > @@ -251,6 +251,18 @@ struct rte_bus *rte_bus_find_by_device(const struct rte_device *dev); > > struct rte_bus *rte_bus_from_name(const char *str); > > > > /** > > + * Find a bus capable of identifying a device. > > + * > > + * @param str > > + * A device identifier (PCI address, virtual PMD name, ...). > > + * > > + * @return > > + * A valid bus structure if found. > > + * NULL if no bus is able to parse this device. > > + */ > > +struct rte_bus *rte_bus_from_dev(const char *str); > > + > > +/** > > * Helper for Bus registration. > > * The constructor has higher priority than PMD constructors. > > */ > > diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > index 6607acc..a5127d6 100644 > > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > @@ -206,5 +206,6 @@ DPDK_17.08 { > > global: > > > > rte_bus_from_name; > > + rte_bus_from_dev; > > > > } DPDK_17.05; > > -- > > 2.1.4 > > -- Gaëtan Rivet 6WIND