From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, harry.van.haaren@intel.com,
hemant.agrawal@nxp.com, gage.eads@intel.com, nipun.gupta@nxp.com,
gaetan.rivet@6wind.com,
Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: [dpdk-dev] [PATCH v4 2/4] eventdev: restructure event PMD release function
Date: Fri, 9 Jun 2017 14:07:27 +0530 [thread overview]
Message-ID: <20170609083729.10586-3-jerin.jacob@caviumnetworks.com> (raw)
In-Reply-To: <20170609083729.10586-1-jerin.jacob@caviumnetworks.com>
Remove rte_event_dev_close() from rte_event_pmd_release() function so
that rte_event_pmd_release() can be used in stateless way. This will
enable rte_event_pmd_vdev_uninit() function to avoid using
eventdev_globals global variable and the need for exposing the a
global variable to PMD.
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
lib/librte_eventdev/rte_eventdev.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/lib/librte_eventdev/rte_eventdev.c b/lib/librte_eventdev/rte_eventdev.c
index fd0406747..74a2614c4 100644
--- a/lib/librte_eventdev/rte_eventdev.c
+++ b/lib/librte_eventdev/rte_eventdev.c
@@ -1171,10 +1171,6 @@ rte_event_pmd_release(struct rte_eventdev *eventdev)
if (eventdev == NULL)
return -EINVAL;
- ret = rte_event_dev_close(eventdev->data->dev_id);
- if (ret < 0)
- return ret;
-
eventdev->attached = RTE_EVENTDEV_DETACHED;
eventdev_globals.nb_devs--;
@@ -1230,6 +1226,7 @@ rte_event_pmd_vdev_init(const char *name, size_t dev_private_size,
int
rte_event_pmd_vdev_uninit(const char *name)
{
+ int ret;
struct rte_eventdev *eventdev;
if (name == NULL)
@@ -1239,6 +1236,10 @@ rte_event_pmd_vdev_uninit(const char *name)
if (eventdev == NULL)
return -ENODEV;
+ ret = rte_event_dev_close(eventdev->data->dev_id);
+ if (ret < 0)
+ return ret;
+
/* Free the event device */
rte_event_pmd_release(eventdev);
@@ -1293,11 +1294,7 @@ rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv,
(unsigned int) pci_dev->id.vendor_id,
(unsigned int) pci_dev->id.device_id);
- if (rte_eal_process_type() == RTE_PROC_PRIMARY)
- rte_free(eventdev->data->dev_private);
-
- eventdev->attached = RTE_EVENTDEV_DETACHED;
- eventdev_globals.nb_devs--;
+ rte_event_pmd_release(eventdev);
return -ENXIO;
}
@@ -1320,6 +1317,10 @@ rte_event_pmd_pci_remove(struct rte_pci_device *pci_dev,
if (eventdev == NULL)
return -ENODEV;
+ ret = rte_event_dev_close(eventdev->data->dev_id);
+ if (ret < 0)
+ return ret;
+
/* Invoke PMD device un-init function */
if (devuninit)
ret = devuninit(eventdev);
--
2.13.1
next prev parent reply other threads:[~2017-06-09 8:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 16:41 [dpdk-dev] [PATCH] eventdev: remove PCI dependency Jerin Jacob
2017-06-05 12:55 ` Gaëtan Rivet
2017-06-06 3:05 ` Jerin Jacob
2017-06-06 8:09 ` Gaëtan Rivet
2017-06-06 9:01 ` Jerin Jacob
2017-06-06 14:10 ` [dpdk-dev] [PATCH v2] " Jerin Jacob
2017-06-06 14:51 ` Gaëtan Rivet
2017-06-07 8:43 ` [dpdk-dev] [PATCH v2 0/4] Remove PCI and VDEV dependency from eventdev library Jerin Jacob
2017-06-07 8:43 ` [dpdk-dev] [PATCH v2 1/4] eventdev: remove PCI dependency from generic data structures Jerin Jacob
2017-06-09 8:37 ` [dpdk-dev] [PATCH v4 0/4] Remove PCI and VDEV dependency from eventdev library Jerin Jacob
2017-06-09 8:37 ` [dpdk-dev] [PATCH v4 1/4] eventdev: remove PCI dependency from generic data structures Jerin Jacob
2017-06-09 8:37 ` Jerin Jacob [this message]
2017-06-09 8:37 ` [dpdk-dev] [PATCH v4 3/4] eventdev: make PCI probe and remove functions optional Jerin Jacob
2017-06-09 8:37 ` [dpdk-dev] [PATCH v4 4/4] eventdev: make vdev init and uninit " Jerin Jacob
2017-06-20 14:14 ` [dpdk-dev] [PATCH v4 0/4] Remove PCI and VDEV dependency from eventdev library Jerin Jacob
2017-06-07 8:43 ` [dpdk-dev] [PATCH v2 2/4] eventdev: restructure event PMD release function Jerin Jacob
2017-06-07 8:43 ` [dpdk-dev] [PATCH v2 3/4] eventdev: make PCI probe and remove functions optional Jerin Jacob
2017-06-07 8:43 ` [dpdk-dev] [PATCH v2 4/4] eventdev: make vdev init and uninit " Jerin Jacob
2017-06-07 9:27 ` [dpdk-dev] [PATCH v2 0/4] Remove PCI and VDEV dependency from eventdev library Gaëtan Rivet
2017-06-08 17:05 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609083729.10586-3-jerin.jacob@caviumnetworks.com \
--to=jerin.jacob@caviumnetworks.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=gage.eads@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=nipun.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).