From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id 6D240DE3 for ; Mon, 12 Jun 2017 16:27:44 +0200 (CEST) Received: by mail-wr0-f169.google.com with SMTP id q97so99570035wrb.2 for ; Mon, 12 Jun 2017 07:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rSV81VpF0FSQ4m2awsiG63MPG/kcCNCr0GDftl03dEI=; b=Qen+Mkfy2cqUqAHSh20ec3dQhayRH5S6lCxOyUfAzvQHD8uimev9kSeMz8LnGdP+Jb M1YhT4M9+zykAdXGQo6vRJTSn+xRFes28dpI3yQZqczENJYs8i1aNkq0jWS+cbCwqc+H KX7b2tNm8pVSqNWqbIeRPfX9gGRL/PJntcO0N3F/CgaR+ga5PpZ/CwQMgpj1CO8dwG3O 5glKsDoWbvxFpZfnvjymvmHAHgBvAmJm/BdTkrKDdW6wnkA92Q8y+6KVaIkk7j75R8Lt qtXc03lWOYlUIM8PXsxdeBdSNrkB0BrHL9UYsj6TWMIuUYauBsb3n3wgyIg2lUJgbcaT zO3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rSV81VpF0FSQ4m2awsiG63MPG/kcCNCr0GDftl03dEI=; b=Idr3S8CrtDmM2kr5Cce4T02m8LkK5YYsW13KqrVKH9Xz3caMlIqaC7so8zgs0AarKI 7NTCP5+REvSBA7fgqi4M5HvkBTsXrwLR07b/csL+MNtTB4amvXT2HbHU8C99Tj4Y4+u+ MPGPhibLwpOU2uN108tIt5t2PrmuTS7y9Tg9YZsKbGsLxXo1E6t6WsqaP956hoOWpU3y ZLKCkDdTGfEF3FU7eOTQog4zcf2GqrXyp5uJeq4YPu4vpO7AlhpB/jp+qQdwIluHOo2B waLbFS+1JwP6gkTdW37LxBDVq9q5Btcu9uHQGGIlI2Y5hBklfhoX4frbzNAeb4fshT7k RHVw== X-Gm-Message-State: AKS2vOxgaIvsoSeS9Qu3l5/6Hjk8TSDItDt1mZBvYyStIyIWfuOEn3ep TgI7n1euzkPtn/Gcnh8= X-Received: by 10.223.160.248 with SMTP id n53mr8340112wrn.108.1497277664096; Mon, 12 Jun 2017 07:27:44 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id p87sm8023244wma.2.2017.06.12.07.27.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Jun 2017 07:27:43 -0700 (PDT) Date: Mon, 12 Jun 2017 16:27:35 +0200 From: Adrien Mazarguil To: Shahaf Shuler Cc: john.mcnamara@intel.com, nelio.laranjeiro@6wind.com, dev@dpdk.org Message-ID: <20170612142735.GD1758@6wind.com> References: <20170606142016.140162-1-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170606142016.140162-1-shahafs@mellanox.com> Subject: Re: [dpdk-dev] [PATCH] doc: add VLAN flow limitation on mlx5 PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jun 2017 14:27:44 -0000 Hi Shahaf, On Tue, Jun 06, 2017 at 05:20:16PM +0300, Shahaf Shuler wrote: > On mlx5 PMD Flow pattern without any specific vlan will match for vlan > packets as well. > > Signed-off-by: Shahaf Shuler > Acked-by: Nelio Laranjeiro nelio.laranjeiro@6wind.com > --- > doc/guides/rel_notes/release_17_08.rst | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/rel_notes/release_17_08.rst > index 7f1212094..bd219640c 100644 > --- a/doc/guides/rel_notes/release_17_08.rst > +++ b/doc/guides/rel_notes/release_17_08.rst > @@ -111,6 +111,22 @@ Known Issues > Also, make sure to start the actual text at the margin. > ========================================================= > > +* **On mlx5 PMD, Flow pattern without any specific vlan will match for vlan packets as well.** > + > + When VLAN spec is not specified in the pattern, the matching rule will be created with VLAN as a wild card. > + Meaning, the flow rule:: > + > + flow create 0 ingress pattern eth / vlan vid is 3 / ipv4 / end ... > + > + Will only match vlan packets with vid=3. and the flow rules:: > + > + flow create 0 ingress pattern eth / ipv4 / end ... > + > + Or:: > + > + flow create 0 ingress pattern eth / vlan / ipv4 / end ... > + > + Will match any ipv4 packet (VLAN included). > > API Changes > ----------- I do not think this should be part of the release notes as it is not a new behavior introduced by a commit for 17.08. It has been the case since VLAN support was added to the mlx5 rte_flow implementation back in 17.02. Please move this info to guide/nics/mlx5.rst, the resulting documentation commit should likely be CC'ed to stable@dpdk.org against "net/mlx5: support VLAN flow item". -- Adrien Mazarguil 6WIND