From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id EC9332C72 for ; Tue, 20 Jun 2017 09:13:41 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id u195so11228831wmd.1 for ; Tue, 20 Jun 2017 00:13:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=ZBJAJgbQy1X6L7vCtvIcObhPHDf89oNwJpJLOb96+PY=; b=FcKyRKkfnvrwJgbu0Qt8IKNi1bvkgdIKP45+V+haoPdyWyG55G4AGAWrSSP9TSII+F Li7LeFmTTf2ub737+n6jhckaQl4fSbkAZ6bcWpLf3hfMU6obFGhZ0RR/EtBHtIlYlS82 +t/IGXW/fNa+Fw/f3aJAv3m3ht4geHBYfKHcboE8nCBoL5wNX9BcAFQvMR45uDxZdJeS rkF5AUmGyVxJfXqSwobGgVoo/WUg4dx2uErS50DuSV+1vzIfxcdoBAInXD0Ed8676+Gr lljIhjAYepnFvQD9kB9yQuqg/nPrPqJliFKEcz9rIIKhUImO6CaG3dWFDnTqjqOsAyxP ZnnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=ZBJAJgbQy1X6L7vCtvIcObhPHDf89oNwJpJLOb96+PY=; b=CaMhKeL5inyvghLSb/eJmRuTFnaYBmJXj2qJwUYxtUGDbLwd3823JpL3widFRhd7qG PqcweIHkda+66ECKr2PFLZAfGB6RaVrJLUxPxcUmon7h5MlvsUVdKPiYO7g2ECSzMUxF vb22Jkh+YyCj04MgPh3ML9kJ3DS3VmA/mk/FWGU0XDGQz/5kN9E6IBUFYliDL5epOSO3 2zt/h7MrwUoo4a11VwGGn1xyt4kT2RgpAyNjZiCsw+5EQTV5sfayxjRacHA7QDrIWmTu dt/xUaorRnLpmJj4hqoTC+Kg+J5OPQXPkb3LY+hpqhfcXB2jZ0XbtlQgXMFuIWKIHAga Gcow== X-Gm-Message-State: AKS2vOwjNFv5ygIIxlB6k+xHMqyJggGd0d1tJ83kFviVnM6oc1uzUfCO btIj86S4u3xIQidg X-Received: by 10.28.50.194 with SMTP id y185mr1538888wmy.32.1497942821577; Tue, 20 Jun 2017 00:13:41 -0700 (PDT) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id h123sm9887916wmd.34.2017.06.20.00.13.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Jun 2017 00:13:41 -0700 (PDT) Date: Tue, 20 Jun 2017 09:13:33 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20170620071333.GT4949@autoinstall.dev.6wind.com> References: <20170620052447.31846-1-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170620052447.31846-1-shahafs@mellanox.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix TSO segment size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 07:13:42 -0000 On Tue, Jun 20, 2017 at 08:24:47AM +0300, Shahaf Shuler wrote: > In case on multi segment packet, the TSO segment size > was taken from the last segment. This may lead to incorrect > values in case not all segments are initialized with the field. > > Fixing it by taking the value from the first segment. > > Fixes: 3f13f8c23a7c ("net/mlx5: support hardware TSO") > Cc: stable@dpdk.org > > Signed-off-by: Shahaf Shuler > Acked-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5_rxtx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index cade625f9..70314b393 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -527,6 +527,7 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) > uint16_t ehdr; > uint8_t cs_flags = 0; > uint64_t tso = 0; > + uint16_t tso_segsz = 0; > #ifdef MLX5_PMD_SOFT_COUNTERS > uint32_t total_length = 0; > #endif > @@ -622,6 +623,7 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) > > tso_header_sz = buf->l2_len + vlan_sz + > buf->l3_len + buf->l4_len; > + tso_segsz = buf->tso_segsz; > > if (is_tunneled && txq->tunnel_en) { > tso_header_sz += buf->outer_l2_len + > @@ -821,7 +823,7 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) > }; > wqe->eseg = (rte_v128u32_t){ > 0, > - cs_flags | (htons(buf->tso_segsz) << 16), > + cs_flags | (htons(tso_segsz) << 16), > 0, > (ehdr << 16) | htons(tso_header_sz), > }; > -- > 2.12.0 Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND