From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f181.google.com (mail-pf0-f181.google.com
 [209.85.192.181]) by dpdk.org (Postfix) with ESMTP id 1F08F2BC3
 for <dev@dpdk.org>; Wed, 21 Jun 2017 17:23:30 +0200 (CEST)
Received: by mail-pf0-f181.google.com with SMTP id s66so86285955pfs.1
 for <dev@dpdk.org>; Wed, 21 Jun 2017 08:23:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=sUbD9N6sDnycgSUA+1PDQGUWtJt8AgrOE6d1JIS4whY=;
 b=fEe1i7lmxBTOq+J0uFh03CFxO1oP3YNiSs7w7svBP0zbJen4HKugXZiwFw+RIuC8dl
 GUGTFnlaE/zTlXDNpzdXg/EhTlqYlj84MCzJz47X7wMxgmX7f/Vy2NXQy88VBJB6VG+l
 3wkqXz33c9JByW5ijY99XVMPtzsH4pHB4QeojyOwy/Gw4lJWnS9Lw1+D6h+fIrdU7tdf
 KogQ/tlxfB1W0pxR+Sm2NRa8gowDW+BNcLBksJTYlIAwLTCLz7bo1wAjQozs5qj+/UtJ
 88adhIoQ8fSt3eSlEVhCbaX/tyZ4sQQL8Z7RadYONHU8VR5QVMzIvmg4zZNOtsFvH+0c
 SfNQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=sUbD9N6sDnycgSUA+1PDQGUWtJt8AgrOE6d1JIS4whY=;
 b=M9BtI2ZCwZ7GCfXnyOB+fw58KgGZ+s4r0Kk+Oy+2SyUnFv3y74xT54X/WrmL52sDLg
 s28s2tqJDf6slJg2Evt/Cy4JCzwCoWQpbNolN3mmIUDgXtkTbPiiIQAlz5eO/CzRPWTe
 fXlNbpqsGQ46v57Ggr7uGXxdfFbhmGyeuOijOTe6T7KanLcSZtoVTQ9828CRzlSdTpAP
 Qpx/pdZDrPrSeqYRdJea48+dVpnDJAGCDpGgEk0p/Db98vV7PaWGHevXo+M7tMK2pCa9
 vpJNYoUQQkIHXQ9+hcMEmreSzw3O3z7Xxp3J2jMwG8DSyIcv4uVfjWFiKTDY0Uldc5SP
 ilHA==
X-Gm-Message-State: AKS2vOxXqlA2QML67/SjC5O2FPvt2ujPsWEnZ4hnaksR1SUgMti9ejdg
 dItWM7dG8jLEQ4Fh8h53IA==
X-Received: by 10.99.119.12 with SMTP id s12mr17189151pgc.143.1498058610208;
 Wed, 21 Jun 2017 08:23:30 -0700 (PDT)
Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])
 by smtp.gmail.com with ESMTPSA id k9sm39354353pga.40.2017.06.21.08.23.29
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 21 Jun 2017 08:23:30 -0700 (PDT)
Date: Wed, 21 Jun 2017 08:23:23 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com, Bruce Richardson
 <bruce.richardson@intel.com>
Message-ID: <20170621082323.3c39a2d0@xeon-e3>
In-Reply-To: <20170621110651.75299-3-ferruh.yigit@intel.com>
References: <20170526165228.96919-1-ferruh.yigit@intel.com>
 <20170621110651.75299-1-ferruh.yigit@intel.com>
 <20170621110651.75299-3-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v8 2/4] unci: add kernel control path kernel
 module
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Jun 2017 15:23:31 -0000

On Wed, 21 Jun 2017 12:06:49 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> +static struct ethtool_input_buffer {
> +	int magic;
> +	void *buffer;
> +	size_t length;
> +	struct completion *msg_received;
> +	int *err;
> +	u32 in_use;
> +} ethtool_input_buffer

Naming in kernel is important. This isn't kernel ethtool, so  it shouldn't be named that.

Having a single instance per system for a control interface means it won't work
if multiple apps have control channel open or in containers.

You should also do policy validation on the netlink message.