From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id CD6B14CC5 for ; Wed, 21 Jun 2017 11:34:10 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2017 02:34:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,368,1493708400"; d="scan'208";a="1185184860" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.28]) by fmsmga002.fm.intel.com with SMTP; 21 Jun 2017 02:34:06 -0700 Received: by (sSMTP sendmail emulation); Wed, 21 Jun 2017 10:34:05 +0100 Date: Wed, 21 Jun 2017 10:34:05 +0100 From: Bruce Richardson To: Ilya Maximets Cc: Thomas Monjalon , dev@dpdk.org, David Marchand , Sergio Gonzalez Monroy , Heetae Ahn , Yuanhan Liu , Jianfeng Tan , Neil Horman , Yulong Pei , Jerin Jacob Message-ID: <20170621093405.GA19848@bricha3-MOBL3.ger.corp.intel.com> References: <1496756020-4579-1-git-send-email-i.maximets@samsung.com> <1498032250-24924-2-git-send-email-i.maximets@samsung.com> <3630286.1QuNDLyk9u@xps> <20170621085844.GA93740@bricha3-MOBL3.ger.corp.intel.com> <36e228bb-1f27-4464-7597-4000fcb1d9f7@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <36e228bb-1f27-4464-7597-4000fcb1d9f7@samsung.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.1 (2017-04-11) Subject: Re: [dpdk-dev] [PATCH v6 1/2] mem: balanced allocation of hugepages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 09:34:11 -0000 On Wed, Jun 21, 2017 at 12:25:51PM +0300, Ilya Maximets wrote: > On 21.06.2017 11:58, Bruce Richardson wrote: > > On Wed, Jun 21, 2017 at 10:51:58AM +0200, Thomas Monjalon wrote: > >> 21/06/2017 10:04, Ilya Maximets: > >>> +CONFIG_RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES=n > >> > >> We can stop inserting LIBRTE in our config options. > >> CONFIG_RTE_EAL_ is long enough :) > >> > > Consistency. While I agree it's unneeded should have it in all or none, > > and unless we change a bunch of existing ones, I think it means we have > > it in all. > > Hmm. There are few options named CONFIG_RTE_EAL_* and CONFIG_RTE_LIBRTE_EAL_*. > Also there is one strange CONFIG_RTE_LIBEAL_(USE_HPET). > > Maybe we can prepare the patch to unify all that options later? > Or should I rename CONFIG_RTE_LIBRTE_EAL_NUMA_AWARE_HUGEPAGES to > CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES in this series? Sure, if it's already insonsistent for EAL, then use the shorter name. We can fix up the others later. These options may move or disappear if we look to move to a different build system e.g. [1], so that may be a good opportunity to adjust some names. /Bruce [1] http://dpdk.org/dev/patchwork/patch/25104/