From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 6CCE85699 for ; Wed, 21 Jun 2017 12:27:06 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP; 21 Jun 2017 03:27:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,368,1493708400"; d="scan'208";a="1143390881" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.28]) by orsmga001.jf.intel.com with SMTP; 21 Jun 2017 03:27:03 -0700 Received: by (sSMTP sendmail emulation); Wed, 21 Jun 2017 11:27:02 +0100 Date: Wed, 21 Jun 2017 11:27:02 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: gaetan.rivet@6wind.com, dev@dpdk.org Message-ID: <20170621102702.GA93468@bricha3-MOBL3.ger.corp.intel.com> References: <20170620212139.9508-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170620212139.9508-1-thomas@monjalon.net> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.1 (2017-04-11) Subject: Re: [dpdk-dev] [RFC PATCH] mk: symlink every headers first X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 10:27:06 -0000 On Tue, Jun 20, 2017 at 11:21:39PM +0200, Thomas Monjalon wrote: > If a library or a build tool uses a definition from a driver, > there is a build ordering issue, like seen when moving PCI code > into a bus driver. > > One option is to keep PCI helpers and some common definitions in EAL. > The other option is to symlink every headers at the beginning of > the build so they can be included by any other component. > > This patch shows how to achieve the second option. > > Signed-off-by: Thomas Monjalon > --- My 2c. This may be worth doing, however, two points to consider. 1. If we look to change build system this may not be worth doing unless a compelling need becomes obvious in the short term. In the meantime, for cases where it is needed... 2. libraries can already access the includes from drivers or other places fairly easily, just by adding the relevant "-I" flag to the CFLAGS for that lib. That said, since the work is already done developing this, and if it doesn't hurt in terms of build time, I suppose we might as well merge it in. So tentative ack from me, subject to testing and feedback from others. /Bruce