From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 720719E3 for ; Mon, 26 Jun 2017 15:41:34 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id 62so1668598wmw.1 for ; Mon, 26 Jun 2017 06:41:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=PZaWgLqQsC2Iv6syy/1h32orjXBybXKLdhfgtZjnJCg=; b=zb3MIcYLgUyWuXsEFjokxMb6/d/gAYQJV07gZZ5s8e6zE2i+gROeKN4NfS8Z1Oqcr5 KnqHGo1710pgTi+Re47EJFTxzhf+BCwxuxh6iMBDG7N8bI30oxBwb5hwR9YQPLXfR870 G3demxZ7+nBksZBcKXafJyV8o0cVCetSduxsEgwCr2ywHe0tl18fQ3dJVxWRLzCMHiMI lNfyVwFHsuwsVulvC0P4/ftYo38udnr5ysliDbDd/6gaouWb7ynzu2ttumGm+jB0N6oG +Ssco89EwmDrDh0edI8lSIaiXzErpXmVaPk9XwwAmhASgwXa+lArH0s2T2ycqovWkgXg g8Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=PZaWgLqQsC2Iv6syy/1h32orjXBybXKLdhfgtZjnJCg=; b=BAgQZwFGeYqyRodAzm/XfsqRd9xVzpY9t+pYUiamMz5wX0A3L/+u45M9wojQGEpX2T 12Pl0aQTVoI0hD4mLtaOWMqhFwtLgXQjFcAldXLMVefleO7dLlfB686roW3DS4PuUDZb JzUYLSl1P2+aZndd/8PRiKLtPIzW5xFSu0RS82UKRmWOZIzQKCCuFyqIDgHwPHa1afTN lXjp1zF2BTMIA6aeuBogyvZigAKA6ydHrswU4HMj8VITbWrNQWYzLDMRG0ZavbZFk9Q4 HsY5du/Wjf/g5rJVCef3JRUAprj8XJC7uozVUkzCAdY6D/ZOCHYAjb/1B7sQOceFjXDN zcCg== X-Gm-Message-State: AKS2vOysLqWN4l4dTRiYApPfyLOTioB1mFA+hR/qits+J7LYA/FJH3C/ F+zjAkJU8gbud/S4 X-Received: by 10.28.138.21 with SMTP id m21mr99275wmd.99.1498484493949; Mon, 26 Jun 2017 06:41:33 -0700 (PDT) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id w96sm10810741wrc.33.2017.06.26.06.41.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Jun 2017 06:41:33 -0700 (PDT) Date: Mon, 26 Jun 2017 15:41:26 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Ferruh Yigit Cc: Shachar Beiser , dev@dpdk.org, Adrien Mazarguil Message-ID: <20170626134126.GF3093@autoinstall.dev.6wind.com> References: <4233196997a3d8aba05b16a130ccc87f27f076bf.1498046009.git.shacharbe@mellanox.com> <09f627ea8059ff7fd490ea1120e5c68137fa4944.1498376886.git.shacharbe@mellanox.com> <20170626122846.GB3093@autoinstall.dev.6wind.com> <7e3cc639-bcc5-b02b-0e89-8ddc98f82fcb@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7e3cc639-bcc5-b02b-0e89-8ddc98f82fcb@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix drop action seg fault X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jun 2017 13:41:34 -0000 On Mon, Jun 26, 2017 at 01:55:33PM +0100, Ferruh Yigit wrote: > On 6/26/2017 1:28 PM, Nélio Laranjeiro wrote: > > On Sun, Jun 25, 2017 at 07:55:01AM +0000, Shachar Beiser wrote: > >> Missing room in flow allocation to store the drop specification. > >> Changing flow without storing the change in rte_flow. > >> Fixes: 88c77dedfbb0 ("net/mlx5: implement drop action in hardware classifier") > >> > >> Signed-off-by: Shachar Beiser > > > Acked-by: Nelio Laranjeiro > > Hi Nelio, Shachar, > > What do you think squashing this and [1] into 88c77dedfbb0? Both this > and [1] looks like fixing same commit. > > [1] > e0e37c1f80a0 ("net/mlx5: fix creation of drop flows") Hi Ferruh, No it is not the same issue, one this new patch is fixing some code for the hardware drop flow support which will be available with next version of MLNX_OFED. e0e37c1f80a0 ("net/mlx5: fix creation of drop flows") is fixing the current version of the software drop queue which is possible with the current MLNX_OFED GA. Please keep them separate. Thanks, -- Nélio Laranjeiro 6WIND