From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C51CD3DC for ; Mon, 26 Jun 2017 18:31:52 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2017 09:31:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,396,1493708400"; d="scan'208";a="278776003" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.28]) by fmsmga004.fm.intel.com with SMTP; 26 Jun 2017 09:31:46 -0700 Received: by (sSMTP sendmail emulation); Mon, 26 Jun 2017 17:31:45 +0100 Date: Mon, 26 Jun 2017 17:31:45 +0100 From: Bruce Richardson To: Gaetan Rivet Cc: dev@dpdk.org, Jan Blunck Message-ID: <20170626163145.GC101992@bricha3-MOBL3.ger.corp.intel.com> References: <7250ec82b1b0a8ce1852327dc35d7155c08c7570.1498436062.git.gaetan.rivet@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7250ec82b1b0a8ce1852327dc35d7155c08c7570.1498436062.git.gaetan.rivet@6wind.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.1 (2017-04-11) Subject: Re: [dpdk-dev] [PATCH v5 03/12] bus: add helper to find which bus holds a device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jun 2017 16:31:53 -0000 On Mon, Jun 26, 2017 at 02:22:01AM +0200, Gaetan Rivet wrote: > From: Jan Blunck > > Signed-off-by: Jan Blunck > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > lib/librte_eal/common/eal_common_bus.c | 25 +++++++++++++++++++++++++ > lib/librte_eal/common/include/rte_bus.h | 5 +++++ > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + > 4 files changed, 32 insertions(+) > Acked-by: Bruce Richardson Would it be useful to add a unit test for this function? That would help with any future refactoring, and also indirectly test the other functions added in the previous 2 patches.