From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 87EA5235 for ; Tue, 27 Jun 2017 00:16:26 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id i127so10110278wma.0 for ; Mon, 26 Jun 2017 15:16:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=iOmJ88HlX+iX/i9zswxyoei3PszVe7Ym+pGsOs3XqnU=; b=yAf7NzZAAwZi12dNps2FXxKz5SCUlon2yYMrKTnBd91sxs74QzyR2CUkONM1XHhRpg 718MGNqrcwW/fxpmoOOgk3qjaG9vwPTnMkU+2H2kwxLWmcx3WOccVKQTHMKkFoefUJuF QX3yY+psHDmUA+7y0wi11uzQAVa8BTOXpTN/uLI+fhvcRfn92lYl3LHvzpq42tjQXxp9 eDylBU5eSLHg0yM6sF+zwGUWEIVXLJDxlZjeu4uRVndVkUZ4w2RXqXBV3k1mKeptUvSm ENT8H9nAyly7y7d9+Q9adC4hgo7aoQhztSk6XGqdGWotnrpZxB3z8ladqWLNW8s/U8VR t4tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=iOmJ88HlX+iX/i9zswxyoei3PszVe7Ym+pGsOs3XqnU=; b=H9hsN90l51Bp77j2yeow4VSkNJYO4ds5ssFMQmTRhcyira0RAoK9lthuj1b4VwEjyh 9jTXgqm3lqPGqvsBfQER36wf28WdOpTav9SYoCXZZak+5UoXqAweRXpAtIeQXucfdgGm ObOM2T8UZEVOZGpbA9kf4oDwSB3gUExGv2aYOE6qvR5zqL36s0wGn5rKibvU0wEpJT5u cPyUzo4/eWvig2sybazrRrHNVqmJKedPrqhwC5CTseQQB550Lb9QOq3ER4UGFpsCO7Rw oH7wWAC8g2vI12NdjNyttJqaaVK/iTuz6/IWeu7K7IjmFTI1IXNJ0XaG1Y9g58N+z+uH 1fxw== X-Gm-Message-State: AKS2vOw97kto2uk3MAobUj/badRTZvhk6zgjGRd6wUtZ+OYb0y3sYEBw 4byAOEMyNb/6YglU X-Received: by 10.28.9.142 with SMTP id 136mr1027874wmj.91.1498515385852; Mon, 26 Jun 2017 15:16:25 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id e31sm22278567wre.54.2017.06.26.15.16.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Jun 2017 15:16:24 -0700 (PDT) Date: Tue, 27 Jun 2017 00:16:16 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Bruce Richardson Cc: dev@dpdk.org, Jan Blunck Message-ID: <20170626221616.GP2344@bidouze.vm.6wind.com> References: <7250ec82b1b0a8ce1852327dc35d7155c08c7570.1498436062.git.gaetan.rivet@6wind.com> <20170626163145.GC101992@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170626163145.GC101992@bricha3-MOBL3.ger.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v5 03/12] bus: add helper to find which bus holds a device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jun 2017 22:16:26 -0000 On Mon, Jun 26, 2017 at 05:31:45PM +0100, Bruce Richardson wrote: > On Mon, Jun 26, 2017 at 02:22:01AM +0200, Gaetan Rivet wrote: > > From: Jan Blunck > > > > Signed-off-by: Jan Blunck > > Signed-off-by: Gaetan Rivet > > --- > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > > lib/librte_eal/common/eal_common_bus.c | 25 +++++++++++++++++++++++++ > > lib/librte_eal/common/include/rte_bus.h | 5 +++++ > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + > > 4 files changed, 32 insertions(+) > > > > Acked-by: Bruce Richardson > > Would it be useful to add a unit test for this function? That would help > with any future refactoring, and also indirectly test the other > functions added in the previous 2 patches. Yes, I think it would be better to have unit-tests for those functions. They can be a little tricky to get right, working with the layers of callbacks. I may be short on time for the next version though. I'll see. -- Gaëtan Rivet 6WIND