From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 1117B2C08 for ; Tue, 27 Jun 2017 16:48:30 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id b184so29209772wme.1 for ; Tue, 27 Jun 2017 07:48:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=zA1ZAivVpLEkNi6XvhlGvi+rQf3oiCk4CGNpa13Z/Bk=; b=O95F7qBIKhpo4a7HWViPhBkov9PvP7dTwH1Zk8jpyoe9UltLAt0NMQ0fsIARnRRahA J2n0fbJmxfJhBvE8XV23iuK0+gm/0teEnFNDrSmZpfq5QjG+UpYoz2sQP4S1Socn7Mro ND/5qJG7vkBIH/Vg6ykFUYdBLlvy2BGjEQYEgigG7lySPBcFryEEWqyA+iuI5dDh7+/K brKLdI+AscvDWkxCZpH/9ZVQPJLIjfPP/K92JlB/TfUWSOEP1ZdZ6oeiyBUEQZhAsVJj vkbHfR0BxNBUehd8+B9YTg19vDvrsT4gwuN+Q9aYf2P2uKZ6p4pk3dSm6q/i0R1eclvj VFhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=zA1ZAivVpLEkNi6XvhlGvi+rQf3oiCk4CGNpa13Z/Bk=; b=GIVV1eRrUbw6QaEOfytgHzGpbZ/3y44G/LLMx93NIwmDzr/NBOG9uBo0tWiTnKcJTX pe0vhgoMSDdnRM/pFML3M0o2sM3cU5XB4nXKbeduh9nSs8JPtDvv8bKjpoVe/gnUv2tt PFUHoyQNe62liN+tia65CJ9Wg6Kanxyoe+ngEG2YtBLSGUSODK/hG1rPXPTdCO22Y0Tp 9Bz/0nk/CcVZQ7165yAaNKbnOLIDjAmDXp1fTlIbH0jPNXP2mmmj25LcPgjoK95Xjq0e goFv4e9+G4OwiIW7CEiQ3A5OLBh7H3QUIi75AkeHGyFAyJfRDfkqtI8+LD4IgzV8SPjN bO5w== X-Gm-Message-State: AKS2vOxmAL/7A+irAgW84xrqCmceeLEIFN5Q8u1/whzLZ++2JtYBHpWv i6gTiZhHuhRyguuw X-Received: by 10.28.35.201 with SMTP id j192mr3625217wmj.26.1498574910535; Tue, 27 Jun 2017 07:48:30 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id m73sm3439105wmi.25.2017.06.27.07.48.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Jun 2017 07:48:29 -0700 (PDT) Date: Tue, 27 Jun 2017 16:48:22 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Bruce Richardson Cc: dev@dpdk.org, Jan Blunck , Shreyansh Jain , Stephen Hemminger Message-ID: <20170627144821.GD13355@bidouze.vm.6wind.com> References: <20170627140816.GK104744@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170627140816.GK104744@bricha3-MOBL3.ger.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v5 00/12] bus: attach / detach API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2017 14:48:31 -0000 On Tue, Jun 27, 2017 at 03:08:17PM +0100, Bruce Richardson wrote: > On Mon, Jun 26, 2017 at 02:21:58AM +0200, Gaetan Rivet wrote: > > Following the work from Jan: > > > > This patchset introduces the attach / detach API to rte_bus. > > The rte_device structure is used as the generic device representation. > > > > This API is implemented for the virtual bus. > > The functions rte_eal_dev_attach and rte_eal_dev_detach are updated to > > use this new interface. > > > Other than my opens on patch 12, this set all looks good to me. The > other comments I made are mostly just suggestions. > > Hopefully next version can be merged. Thanks for the review, your remarks were useful. I will send the new version shortly. > > Regards, > /Bruce -- Gaëtan Rivet 6WIND