From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 2E138374 for ; Tue, 27 Jun 2017 17:08:39 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2017 08:08:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,401,1493708400"; d="scan'208";a="279169760" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.28]) by fmsmga004.fm.intel.com with SMTP; 27 Jun 2017 08:08:22 -0700 Received: by (sSMTP sendmail emulation); Tue, 27 Jun 2017 16:08:22 +0100 Date: Tue, 27 Jun 2017 16:08:21 +0100 From: Bruce Richardson To: =?iso-8859-1?Q?Ga=EBtan?= Rivet Cc: dev@dpdk.org, Jan Blunck Message-ID: <20170627150821.GB99128@bricha3-MOBL3.ger.corp.intel.com> References: <0094d130d0bc93de5d676b67aa28acf6dc81d37b.1498436062.git.gaetan.rivet@6wind.com> <20170627135434.GH104744@bricha3-MOBL3.ger.corp.intel.com> <20170627150514.GE13355@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170627150514.GE13355@bidouze.vm.6wind.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.1 (2017-04-11) Subject: Re: [dpdk-dev] [PATCH v5 04/12] bus: add bus iterator to find a device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2017 15:08:40 -0000 On Tue, Jun 27, 2017 at 05:05:14PM +0200, Gaëtan Rivet wrote: > On Tue, Jun 27, 2017 at 02:54:34PM +0100, Bruce Richardson wrote: > > On Mon, Jun 26, 2017 at 02:22:02AM +0200, Gaetan Rivet wrote: > > > From: Jan Blunck > > > > > > Signed-off-by: Jan Blunck > > > Signed-off-by: Gaetan Rivet > > > --- > > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > > > lib/librte_eal/common/eal_common_bus.c | 24 +++++++++++++++++++++++ > > > lib/librte_eal/common/include/rte_bus.h | 26 +++++++++++++++++++++++++ > > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + > > > 4 files changed, 52 insertions(+) > > > > > > diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > > index f1a0765..21640d6 100644 > > > --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > > +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > > @@ -164,6 +164,7 @@ DPDK_17.05 { > > > > > > rte_bus_find; > > > rte_bus_find_by_device; > > > + rte_bus_find_device; > > > rte_cpu_is_supported; > > > rte_log_dump; > > > rte_log_register; > > > diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c > > > index d208214..63fd9f1 100644 > > > --- a/lib/librte_eal/common/eal_common_bus.c > > > +++ b/lib/librte_eal/common/eal_common_bus.c > > > @@ -190,3 +190,27 @@ rte_bus_find_by_device(const struct rte_device *dev) > > > { > > > return rte_bus_find(bus_find_device, (const void *)dev, NULL); > > > } > > > + > > > +struct rte_device * > > > +rte_bus_find_device(rte_dev_cmp_t cmp, const void *data, > > > + const struct rte_device *start) > > > > One additional suggestion: might it be worthwhile also returning the bus > > for the device here, in an optional 4th parameter. This is, after all, > > a bus API. :-) > > > > /Bruce > > I think having the bus is a good info. > However, > > 1. This makes this API slightly less clean I think. > A subjective matter, but I don't like adding cruft without good > justification. > > 2. The bus will be made accessible by my future patches. The series > afterward are introducing a generic device type representation, which > is composed of the bus. This type info is integral to the device and > thus the bus can be read from within the resulting rte_device here. > So the device will contain a pointer to it's parent bus? If so, then ok, let's leave out the extra parameter. /Bruce > So, I won't add this parameter right now. If we have issues with the > rte_devargs series, it might be interesting to come back on this and > edit this API. > > -- > Gaëtan Rivet > 6WIND