DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Nipun Gupta <nipun.gupta@nxp.com>
Cc: dev@dpdk.org, hemant.agrawal@nxp.com, harry.van.haaren@intel.com,
	bruce.richardson@intel.com, gage.eads@intel.com,
	shreyansh.jain@nxp.com
Subject: Re: [dpdk-dev] [PATCH 00/21 v4] next-eventdev: NXP DPAA2 eventdev PMD
Date: Thu, 29 Jun 2017 16:33:02 +0530	[thread overview]
Message-ID: <20170629110300.GA5779@jerin> (raw)
In-Reply-To: <1498732085-18449-1-git-send-email-nipun.gupta@nxp.com>

-----Original Message-----
> Date: Thu, 29 Jun 2017 15:57:44 +0530
> From: Nipun Gupta <nipun.gupta@nxp.com>
> To: dev@dpdk.org
> CC: hemant.agrawal@nxp.com, jerin.jacob@caviumnetworks.com,
>  harry.van.haaren@intel.com, bruce.richardson@intel.com,
>  gage.eads@intel.com, shreyansh.jain@nxp.com, Nipun Gupta
>  <nipun.gupta@nxp.com>
> Subject: [PATCH 00/21 v4] next-eventdev: NXP DPAA2 eventdev PMD
> X-Mailer: git-send-email 1.9.1
> 
> The following patch set adds NXP DPAA2 HW based eventdev
> implementation to the next-eventdev tree.
> 
> The patchset consists of the following:
> - DPCON support required by DPAA2 eventdev
> - DPCI support in fslmc bus
> - Interrupt support in QBMAN
> - Implemetation of eventdev API's for DPAA2
> - Documentation of DPAA2 eventdev PMD

Overall it looks good.

There are a few check-git log and check-patch errors. Please send the
next version with fixes that makes sense.

If there are no more review comments. I will pull the next version in a week for
eventdev-next.

Wrong headline prefix:
	drivers: add bus dependency for event
	fslmc/bus: add interrupt enabling routine

### bus/fslmc: enable portal interrupt handling

WARNING:NAKED_SSCANF: unchecked sscanf return value
#93: FILE: drivers/bus/fslmc/portal/dpaa2_hw_dpio.c:175:
+		sscanf(getenv("DPAA2_PORTAL_INTR_TIMEOUT"), "%x",
&timeout);

WARNING:SSCANF_TO_KSTRTO: Prefer kstrto<type> to single variable sscanf
#93: FILE: drivers/bus/fslmc/portal/dpaa2_hw_dpio.c:175:
+		sscanf(getenv("DPAA2_PORTAL_INTR_TIMEOUT"), "%x",
&timeout);

total: 0 errors, 2 warnings, 247 lines checked






> 
> Changes in v4:
>   Fixed doxygen warning
> 
> Changes in v3:
>   Rebased to dpdk master branch
>   Fix shared library parallel build (patch 01/21)
>   Fixed a checkpatch error
> 
> Changes in v2:
>   Rebase to latest dpdk-next-eventdev
>   Update to support only atomic and ordered queues
>   Fix checkpatch errors
> 
> Hemant Agrawal (3):
>   drivers: add bus dependency for event
>   bus/fslmc: generic framework for mc object creation
>   bus/fslmc: export qbman dqrr funcs for eventdev usages
> 
> Nipun Gupta (18):
>   event/dpaa2: add basic build infrastructure
>   bus/fslmc: integrating dpio and dpbp to object framework
>   bus/fslmc: adding basic dpcon support
>   event/dpaa2: register dpcon as dpaa2 device for bus scan
>   bus/fslmc: adding basic dpci support
>   bus/fslmc: register dpci as dpaa2 device for bus scan
>   bus/fslmc: adding cpu support in stashing config
>   event/dpaa2: add initialization of event device
>   bus/fslmc: add support for static dequeue from portal
>   event/dpaa2: add configuration functions
>   bus/fslmc: support enqueue with multiple enqueue descriptors
>   bus/fslmc: add callback per queue to enable
>   bus/fslmc: change func argument to const to avoid warning
>   event/dpaa2: add enqueue and dequeue functionality
>   fslmc/bus: add interrupt enabling routine
>   bus/fslmc: enable portal interrupt handling
>   event/dpaa2: handle timeout using interrupts in dequeue
>   doc: add NXP DPAA2 EVENTDEV details
> 
>  MAINTAINERS                                        |   5 +
>  config/defconfig_arm64-dpaa2-linuxapp-gcc          |   6 +
>  doc/guides/eventdevs/dpaa2.rst                     | 175 ++++++
>  doc/guides/eventdevs/index.rst                     |   1 +
>  drivers/Makefile                                   |   1 +
>  drivers/bus/fslmc/Makefile                         |   5 +-
>  drivers/bus/fslmc/fslmc_vfio.c                     |  69 +-
>  drivers/bus/fslmc/fslmc_vfio.h                     |  47 +-
>  drivers/bus/fslmc/mc/dpci.c                        | 307 +++++++++
>  drivers/bus/fslmc/mc/dpcon.c                       | 230 +++++++
>  drivers/bus/fslmc/mc/dpio.c                        |  44 ++
>  drivers/bus/fslmc/mc/fsl_dpci.h                    | 404 ++++++++++++
>  drivers/bus/fslmc/mc/fsl_dpci_cmd.h                | 147 +++++
>  drivers/bus/fslmc/mc/fsl_dpcon.h                   | 238 +++++++
>  drivers/bus/fslmc/mc/fsl_dpcon_cmd.h               | 175 ++++++
>  drivers/bus/fslmc/mc/fsl_dpio.h                    |  30 +
>  drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c           |  14 +-
>  drivers/bus/fslmc/portal/dpaa2_hw_dpci.c           | 179 ++++++
>  drivers/bus/fslmc/portal/dpaa2_hw_dpio.c           | 133 +++-
>  drivers/bus/fslmc/portal/dpaa2_hw_dpio.h           |   5 +
>  drivers/bus/fslmc/portal/dpaa2_hw_pvt.h            |  28 +-
>  drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h |  46 +-
>  drivers/bus/fslmc/qbman/qbman_portal.c             |  94 ++-
>  drivers/bus/fslmc/rte_bus_fslmc_version.map        |  18 +
>  drivers/event/Makefile                             |   2 +
>  drivers/event/dpaa2/Makefile                       |  60 ++
>  drivers/event/dpaa2/dpaa2_eventdev.c               | 691 +++++++++++++++++++++
>  drivers/event/dpaa2/dpaa2_eventdev.h               | 114 ++++
>  drivers/event/dpaa2/dpaa2_hw_dpcon.c               | 139 +++++
>  .../event/dpaa2/rte_pmd_dpaa2_event_version.map    |   3 +
>  mk/rte.app.mk                                      |   1 +
>  31 files changed, 3370 insertions(+), 41 deletions(-)
>  create mode 100644 doc/guides/eventdevs/dpaa2.rst
>  create mode 100644 drivers/bus/fslmc/mc/dpci.c
>  create mode 100644 drivers/bus/fslmc/mc/dpcon.c
>  create mode 100644 drivers/bus/fslmc/mc/fsl_dpci.h
>  create mode 100644 drivers/bus/fslmc/mc/fsl_dpci_cmd.h
>  create mode 100644 drivers/bus/fslmc/mc/fsl_dpcon.h
>  create mode 100644 drivers/bus/fslmc/mc/fsl_dpcon_cmd.h
>  create mode 100644 drivers/bus/fslmc/portal/dpaa2_hw_dpci.c
>  create mode 100644 drivers/event/dpaa2/Makefile
>  create mode 100644 drivers/event/dpaa2/dpaa2_eventdev.c
>  create mode 100644 drivers/event/dpaa2/dpaa2_eventdev.h
>  create mode 100644 drivers/event/dpaa2/dpaa2_hw_dpcon.c
>  create mode 100644 drivers/event/dpaa2/rte_pmd_dpaa2_event_version.map
> 
> -- 
> 1.9.1
> 

  parent reply	other threads:[~2017-06-29 11:03 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1495735361-4840-1-git-send-email-nipun.gupta@nxp.com>
2017-06-15  8:58 ` [dpdk-dev] [PATCH 00/20 v2] " Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 01/20 v2] event/dpaa2: add basic build infrastructure Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 02/20 v2] bus/fslmc: generic framework for mc object creation Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 03/20 v2] bus/fslmc: integrating dpio and dpbp to object framework Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 04/20 v2] bus/fslmc: adding basic dpcon support Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 05/20 v2] bus/fslmc: export qbman dqrr funcs for eventdev usages Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 06/20 v2] event/dpaa2: register dpcon as dpaa2 device for bus scan Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 07/20 v2] bus/fslmc: adding basic dpci support Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 08/20 v2] bus/fslmc: register dpci as dpaa2 device for bus scan Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 09/20 v2] bus/fslmc: adding cpu support in stashing config Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 10/20 v2] event/dpaa2: add initialization of event device Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 11/20 v2] bus/fslmc: add support for static dequeue from portal Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 12/20 v2] event/dpaa2: add configuration functions Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 13/20 v2] bus/fslmc: support enqueue with multiple enqueue descriptors Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 14/20 v2] bus/fslmc: add callback per queue to enable Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 15/20 v2] bus/fslmc: change func argument to const to avoid warning Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 16/20 v2] event/dpaa2: add enqueue and dequeue functionality Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 17/20 v2] fslmc/bus: add interrupt enabling routine Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 18/20 v2] bus/fslmc: enable portal interrupt handling Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 19/20 v2] event/dpaa2: handle timeout using interrupts in dequeue Nipun Gupta
2017-06-15  8:58   ` [dpdk-dev] [PATCH 20/20 v2] doc: add NXP DPAA2 EVENTDEV details Nipun Gupta
2017-06-28 13:51   ` [dpdk-dev] [PATCH 00/20 v2] next-eventdev: NXP DPAA2 eventdev PMD Nipun Gupta
2017-06-29  6:39     ` Jerin Jacob
2017-06-28 15:15 ` [dpdk-dev] [PATCH 00/21 v3] " Nipun Gupta
2017-06-28 15:15   ` [dpdk-dev] [PATCH 01/21 v3] drivers: add bus dependency for event Nipun Gupta
2017-06-28 15:15   ` [dpdk-dev] [PATCH 02/21 v3] event/dpaa2: add basic build infrastructure Nipun Gupta
2017-06-28 15:15   ` [dpdk-dev] [PATCH 03/21 v3] bus/fslmc: generic framework for mc object creation Nipun Gupta
2017-06-28 15:15   ` [dpdk-dev] [PATCH 04/21 v3] bus/fslmc: integrating dpio and dpbp to object framework Nipun Gupta
2017-06-28 15:15   ` [dpdk-dev] [PATCH 05/21 v3] bus/fslmc: adding basic dpcon support Nipun Gupta
2017-06-28 15:15   ` [dpdk-dev] [PATCH 06/21 v3] bus/fslmc: export qbman dqrr funcs for eventdev usages Nipun Gupta
2017-06-28 15:15   ` [dpdk-dev] [PATCH 07/21 v3] event/dpaa2: register dpcon as dpaa2 device for bus scan Nipun Gupta
2017-06-28 15:15   ` [dpdk-dev] [PATCH 08/21 v3] bus/fslmc: adding basic dpci support Nipun Gupta
2017-06-28 15:15   ` [dpdk-dev] [PATCH 09/21 v3] bus/fslmc: register dpci as dpaa2 device for bus scan Nipun Gupta
2017-06-28 15:15   ` [dpdk-dev] [PATCH 10/21 v3] bus/fslmc: adding cpu support in stashing config Nipun Gupta
2017-06-28 15:15   ` [dpdk-dev] [PATCH 11/21 v3] event/dpaa2: add initialization of event device Nipun Gupta
2017-06-28 15:15   ` [dpdk-dev] [PATCH 12/21 v3] bus/fslmc: add support for static dequeue from portal Nipun Gupta
2017-06-28 15:15   ` [dpdk-dev] [PATCH 13/21 v3] event/dpaa2: add configuration functions Nipun Gupta
2017-06-28 15:15   ` [dpdk-dev] [PATCH 14/21 v3] bus/fslmc: support enqueue with multiple enqueue descriptors Nipun Gupta
2017-06-28 15:15   ` [dpdk-dev] [PATCH 15/21 v3] bus/fslmc: add callback per queue to enable Nipun Gupta
2017-06-28 15:15   ` [dpdk-dev] [PATCH 16/21 v3] bus/fslmc: change func argument to const to avoid warning Nipun Gupta
2017-06-28 15:16   ` [dpdk-dev] [PATCH 17/21 v3] event/dpaa2: add enqueue and dequeue functionality Nipun Gupta
2017-06-28 15:16   ` [dpdk-dev] [PATCH 18/21 v3] fslmc/bus: add interrupt enabling routine Nipun Gupta
2017-06-28 15:16   ` [dpdk-dev] [PATCH 19/21 v3] bus/fslmc: enable portal interrupt handling Nipun Gupta
2017-06-28 15:16   ` [dpdk-dev] [PATCH 20/21 v3] event/dpaa2: handle timeout using interrupts in dequeue Nipun Gupta
2017-06-28 15:16   ` [dpdk-dev] [PATCH 21/21 v3] doc: add NXP DPAA2 EVENTDEV details Nipun Gupta
2017-06-29  9:25     ` Jerin Jacob
2017-06-29 10:27       ` Nipun Gupta
2017-06-29  5:15   ` [dpdk-dev] [PATCH 00/21 v3] next-eventdev: NXP DPAA2 eventdev PMD Hemant Agrawal
2017-06-29 10:27 ` [dpdk-dev] [PATCH 00/21 v4] " Nipun Gupta
2017-06-29 10:27   ` [dpdk-dev] [PATCH 01/21 v4] drivers: add bus dependency for event Nipun Gupta
2017-06-29 10:27   ` [dpdk-dev] [PATCH 02/21 v4] event/dpaa2: add basic build infrastructure Nipun Gupta
2017-06-29 10:27   ` [dpdk-dev] [PATCH 03/21 v4] bus/fslmc: generic framework for mc object creation Nipun Gupta
2017-06-29 10:27   ` [dpdk-dev] [PATCH 04/21 v4] bus/fslmc: integrating dpio and dpbp to object framework Nipun Gupta
2017-06-29 10:27   ` [dpdk-dev] [PATCH 05/21 v4] bus/fslmc: adding basic dpcon support Nipun Gupta
2017-06-29 10:27   ` [dpdk-dev] [PATCH 06/21 v4] bus/fslmc: export qbman dqrr funcs for eventdev usages Nipun Gupta
2017-06-29 10:27   ` [dpdk-dev] [PATCH 07/21 v4] event/dpaa2: register dpcon as dpaa2 device for bus scan Nipun Gupta
2017-06-29 10:27   ` [dpdk-dev] [PATCH 08/21 v4] bus/fslmc: adding basic dpci support Nipun Gupta
2017-06-29 10:27   ` [dpdk-dev] [PATCH 09/21 v4] bus/fslmc: register dpci as dpaa2 device for bus scan Nipun Gupta
2017-06-29 10:27   ` [dpdk-dev] [PATCH 10/21 v4] bus/fslmc: adding cpu support in stashing config Nipun Gupta
2017-06-29 10:27   ` [dpdk-dev] [PATCH 11/21 v4] event/dpaa2: add initialization of event device Nipun Gupta
2017-06-29 10:27   ` [dpdk-dev] [PATCH 12/21 v4] bus/fslmc: add support for static dequeue from portal Nipun Gupta
2017-06-29 10:27   ` [dpdk-dev] [PATCH 13/21 v4] event/dpaa2: add configuration functions Nipun Gupta
2017-06-29 10:27   ` [dpdk-dev] [PATCH 14/21 v4] bus/fslmc: support enqueue with multiple enqueue descriptors Nipun Gupta
2017-06-29 10:27   ` [dpdk-dev] [PATCH 15/21 v4] bus/fslmc: add callback per queue to enable Nipun Gupta
2017-06-29 10:28   ` [dpdk-dev] [PATCH 16/21 v4] bus/fslmc: change func argument to const to avoid warning Nipun Gupta
2017-06-29 10:28   ` [dpdk-dev] [PATCH 17/21 v4] event/dpaa2: add enqueue and dequeue functionality Nipun Gupta
2017-06-29 10:28   ` [dpdk-dev] [PATCH 18/21 v4] fslmc/bus: add interrupt enabling routine Nipun Gupta
2017-06-29 10:28   ` [dpdk-dev] [PATCH 19/21 v4] bus/fslmc: enable portal interrupt handling Nipun Gupta
2017-06-29 10:28   ` [dpdk-dev] [PATCH 20/21 v4] event/dpaa2: handle timeout using interrupts in dequeue Nipun Gupta
2017-06-29 10:28   ` [dpdk-dev] [PATCH 21/21 v4] doc: add NXP DPAA2 EVENTDEV details Nipun Gupta
2017-06-29 11:03   ` Jerin Jacob [this message]
2017-06-30  7:30     ` [dpdk-dev] [PATCH 00/21 v4] next-eventdev: NXP DPAA2 eventdev PMD Nipun Gupta
2017-06-30  8:54 ` [dpdk-dev] [PATCH 00/21 v5] " Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 01/21 v5] drivers: add bus dependency for event Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 02/21 v5] event/dpaa2: add basic build infrastructure Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 03/21 v5] bus/fslmc: generic framework for mc object creation Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 04/21 v5] bus/fslmc: integrating dpio and dpbp to object framework Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 05/21 v5] bus/fslmc: adding basic dpcon support Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 06/21 v5] bus/fslmc: export qbman dqrr funcs for eventdev usages Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 07/21 v5] event/dpaa2: register dpcon as dpaa2 device for bus scan Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 08/21 v5] bus/fslmc: adding basic dpci support Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 09/21 v5] bus/fslmc: register dpci as dpaa2 device for bus scan Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 10/21 v5] bus/fslmc: adding cpu support in stashing config Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 11/21 v5] event/dpaa2: add initialization of event device Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 12/21 v5] bus/fslmc: add support for static dequeue from portal Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 13/21 v5] event/dpaa2: add configuration functions Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 14/21 v5] bus/fslmc: support enqueue with multiple enqueue descriptors Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 15/21 v5] bus/fslmc: add callback per queue to enable Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 16/21 v5] bus/fslmc: change func argument to const to avoid warning Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 17/21 v5] event/dpaa2: add enqueue and dequeue functionality Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 18/21 v5] bus/fslmc: add interrupt enabling routine Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 19/21 v5] bus/fslmc: enable portal interrupt handling Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 20/21 v5] event/dpaa2: handle timeout using interrupts in dequeue Nipun Gupta
2017-06-30  8:54   ` [dpdk-dev] [PATCH 21/21 v5] doc: add NXP DPAA2 EVENTDEV details Nipun Gupta
2017-06-30 12:13     ` Mcnamara, John
2017-07-01 12:24       ` Jerin Jacob
2017-07-04  6:55     ` Jerin Jacob
2017-07-01 12:28   ` [dpdk-dev] [PATCH 00/21 v5] next-eventdev: NXP DPAA2 eventdev PMD Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170629110300.GA5779@jerin \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=gage.eads@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=nipun.gupta@nxp.com \
    --cc=shreyansh.jain@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).