From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id DF3A65689 for ; Fri, 30 Jun 2017 19:27:28 +0200 (CEST) Received: by mail-pf0-f178.google.com with SMTP id e7so70318892pfk.0 for ; Fri, 30 Jun 2017 10:27:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mEAyNBcPabpVWlEJjQazajYXF1BSmz2T2L4GAi2ONqw=; b=nu9M92CZUxh7LLqoEagE+1KWPLvpGx+wXWGDt99DuRQZTM4WeVV8xGmzhGkfre0fjx RFsE4AAPyH34Uk+O4A/sX9NeoRh5ZuSBL0ghgkaG4c2Ffbsn7P++jbhOCE9lfHV2pEhf nBjNoe6HOAUXhSp93Dk0gzOIIFb/mrntgPCTSI/eX5NM1CrMyFgsOBj0Cx1/S6lE9eOV 1r79rUzKrGu+9awz2pZPrRwQ+81eI1VWStJ8Ppf+WV46dRuRCbDVblIdVrGqH5RXg/Gp raL1YBcnVEs/SSN/fXjWWkeq1w3yAjvErXz6vFTlSz3TY4rLIakoZ+lEq+LdVXJXJP+2 +TtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mEAyNBcPabpVWlEJjQazajYXF1BSmz2T2L4GAi2ONqw=; b=WlWaomYvcmw6bV3wqCl7wAqZDOUNP9XE97dqulKeUQQx7PX5XLs+UEWvVW6IrSXAtT z4YNFP8gRwUqaY2hPzZfGWcbNW5NuHDx+mRf5O1/MNNITS5JzMtaiU2QqQnhE8LS2xCW qE3VGLMhk8J43v3zM4VY0TVX0FKEXCVo5VepaRpzqKXomHZvx0LG7MGaQFcOEtcPj+pV hHe1O8capEsbc6BBLBCQu+awOAG/+dIFD4W08Um9x3/IjaNA0mlb9oXy9sP50WWp1xBW 84MiDDJSspnUlHCp2Uu8U/KLcrj7WqYMdXBh2FWwn/CKIKz/Z0y0VqklXL6BkLLTcUrU X3aQ== X-Gm-Message-State: AKS2vOzoTKqpX2BFPhl473ffrfgflFX4T4J+6WOdYUG0KckL0wB/vSKa FpF6LObxu1QgaSt0 X-Received: by 10.101.91.202 with SMTP id o10mr22485908pgr.206.1498843648162; Fri, 30 Jun 2017 10:27:28 -0700 (PDT) Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id t78sm20404284pfa.48.2017.06.30.10.27.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Jun 2017 10:27:28 -0700 (PDT) Date: Fri, 30 Jun 2017 10:27:25 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org, Bruce Richardson , Anatoly Burakov Message-ID: <20170630102725.6aba4847@xeon-e3> In-Reply-To: <20170630165140.59594-10-ferruh.yigit@intel.com> References: <20170621110651.75299-1-ferruh.yigit@intel.com> <20170630165140.59594-1-ferruh.yigit@intel.com> <20170630165140.59594-10-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v9 09/20] unci: add rtnl newlink X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2017 17:27:29 -0000 On Fri, 30 Jun 2017 17:51:29 +0100 Ferruh Yigit wrote: > + > +#ifndef _RTE_UNCI_COMMON_H_ > +#define _RTE_UNCI_COMMON_H_ > + > +#define UNCI_DEVICE "unci" > + > +enum { > + IFLA_UNCI_UNSPEC, > + IFLA_UNCI_PORTID, > + IFLA_UNCI_PID, > + __IFLA_UNCI_MAX, > +}; > + > +#define IFLA_UNCI_MAX (__IFLA_UNCI_MAX - 1) > + > +#endif /* _RTE_UNCI_COMMON_H_ */ > diff --git a/lib/librte_eal/linuxapp/unci/unci_dev.h b/lib/librte_eal/linuxapp/unci/unci_dev.h > index 0337fa82b..b0a215f1b 100644 > --- a/lib/librte_eal/linuxapp/unci/unci_dev.h > +++ b/lib/librte_eal/linuxapp/unci/unci_dev.h > @@ -26,11 +26,16 @@ > #define _UNCI_DEV_H_ > > #include > +#include > > #ifdef pr_fmt > #undef pr_fmt > #endif > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > +struct unci_dev { > + u8 port_id; > + u32 pid; > +}; These are to/from user space so should be __u8, __u32. Also, probably want to support more than 256 ports at some time in future. So make them both __u32. > > #endif /* _UNCI_DEV_H_ */ Since you want to target this for upstream kernel. Please try and layout the includes in an easy manner to do this and avoid using rte_ in names.