From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg0-f47.google.com (mail-pg0-f47.google.com [74.125.83.47])
 by dpdk.org (Postfix) with ESMTP id 54D315323
 for <dev@dpdk.org>; Fri, 30 Jun 2017 19:28:21 +0200 (CEST)
Received: by mail-pg0-f47.google.com with SMTP id j186so66642774pge.2
 for <dev@dpdk.org>; Fri, 30 Jun 2017 10:28:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=HsjqvfIvzIy49DXgec2BRMRK8GmAeGEcJIt7H3yUesE=;
 b=aJNDvc5q8547Iuan3knR8RYt6OGn5omEZ7rzda7lTludGOsg6DqirVFtJUxgSltAMD
 KIeOlEIM50VXSi+Pkvxb2hEC9JpqKAwYkR1fdRBE7R1+yc+sTVCc+QizzhMC8GE8fzzy
 rxGUcQSy20jdQ2d84cAAJoNIV6XnJQA4Mpx5pRq3+rprQsKPkFTryJTwOxs9REkI/EWG
 xXYXZ9obVkBGWK70JngG9FyCBlqy0LDGjn1RNuLU63NZ12pzBwLwnG7Bivyu98DBHb40
 w9JZ35wCpgm+2qWpv1PSO5m0UFrX3/vakri3NgUng1p9EB93Vm8AtFgv2xg9nwGf7Ma7
 EEvg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=HsjqvfIvzIy49DXgec2BRMRK8GmAeGEcJIt7H3yUesE=;
 b=T3r0uwC753wkHw8Id1zaTqgpHfCBgohmH130fyVntorkfN97/z1vwidrGlXndojNb+
 h9Kvg0dLjE7d8JR8+9IWHu6pAh4Th8yCqZehaZBeldO85kdfWIv5/hKwONlUhLJIsDVi
 3GSzzlkU4BeUzlNf+8ckfthZs3c4DuUvsTqxKCBusp2rTjIk4OYxakNjcpCyRaQV/J24
 Z22O3j8cValbv40Tik1SAdGliIzOHAok7Cd2VhUyaYmiaqSuMv6VYBnT4jLVgcl4XFU7
 Gaa+Z3haAy3V8AK5BZ6ms+Qe6kgUANTAZC7r9sBV9IB6XmiDcTunj1ixEvZXHFnfe35i
 VMmw==
X-Gm-Message-State: AKS2vOw8NL5kjLfr5Me8sG34Pcg5GdyDYSiNDcToUTSEMchD/3hA6FCa
 2bdAQYX31UJmy+R+
X-Received: by 10.84.231.141 with SMTP id g13mr25100107plk.157.1498843700191; 
 Fri, 30 Jun 2017 10:28:20 -0700 (PDT)
Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])
 by smtp.gmail.com with ESMTPSA id v3sm19334786pfi.73.2017.06.30.10.28.19
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Fri, 30 Jun 2017 10:28:20 -0700 (PDT)
Date: Fri, 30 Jun 2017 10:28:18 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>, Anatoly
 Burakov <anatoly.burakov@intel.com>
Message-ID: <20170630102818.0b335187@xeon-e3>
In-Reply-To: <20170630165140.59594-11-ferruh.yigit@intel.com>
References: <20170621110651.75299-1-ferruh.yigit@intel.com>
 <20170630165140.59594-1-ferruh.yigit@intel.com>
 <20170630165140.59594-11-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v9 10/20] unci: init netlink
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Jun 2017 17:28:21 -0000

On Fri, 30 Jun 2017 17:51:30 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

>  #define UNCI_DEVICE "unci"
>  
> +#define UNCI_NL_GRP 31
> +
> +#define UNCI_NL_MSG_LEN 500
> +struct unci_nl_msg {
> +	uint32_t cmd_id;
> +	uint8_t port_id;
> +	uint32_t flag;
> +	uint8_t input_buffer[UNCI_NL_MSG_LEN];
> +	uint8_t output_buffer[UNCI_NL_MSG_LEN];
> +	size_t input_buffer_len;
> +	size_t output_buffer_len;
> +	int err;
> +};
> +
>  enum {
>  	IFLA_UNCI_UNSPEC,

Kernel code should not use uint32_t or uint8_t.
Stick to __u32 and __u8