From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f43.google.com (mail-pg0-f43.google.com [74.125.83.43]) by dpdk.org (Postfix) with ESMTP id E7C0E2A58 for ; Tue, 4 Jul 2017 10:12:03 +0200 (CEST) Received: by mail-pg0-f43.google.com with SMTP id j186so106650446pge.2 for ; Tue, 04 Jul 2017 01:12:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TEieDflxC581H6+SZIAwcM2Rz/gTMjMJLv9+a+OaLQo=; b=zbkbdMCYhvXtwqqh4+5BXEuzl3Km5ZCobkd/3oExNMT7t+x+2qan5y2vS4NAWptvna 9Uxv0XOXzX6v+k4ryI2X+qiEEaqxadl0qw50DBU4aWh7PjVngQpntrx2kgRdmD4KGTOr gA3zq3hg0g87moxfrpMbg5LJlW1Ss+vFUffmyH7m0NDASZ0ck8Sdu4Q2Mo1FH2rbgRhf JiRbrkmO8bfqiTMDoYS8h5bYAVbY7TNWkmvaokhg48d0/vWY1MXOPobLaT7/1RWQKvhk pKh27AzFsCDVWLJRV8NxM6pIxrAy4qoQOD9oe5mcyQfIMtimQ8ZQhXxH9iMCEry/ZXfO iMzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TEieDflxC581H6+SZIAwcM2Rz/gTMjMJLv9+a+OaLQo=; b=Qgn28fuKc7uo7cPEmZGd0nLU/2e9u4HatBO+SH8mGe2Z3WTp4sayAi0cyQ0ZkN1W2A FXsx86Dt30V0Z/mzCVXI8Aj20Dab08vgz2ZJJp7Sgb73qAkmf96TwKytC0jE4cG0QkNQ 2k2QxHJ5ZgoVAPkjgsrMtzY//p9GzGHQhP7gb6fxhE5PF0yDfstA8GEsnDZZXbxwSvy0 DIGmH7S/uBcOhtu/Ske8nSi1OJbJREeJI3t5YASTk1Gcs9ZokXXhrzijCHYrK4SJTQ/U v5cI7/AMqZ40DGvhkA4xA+tQjyzGvUq3ibpmXgOpbLShP7LSbb9VE3GkixMx0PsEenXy 2NuA== X-Gm-Message-State: AIVw110UVPPMbjWrA6HjdaF4uxmyhihSl269a9ksidjnlZ6MhmKHGyhI dcDRLonA3jt2+FL0 X-Received: by 10.99.120.69 with SMTP id t66mr14638218pgc.237.1499155923045; Tue, 04 Jul 2017 01:12:03 -0700 (PDT) Received: from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id u9sm42807548pfg.127.2017.07.04.01.12.00 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 04 Jul 2017 01:12:01 -0700 (PDT) Date: Tue, 4 Jul 2017 16:11:55 +0800 From: Yuanhan Liu To: "Hu, Jiayu" Cc: "Tan, Jianfeng" , "dev@dpdk.org" , "Ananyev, Konstantin" , "stephen@networkplumber.org" , "Wu, Jingjing" , "Yao, Lei A" , "Bie, Tiwei" Message-ID: <20170704081155.GJ11626@yliu-home> References: <1498805618-63649-1-git-send-email-jiayu.hu@intel.com> <1498907323-17563-1-git-send-email-jiayu.hu@intel.com> <1498907323-17563-2-git-send-email-jiayu.hu@intel.com> <9ccb015f-c635-3080-f732-6412998aacca@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH v10 1/3] lib: add Generic Receive Offload API framework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jul 2017 08:12:04 -0000 On Mon, Jul 03, 2017 at 05:56:20AM +0000, Hu, Jiayu wrote: > > > +/** > > > + * GRO table, which is used to merge packets. It keeps many reassembly > > > + * tables of desired GRO types. Applications need to create GRO tables > > > + * before using rte_gro_reassemble to perform GRO. > > > + */ > > > +struct gro_tbl { > > > + uint64_t desired_gro_types; /**< GRO types to perform */ > > > + /* max TTL measured in nanosecond */ > > > + uint64_t max_timeout_cycles; > > > + /* max length of merged packet measured in byte */ > > > + uint32_t max_packet_size; > > > + /* reassebly tables of desired GRO types */ > > > + void *tbls[RTE_GRO_TYPE_MAX_NUM]; > > > +}; > > > + > > > +void *rte_gro_tbl_create(const > > > + const struct rte_gro_param *param) > > > > The name of this API and the definition of struct gro_tbl involve some > > confusion. A gro table contains gro tables? I suppose a better name is > > needed, for example, struct gro_ctl. > > Actually, a GRO table includes N reassembly tables. But gro_tbl is not a good > name. I will change the name. Thanks. Haven't looked at the details yet, but, probably, gro_ctx (context) is a better and more typical name? --yliu