From: Jens Freimann <jfreimann@redhat.com>
To: dev@dpdk.org
Cc: yuanhan.liu@linux.intel.com, maxime.coquelin@redhat.com
Subject: [dpdk-dev] [PATCH 3/3] vhost: check return value of pthread_mutex_init()
Date: Tue, 4 Jul 2017 10:50:43 +0200 [thread overview]
Message-ID: <20170704085043.3662-4-jfreimann@redhat.com> (raw)
In-Reply-To: <20170704085043.3662-1-jfreimann@redhat.com>
Check return value of pthread_mutex_init(). Also destroy
mutex in case of other erros before returning.
Signed-off-by: Jens Freimann <jfreimann@redhat.com>
---
lib/librte_vhost/socket.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
index 7b5df6f..83ef943 100644
--- a/lib/librte_vhost/socket.c
+++ b/lib/librte_vhost/socket.c
@@ -445,13 +445,21 @@ vhost_user_reconnect_init(void)
{
int ret;
- pthread_mutex_init(&reconn_list.mutex, NULL);
+ ret = pthread_mutex_init(&reconn_list.mutex, NULL);
+ if (ret < 0) {
+ RTE_LOG(ERR, VHOST_CONFIG, "failed to initialize mutex");
+ return ret;
+ }
TAILQ_INIT(&reconn_list.head);
ret = pthread_create(&reconn_tid, NULL,
vhost_user_client_reconnect, NULL);
- if (ret < 0)
+ if (ret < 0) {
RTE_LOG(ERR, VHOST_CONFIG, "failed to create reconnect thread");
+ if (pthread_mutex_destroy(&reconn_list.mutex))
+ RTE_LOG(ERR, VHOST_CONFIG,
+ "failed to destroy reconnect mutex");
+ }
return ret;
}
--
2.9.4
next prev parent reply other threads:[~2017-07-04 8:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 8:50 [dpdk-dev] [PATCH 0/3] vhost: small cleanups Jens Freimann
2017-07-04 8:50 ` [dpdk-dev] [PATCH 1/3] vhost: add missing check strdup() return value Jens Freimann
2017-07-04 8:50 ` [dpdk-dev] [PATCH 2/3] vhost: check return values of pthread_* calls Jens Freimann
2017-07-04 9:17 ` Yuanhan Liu
2017-07-04 9:28 ` Jens Freimann
2017-07-04 8:50 ` Jens Freimann [this message]
2017-07-04 9:15 ` [dpdk-dev] [PATCH 0/3] vhost: small cleanups Yuanhan Liu
2017-07-04 9:23 ` Jens Freimann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704085043.3662-4-jfreimann@redhat.com \
--to=jfreimann@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).