From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f45.google.com (mail-pg0-f45.google.com [74.125.83.45]) by dpdk.org (Postfix) with ESMTP id 454842BA4 for ; Tue, 4 Jul 2017 11:25:27 +0200 (CEST) Received: by mail-pg0-f45.google.com with SMTP id j186so107568660pge.2 for ; Tue, 04 Jul 2017 02:25:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IzHNGM5MakbMXuRnZZyzE3GGqkrCRMufINwldVlabMU=; b=vu9/+YPR4/dD3R5M/FI4Sp8bI7vpD4iwKVN5ShcP5VmW9uINWqQjAVFGRExi6kxXz/ EA+ytsQtFJmtRjLVPrDS+YwrgR94ZYmLZY29ogKU/DxvPLbf+96L+0/Z5nUG0tZmbRTh vU1REfc8SGacS3Wci/KiPvH8W5lotRaRvdi5YQzJ2Omr7FR8IOy65GMSUh2PTyRQctOF DzVu8/54+zdBKzWmc9SPyiSNZ2QgBOEdLii5q4/wQdrvu4mLSflspEJZYLqJMunm47zW TUIuB86UaVcNObOo0r+yo9UDhH0YtBKECTFDfu+QP67mvgiOoaNtIF22h0CwlNYoDK5i mYCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IzHNGM5MakbMXuRnZZyzE3GGqkrCRMufINwldVlabMU=; b=BoLjEFKh3sJ0MjGn6Z0a5S8f+cq5kUQu+6inK01X+SHQ0wsAOq+UCVX9+Mc5/wjgXK 10epXrk4gEr1XJRzyCidHye4dCr0UqAKELu5Atyh6RsRXVKHGHHLbDK3rlOV/uaEtYnN IAF8aK+Y5Fn9MwahL1qnsz4A1BUwY1rl0eAK8sFRRU/ikCzxrxKSHC6oXMV5hzGY/aF9 xAv675D3xwarh48naqPW2CgfLfysQQKlTXviI+aOit6uh6Qcn748gesFvrQG6vPG+XDd xaC39hkls1rJfqAskUeqWwRVUtNjNUtaNMRNYRE9VRWRwY/h2/s2OBArHtHiL8F1NHAB kEEg== X-Gm-Message-State: AIVw111GvwF4BdNSJVeCmWnTlC1tx2V6MBcz3vzDlOsCF9qQeHnE800I yTkzssgzM1QPa7OS X-Received: by 10.84.217.137 with SMTP id p9mr15462412pli.80.1499160326815; Tue, 04 Jul 2017 02:25:26 -0700 (PDT) Received: from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id t11sm43341874pfi.66.2017.07.04.02.25.24 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 04 Jul 2017 02:25:25 -0700 (PDT) Date: Tue, 4 Jul 2017 17:25:17 +0800 From: Yuanhan Liu To: Allain Legacy Cc: maxime.coquelin@redhat.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20170704092517.GO11626@yliu-home> References: <20170623124137.61091-1-allain.legacy@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170623124137.61091-1-allain.legacy@windriver.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: fix crash when detaching device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jul 2017 09:25:28 -0000 On Fri, Jun 23, 2017 at 08:41:37AM -0400, Allain Legacy wrote: > The rte_eth_dev.data pointer is set to a reference to a static table. > Attempting to rte_free() it leads to a panic. For example, the > following commands result in a panic if run in testpmd > > testpmd> port attach virtio_user0,path=/dev/vhost-net,iface=test0 > testpmd> port stop 2 > testpmd> port close 2 > testpmd> port detach 2 > > Fixes: ce2eabdd43ec ("net/virtio-user: add virtual device") Note that it's prefered (and asked) to add stable tag inside the commit log. Cc: stable@dpdk.org Applied to dpdk-next-virtio, with above tag added. Thanks. --yliu