From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com
 [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id B900C2C4A
 for <dev@dpdk.org>; Wed,  5 Jul 2017 21:12:23 +0200 (CEST)
Received: by mail-pf0-f178.google.com with SMTP id q85so20666948pfq.1
 for <dev@dpdk.org>; Wed, 05 Jul 2017 12:12:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=jFKPOxfbOVoZGDuaMYyvfcbLp48XFOJcTLs7/IKR7vQ=;
 b=SANLZSojJBNDkOkOD9iXRNUuOQA4uwlL+LkRuO7dfn+jkmo63UARWJlLLaE2sMHtP7
 iiCY8FGodB6abmuw78rjCC146EdYRSltoC5c1YX0F5jMj3zuFDJzY7GW96Atflj9e0yS
 M72PTimCjuPpDsT7LJjoIry9bKI5Sh6EfJQMvXGM2D0EWjnamI59D1MEsenJGZ4ZXaiQ
 p1AglxhCqGbSbhbr0akp+UA1nhG0e7DRL600wLnYdsYNJ+RoIL9vBQGGywRSi3CiW6wp
 uCxCyv96dpi1iMcT1SMhzZiPn+lXQt8dGp1Vglw3bSU5/8Q+bJG77h8OobZNV72t8N0n
 xkng==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=jFKPOxfbOVoZGDuaMYyvfcbLp48XFOJcTLs7/IKR7vQ=;
 b=TbCEQheLVZkf4I4nruvGaPrLt0SkObESg7POwlnXTi3CbY7fkCwxud1cJjvfmGCBlp
 Fpelgp8ymBU7IrhGsYsU6QLSAFzgWMEDVK503mcwRv6k8fjK9HHhE+bulMXqhbU9N4nZ
 cfCAsT5yCdBA83FlddMyaHMGgitiC+oqdFLOAQGC6QrqzJ7OYD9vil2fPrjr4O1GQQ/t
 AkWL6VRynvznYkjMn15P1a80uEzuQPzoCrgWYHmyBztQhRV1GQCO3nzC6dyFLP55JtSL
 BKgy28bgmwfISEuCYcLgB/sRRnuuFJITg+ygf6pT4EYC9zDWEDtePEU1Q30eyrR34/ZX
 l5AA==
X-Gm-Message-State: AIVw111ehD3CXHG1WdU8jGe9J+4MshZ17ahRw3Ytr4wa5R5+pIkU0eTX
 cbkDDQPik/yruxKM
X-Received: by 10.84.195.131 with SMTP id j3mr23682614pld.147.1499281942893;
 Wed, 05 Jul 2017 12:12:22 -0700 (PDT)
Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])
 by smtp.gmail.com with ESMTPSA id s9sm57330359pfe.67.2017.07.05.12.12.22
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 05 Jul 2017 12:12:22 -0700 (PDT)
Date: Wed, 5 Jul 2017 12:12:16 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>, Anatoly
 Burakov <anatoly.burakov@intel.com>
Message-ID: <20170705121216.0c005109@xeon-e3>
In-Reply-To: <20170704161337.45926-13-ferruh.yigit@intel.com>
References: <20170630165140.59594-1-ferruh.yigit@intel.com>
 <20170704161337.45926-1-ferruh.yigit@intel.com>
 <20170704161337.45926-13-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v10 12/20] unci: add netdevice ops
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jul 2017 19:12:24 -0000

On Tue,  4 Jul 2017 17:13:29 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> +#if (KERNEL_VERSION(3, 9, 0) <= LINUX_VERSION_CODE)
> +static int unci_net_change_carrier(struct net_device *dev, bool new_carrier)
> +{
> +	if (new_carrier)
> +		netif_carrier_on(dev);
> +	else
> +		netif_carrier_off(dev);
> +	return 0;
> +}
> +#endif

Don't really need ndo_change_carrier. It is meant for layered devices like team
device.

For unci, the carrier state should always track what the DPDK driver reports.