From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f179.google.com (mail-pf0-f179.google.com [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id 435F62C8 for ; Fri, 7 Jul 2017 02:25:47 +0200 (CEST) Received: by mail-pf0-f179.google.com with SMTP id c73so8561193pfk.2 for ; Thu, 06 Jul 2017 17:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OLfmEWnJ7ppd7IOlXn7OIHFlVWQ/NxNRmKfhHr75ECU=; b=hIF3ln/80k97lkAwxSu5taSD2O5YBx/n2N/7rDjHZG4guarg0RXkoqAdusSm6c/NUQ z8ZiI9fMIRTc5ChPmfBnS7WZG97wUIELrpZDpVs72YGlI6aUFFjGUMdBWmdQsF/sjVAV 3L+uMfFeZnbuF39RSeLZV2x7DBebXETiuA/g41A8VVlYyZFNe34c0VuGZ+Syr3hBwfN9 KmMyziSyxNK+HNNerBMgayA/aZqUFnUEnjtPdTLsqBKKj/QOLaQfFyBMXPTk3jy2sq33 yQiVcSD6iMu8+TgetJon946LRi4tCY3plqweETxJRMoVvAmb56Nb+L3CR2vzLGmCqi4u eQ3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OLfmEWnJ7ppd7IOlXn7OIHFlVWQ/NxNRmKfhHr75ECU=; b=caB49YBmxQOel1VKSOTuvXGTEvgCkziDVE1qFhlgdMCVRt5y+JDeDXVOdqfxFqvO1A XSfZDXg6ae+37GuhS/7+DH1oNp+hhDoX8WVcLCHJ4vzlWcGQ9IRM+67KkI4zDmjgff0G Mn/Y6dZUK/DS8R/ARAQL5QAr9JiT5jlPcpWZYuh0GJjs/7Ld7sbC3MmQBSqE/k9U9ePS g86T8jJHtTiGMYYfqto6Xvm4N56Vst0pydh3x//JH+rwqYGX5QPe4GQYQXv4Gkjho4/q IBu3jrYoiOJVAQ5giQJkxKcUmhViNj3alfhFGNCwH3KLCrMNeCGKcPON3vSb/nmiC+az 4eBQ== X-Gm-Message-State: AIVw1125fidhKcTnir5ytjJaIPzz91LrV/hZ7xxhF6tWNAIwOWhaQUYf PduYbPPrYYMqhK2C X-Received: by 10.84.232.198 with SMTP id x6mr25586015plm.139.1499387146487; Thu, 06 Jul 2017 17:25:46 -0700 (PDT) Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id u17sm2564875pfk.131.2017.07.06.17.25.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 06 Jul 2017 17:25:46 -0700 (PDT) Date: Thu, 6 Jul 2017 17:25:36 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org, Bruce Richardson , Anatoly Burakov Message-ID: <20170706172536.6d8fd73f@xeon-e3> In-Reply-To: References: <20170630165140.59594-1-ferruh.yigit@intel.com> <20170704161337.45926-1-ferruh.yigit@intel.com> <20170704161337.45926-12-ferruh.yigit@intel.com> <20170705120703.77efb263@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v10 11/20] unci: add netlink exec X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jul 2017 00:25:47 -0000 On Thu, 6 Jul 2017 11:45:48 +0100 Ferruh Yigit wrote: > > > Blocking for completion with mutex held? > > Sleeping with mutex held is not allowed in Linux. > > > > You will see this if you run with lockdep and all the other kernel debug > > config options. > > Thank you for the review, > > I will send a new version addressing all comments. > > Thanks, > ferruh > I was wrong, it is okay to sleep with mutex held. You might find it easier to use a spin_lock and waitqueue directly via wait_event_interruptible_locked