From: Jan Blunck <jblunck@infradead.org>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] eal: internalize devargs parsing
Date: Sun, 9 Jul 2017 05:28:46 -0400 [thread overview]
Message-ID: <20170709092847.13339-2-jblunck@infradead.org> (raw)
In-Reply-To: <20170709092847.13339-1-jblunck@infradead.org>
This is going to get cleaned up in future releases so lets not expose
this API unnecessarily.
Signed-off-by: Jan Blunck <jblunck@infradead.org>
---
doc/guides/rel_notes/deprecation.rst | 2 +-
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 -
lib/librte_eal/common/eal_common_devargs.c | 2 +-
lib/librte_eal/common/include/rte_devargs.h | 20 --------------------
lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 -
5 files changed, 2 insertions(+), 24 deletions(-)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 257dcba32..33e8b93db 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -63,4 +63,4 @@ Deprecation Notices
* eal: the following function is deprecated starting from 17.08 and will
be removed in 17.11:
- - ``rte_eal_parse_devargs_str``, replaced by ``rte_eal_devargs_parse``
+ - ``rte_eal_parse_devargs_str``
diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
index 381f895cd..0295ea948 100644
--- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
@@ -206,7 +206,6 @@ DPDK_17.08 {
EXPERIMENTAL {
global:
- rte_eal_devargs_parse;
rte_eal_hotplug_add;
rte_eal_hotplug_remove;
diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c
index 49d43a328..40b6ced82 100644
--- a/lib/librte_eal/common/eal_common_devargs.c
+++ b/lib/librte_eal/common/eal_common_devargs.c
@@ -83,7 +83,7 @@ bus_name_cmp(const struct rte_bus *bus, const void *name)
return strncmp(bus->name, name, strlen(bus->name));
}
-int
+static int
rte_eal_devargs_parse(const char *dev, struct rte_devargs *da)
{
struct rte_bus *bus = NULL;
diff --git a/lib/librte_eal/common/include/rte_devargs.h b/lib/librte_eal/common/include/rte_devargs.h
index a0427cd8a..a5c4a4ae5 100644
--- a/lib/librte_eal/common/include/rte_devargs.h
+++ b/lib/librte_eal/common/include/rte_devargs.h
@@ -119,26 +119,6 @@ int rte_eal_parse_devargs_str(const char *devargs_str,
char **drvname, char **drvargs);
/**
- * Parse a device string.
- *
- * Verify that a bus is capable of handling the device passed
- * in argument. Store which bus will handle the device, its name
- * and the eventual device parameters.
- *
- * @param dev
- * The device declaration string.
- * @param da
- * The devargs structure holding the device information.
- *
- * @return
- * - 0 on success.
- * - Negative errno on error.
- */
-int
-rte_eal_devargs_parse(const char *dev,
- struct rte_devargs *da);
-
-/**
* Add a device to the user device list
*
* For PCI devices, the format of arguments string is "PCI_ADDR" or
diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
index 0f9e009b6..a118fb160 100644
--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
@@ -211,7 +211,6 @@ DPDK_17.08 {
EXPERIMENTAL {
global:
- rte_eal_devargs_parse;
rte_eal_hotplug_add;
rte_eal_hotplug_remove;
--
2.11.0 (Apple Git-81)
next prev parent reply other threads:[~2017-07-09 9:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 9:28 [dpdk-dev] [PATCH 0/2] devargs changes / deprecation notice Jan Blunck
2017-07-09 9:28 ` Jan Blunck [this message]
2017-07-09 10:28 ` [dpdk-dev] [PATCH 1/2] eal: internalize devargs parsing Thomas Monjalon
2017-07-09 10:46 ` Jan Blunck
2017-07-09 10:56 ` Jan Blunck
2017-07-09 11:23 ` Gaëtan Rivet
2017-07-09 9:28 ` [dpdk-dev] [PATCH 2/2] eal: deprecate 17.08 devargs API/ABI Jan Blunck
2017-07-09 12:25 ` Shreyansh Jain
2017-08-07 23:03 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170709092847.13339-2-jblunck@infradead.org \
--to=jblunck@infradead.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).