From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com [209.85.128.172]) by dpdk.org (Postfix) with ESMTP id 726825592 for ; Sun, 9 Jul 2017 14:19:38 +0200 (CEST) Received: by mail-wr0-f172.google.com with SMTP id 77so103410107wrb.1 for ; Sun, 09 Jul 2017 05:19:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=B8UmUoW4oTgMcHHjgRI3xmzo7LxdA72rd2N5ZaTe6Dw=; b=rIQbjU4Fas4iR2AGmvLYGMg7EcIjrmSrAG0fJTSgJd9zfF4JhWJuE303irrGhG2ycG 6cYJ/z5ZzJQy4Bqm/dOdy5oD9tLJFqaaBLerrlWHYflW+r8Z3Trq/Ji6IOjJ5qyLl1tg 5Mtx3QN15gv42hnCyx0bwzOLdXKHUOsxFe3bijQFrPRu4ngl/Px9s4+DKtck1RF9+a9H vf7TE64PXiz/xICiUxl+AyNSfUA1WEwywOBUbmi62mLDu/jeE0Z+hKjt97ecR3oeksE1 plYfJt2Dccu/qiqRrqipG+QKhBBrBmBNA1dkyV2dVKtoNo49zLUV+09EtKF4z7d9pEbf vFbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=B8UmUoW4oTgMcHHjgRI3xmzo7LxdA72rd2N5ZaTe6Dw=; b=r3u5qoyWX/8EDQ/qegg0kdbflV6FE8hRnyTArBTgKDZFzg5jkkPEd6HSlgWjICfN+x MKAcyJ2cZORr1OnIjXqvWO4ZYtbSyDh/8wB7L2uoJOGQapI3qwqZe890/FJ0UFM+H8SF ozCTelP8MqJesM6TZEU7duHFFIzPIfPa3vPfEbbgw8aQzDZ0GPk4WMjUYotcNOAlQa2R VDzyJNquxjBqK6Hx4qTtYHTwSmSnKazgyxF6zDUQUGsoGxPocd2X2JjbHhNiTDGkBfwN uOKLcx5gBLg71ffDpsX3WCkJsmPkf4/wiEwgb/L68sp4i1LjgSwR3hJQuKf2XAtYWTzG HLAg== X-Gm-Message-State: AIVw112Syl6jy1TxCEbYj3Vr4qYopTxvJP5TkAx9I7it/UhdEKwlaa84 YtBv5qgRGfS1t2cWLLw= X-Received: by 10.223.162.219 with SMTP id t27mr5208865wra.68.1499602777848; Sun, 09 Jul 2017 05:19:37 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id r70sm5602779wmb.16.2017.07.09.05.19.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 09 Jul 2017 05:19:37 -0700 (PDT) Date: Sun, 9 Jul 2017 14:19:28 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Jan Blunck Cc: dev , Shreyansh Jain , Stephen Hemminger , Bruce Richardson Message-ID: <20170709121928.GU11154@bidouze.vm.6wind.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 0/9] fix hotplug API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Jul 2017 12:19:38 -0000 On Sun, Jul 09, 2017 at 06:38:52AM -0400, Jan Blunck wrote: > On Sat, Jul 8, 2017 at 9:45 PM, Gaetan Rivet wrote: > > Sending those fixes as separate patches as they stand on their own. > > This series improves usability of the hotplug API and fixes a few issues > > with existing implementations. > > > > Interesting that you send this series as fixes. From what I can tell > this is a collection of changes that you have proposed before and I > have commented on and requested changes for. But I don't see that they > have been addressed at all: > The API changes are limited to two elements to make using this API easier. The rest are fixes: inserting relevant rte_devargs, fixing PCI hotplug, supporting the hotplug interface in vdev, releasing the relevant resources on remove. Those are bugs which make hotplug impossible to use right now, and this series aims to fix those. > - you still concatenate the bus and device name just to pass it down > to the buses and parse it into its components again I use the current API. This API has been discussed in other places and the reason to keep the current behavior, and how it should evolve shortly, has already been exposed. In the meantime, even if planified to evolve, the API should still be respected. I know you disagreed in the relevant thread[2], as you repeat it here. However, you received a response both from me and Bruce regarding this issue and did not press the matter further, which led to an implicit approval. > - you still delegate the devargs parsing to the buses > I agree that this should be avoided. The relevant API is clearly marked as going out shortly[3]. But this is not relevant to fixing the hotplug API. > Please fix this issues. If you really want to return a device handle > from the hotplug API please present the use-case and in which cases > this solves a real-world problem. > > Other solutions can be used instead, always. It just seems simpler to work with. I can do without it if that's a hangup. [2]: http://dpdk.org/ml/archives/dev/2017-June/069256.html [3]: http://dpdk.org/ml/archives/dev/2017-July/070505.html > > The hotplug API can be tested with the fail-safe PMD[1]. Its > > documentation describes how to declare slaves and how to use it. > > > > [1]: http://dpdk.org/ml/archives/dev/2017-July/070529.html > > > > Gaetan Rivet (9): > > eal: return device handle upon plugin > > eal: fix hotplug add > > devargs: introduce removal function > > eal: release devargs on device removal > > pci: use given name as generic name > > pci: fix generic driver pointer on probe error > > pci: fix hotplug operations > > vdev: implement plug operation > > bus: remove useless plug parameter > > > > lib/librte_eal/bsdapp/eal/eal_pci.c | 4 +- > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > > lib/librte_eal/common/eal_common_dev.c | 83 +++++++++++++++++++++---- > > lib/librte_eal/common/eal_common_devargs.c | 18 ++++++ > > lib/librte_eal/common/eal_common_pci.c | 49 +++++++-------- > > lib/librte_eal/common/eal_common_vdev.c | 12 ++-- > > lib/librte_eal/common/eal_private.h | 5 ++ > > lib/librte_eal/common/include/rte_bus.h | 6 +- > > lib/librte_eal/common/include/rte_dev.h | 10 +-- > > lib/librte_eal/common/include/rte_devargs.h | 18 ++++++ > > lib/librte_eal/common/include/rte_vdev.h | 7 +++ > > lib/librte_eal/linuxapp/eal/eal_pci.c | 4 +- > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + > > 13 files changed, 162 insertions(+), 56 deletions(-) > > > > -- > > 2.1.4 > > -- Gaëtan Rivet 6WIND