From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f173.google.com (mail-wr0-f173.google.com [209.85.128.173]) by dpdk.org (Postfix) with ESMTP id 84CEA5598 for ; Mon, 10 Jul 2017 09:43:26 +0200 (CEST) Received: by mail-wr0-f173.google.com with SMTP id r103so126773104wrb.0 for ; Mon, 10 Jul 2017 00:43:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uqICnYQkgrrSjS+38FOrzFPAL1BrMM5GCSjlbsaX4/A=; b=BqvkCk9J+pgDiefxlhmFEwrkK6afGkwf2bUw6LwiZ7k1y5+Fwdk8lTdDSmt41hpbw/ HUKkk/26fjm12P4KMm6E/zamtGoV4LrKuEoqENDD+BYjhMtsRZRP5T6YY8lbYb7CNcbf 9+dMsFMWPtSOx4QoyquuLYRfQPacYGX7KUNpBem7bZjSU17zBbmz3qhzTaJErgWwD739 iZnAsBocRS9eud6233PQYSxKMsYpIPYTSGQu+gcDlfyFJl4c9Ibc/DLLhnuhVMKuTnz7 Yu4iBzCaG/JArQbQeHVdIw2hrNXIf5oOdgd0p3uqx++wgAXiUZP6D+fWYHwZhfvpY+dH XeWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uqICnYQkgrrSjS+38FOrzFPAL1BrMM5GCSjlbsaX4/A=; b=b4NCJaDZhJZHFjJS7oKQ3VMlMCAtTg/gm/jXONv4uuewAH82iCKwNIYYJJC1/Dh+2H CifGfb/xHbdfpiRvvRlYzJW2bEHJeX6HjDC3JSPY6Fa9kN8AHH6RHtB+GZ4WglgfrVjx LsdhEyPfi1MqWq6jkGaxg23ZW1SRFEHYMvqYzgmOzFhXfoVYjN0KrYj3mERtqIJNJDVY PANYth5SeiWC3Dy1ZAorpuhGy9yMs+nGz7/xMs+eLOOg/LiRgP8Udz7RnIc3xS2W/Kdd QplbN8D7kZ2nC+S8Zec3ft5Mv0W5sMMFhkvArpB/3n6Zn3jG+WbalPqQJoB8/qUibp8w K+bA== X-Gm-Message-State: AIVw112mNZ1l1zTXRd5PCWcYYNNrnSCU2wzYhv2II2TWfqt+yoXYBjpT TyWkZzT+Klqk8/DF X-Received: by 10.28.154.19 with SMTP id c19mr6634661wme.87.1499672605911; Mon, 10 Jul 2017 00:43:25 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id p34sm14300288wrc.66.2017.07.10.00.43.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Jul 2017 00:43:25 -0700 (PDT) Date: Mon, 10 Jul 2017 09:43:17 +0200 From: Adrien Mazarguil To: Thomas Monjalon Cc: Cristian Dumitrescu , dev@dpdk.org, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, jasvinder.singh@intel.com, wenzhuo.lu@intel.com Message-ID: <20170710074317.GR19852@6wind.com> References: <1499182731-86830-1-git-send-email-cristian.dumitrescu@intel.com> <1838852.sCttUoyffy@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1838852.sCttUoyffy@xps> Subject: Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jul 2017 07:43:26 -0000 Hi Thomas, On Sun, Jul 09, 2017 at 10:01:31PM +0200, Thomas Monjalon wrote: > Hi, > > 04/07/2017 17:38, Cristian Dumitrescu: > > http://dpdk.org/git/next/dpdk-next-tm > > I'm sorry to not have considered this tree as a high priority. > I think it may be integrated in RC2 because it is a totally new area > and should not break any existing code. > > I prefer to wait because I have seen some things to fix: > > 1/ There is a compilation error with clang (notified in related thread). > > 2/ Some functions are exposed in the API to query the ops. > It seems dangerous and useless: > - rte_eth_dev_tm_ops_get > - rte_tm_ops_get > > 3/ The PMD interface file is referenced in the doxygen index: > + [rte_tm_driver] (@ref rte_tm_driver.h), > I see that rte_flow_driver.h is also referenced but it seems a mistake. Why? It was done on purpose, I think exposing through Doxygen internal APIs implemented by drivers must be a requirement, even if the exposed symbols are not necessarily versioned. -- Adrien Mazarguil 6WIND