From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0071.outbound.protection.outlook.com [104.47.33.71]) by dpdk.org (Postfix) with ESMTP id 2396E5A6A for ; Mon, 10 Jul 2017 12:42:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=m1AppMOggTag53mAbJqnpzpr2LF4l3K07XYPmDato88=; b=N4UkrGlyIgEU8hSTT7/q58gv8OpwIgKcbtKeE0gzpNVKPrigVjLFuzm394t9wYsQxsYnqnagx5ip7Egtb4FawcD3AQMeiurYvahMdt5JjLMkvMz45Ruoe+GgWWpuGniiVDODPJNmL7NZ6tB9bYQPRH/HP48jOdy84DcvPvVv0Aw= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (14.140.2.178) by CY4PR07MB3061.namprd07.prod.outlook.com (10.172.116.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1240.13; Mon, 10 Jul 2017 10:42:50 +0000 Date: Mon, 10 Jul 2017 16:12:30 +0530 From: Shijith Thotton To: "Tan, Jianfeng" Cc: "dev@dpdk.org" , "Yigit, Ferruh" , Gregory Etelson , Thomas Monjalon , Stephen Hemminger , "Lu, Wenzhuo" Message-ID: <20170710104229.GA6580@localhost.localdomain> References: <1497260285-27536-1-git-send-email-shijith.thotton@caviumnetworks.com> <1499426031-2664-1-git-send-email-shijith.thotton@caviumnetworks.com> <20170710071048.GA5231@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: BMXPR01CA0024.INDPRD01.PROD.OUTLOOK.COM (10.174.214.162) To CY4PR07MB3061.namprd07.prod.outlook.com (10.172.116.142) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1e8a46fa-859d-4e0a-a20a-08d4c7806a91 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY4PR07MB3061; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3061; 3:tn7EeZ/uclHy7dB52TD+vrLxRzt/70z8DJfV5eYR8JPIWy1BbrIS1otijkXMS9Tc/whUrSNOykXKVBIk9pGlBfz+Cc3nhqN0Vtj91tCkPRp85UG4JyFqZkQJ2L5fGQOxY9AyNkzATGpQ6Zd9RHAHva8feN5gtZ3ug8fKnlvds/4Bh0t3EuP8Qed1twJCamdEJIY/ndcn8OZq/y/L9JS1WBg+NFUCkfgQsbADp9fqVNM32NvIEFiJybqdUQFNnZ0OpAgTdGKrEnS/N0rXpUbcgMgDc2jz+CUMWy2s45zECS7up5TsdOTvklQWtu81TyPA5FtPheNps3hpF0x9xstYcFBWB7LgwvrY6bSQnqmWiuzCN2E02n+uKxtnXLrdQOYyWkV3A5Ey0Sfypnh3xNffcUhW4ZFxCE+NbNkLkDFfmGJAvqrwXEiyJG8nXj2CbfndeJCtm+XrRMx2DgWemWDYSg8A40M1tP6RszWgwtTovjX0Tung43PtcfdyOpkbGBdGmXxWhVToCn9vh3gOeCPgVrZxYdO+awzpclQZn16V8NYhoGywX8v9JThPnY1jqM3VjAui+LAdyhF5LHhJXgaQb+tnJm7StZWTL5vxJgTm4ICKxXpCyKnHBVdSCipjinOYO6ELaiqvg3EvxDHJ9zB+2Wy2DK7B1MyhSU3+kOJeWMNMQmPqdEkA5kOKcLFTvEaoVdDWjqNLDJ3eMYoMJRViK99a9cUhARxoVTFupjRL59Q= X-MS-TrafficTypeDiagnostic: CY4PR07MB3061: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3061; 25:SWrKn9x6Qjsl3agY32xZPNoqwpNkVOOnmgi4gVYxP/qbtLvPA4NVRUGKsfh9/TBPF8mp2uN5iyjWSUnksmXVOnMakzj7VHH3xDhb9sf6I2q11zea21nBPitk5WQ1x4WdK0Nt0BENqAeX+R0aEHfWCZqV9+MHJBwR+GiqMmpQXYxYCS5DEivbhoUpTuwFk/O4nLX1SFa7pK38HYJXWsSjFeiDijY/+ClPjDBEcbwRuUV722tXpHSCJK7rcWn0a3kj4iy00hmH29//tRf4+QF1HptnVbHwzDfqkCRUyrzpo5eU9SGP+qAcLp8kuNzZHQNm+oP9IZlFssqMwsZn6epzpkx4+FO2rDEwWVzUsfovIEve8RvcizNhbGqXDw4se+tf/s2ufccJrWGqBbfh/UnKCWMfyluOxNLKn8mfFULErcFZNLYeii2obZCUpRFImscp37tG21mEtgpvgPACT/SxsoDTSQlZXzzFJBNN8qOL0sArtMHIjvUx4lilKIoBLJK7v+H7PGZTJHTSwFIsf5bOg2HbBTHoe1R+FwOowXdsiWBWdv8/3usiZZnvvRVsXwm4OFmWi6q4tuw8UvEiSGBhjMeeT/EtHm5hMsFJD7Rmi0/OKKf4S5Tf08nAvjTJIQe+6faDeYgaTw6YdJgu/6FKz4bKR0noTjZl6YwNG/FNaeAp3fE2n/r7NOR7VUdUj3OVxW+lEYg1AQn4PX6pziiBDgSUiCIqhQPCoeXDd9tsnU6qMqNDND9Qnjb5CV75Tz9vihmmJZToXj0AuF503i5Jgz5Rq1ylsoz+rwcbehkqCgXpTz7TtCiqAWcjj2jUZf8YlvWkyZy0Mg3DQELnLghQj74zMBw4bV6RzHf3iC+/zseBb9euf9C5UbNm+KxgFKr24tkjCmoI1iNkLXb4TwIMwIrM5HjlKeO3hnyqwHB75t0= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3061; 31:cJhqTD/8FdOYMIsOFR/SBMWLSiDHB2eNkuN6ZkjlpKY+DCRvvaPr+CgloPTOsZVFAqs6PICpG2JdDf2nI2SLZsj9qo5wzcDKTMHuAhG+Bz9XfA+GcwfPHqKZEFiAXg2oiyce5Y7MbsaFm6HSaJywG7wjVdBqFmOloxb92wEmGnfhXgsCSatIpliQykWSH4Iq7tvD8GEDzx42QppLEq8afaEy3cgQHi4nUqa6gIhGmCvWYjr4630z5ABHs0LREPBnpnWzXgepU63UvwS1CIzJrRTI/wFE2QNBlPVLWs1bzYNQv7IF7UjVWzorZKNTrpYysPYTafvqpc3gB8HydNvQXRcXqSyA7gtnR65kGV2alpKJJgQ2Qy9SIIKmmeSLaeADoKuEyDrBxrgxXbtqO3OIMkA/0MIPBHhKDVLwHQDEz+cagmRk3NK9NzDdlRvMkl0AUBYLNkmbIzvYpMgrv8CnWgfV1g87gImDek2tVgAFSgbFm0eSHHYNskkjW6SKIuhIDx0OU6IPvept6grpQGNLX03L6qiixkGfantdGAlhM3v/8pnQuJXYBi3R8gKPEnO3eDdcKcBpOZqKVWBdX9k18BFDH/olra+c7OcvX9UKeP9UYfrlBmHgjxEzEP4HnZLnbuJm7i6KGp0R+l00WQzHyvWka9bcs37C1MD9bPpVHgqzGrRBu/IIKESZHxzIiKlzuQUy1M9KK/9LFHr/OjtpVg== X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3061; 20:bA965CPL942mricUIfSLr8k8vIyONhGsGDZCjmw/+WVi5nS/0FpIPJ7aDtgHPbEg9TApwG8Sb6UU7jQQTF5DWxK0pX22EmnZjPdYwqw6S3FKC3Ww8QtBhSQ7l0KCf+zH55llL85ViMu6v0oTG6VUAec561BO/0U0fBBDSrAhbM4fB+BTe/rYCdGR9tk5QYWT/0Td7ESoT4NL1u+q2RVpCzN+CpY/lQUrg1ybHgDODLPkMvvJ9pXxxgp4Lv5pz+Wg4RCR20rIBwCR8FygUyo0/I+fC7dDGLqoMtvjOv91EcdSvZgC9H09FOm8i08Zb1NseJzEorgmz1RXBGg+VaLONWXU5P4LqGiD0SrHgueoeG0EnLXZoD7JjQWcI3H0gTWLvyh0liHCeuYrl8mm2DZypuQ1VD2ok2x9igG+RLWOouJsVx3RfGfegm7a2biOHfHYshJaGmiiT0S3KY2qyvlLtN0BB89Ryuh97bujOOAgSPvDhEzhUIVFtc9Oqu+Vp5MKrT5z/fLR3rjwpTMCoON4PIhxd2QKNhpPCynrOQQQidDsOcgcMkvvSlwTH4E6qIOjvPWjYs9dHFmDXyeJHzAtBCM5AUcYQWGxpc8hMXvk6H8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(236129657087228)(247924648384137)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(2017060910075)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(93006095)(10201501046)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR07MB3061; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR07MB3061; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3061; 4:UIHisYKnD0ANmC6ePSNTqcdy0d1OvP8L7Qwk0iws4y?= =?us-ascii?Q?wdyGUZOsyH5Y/L617ADSUSBveoVHV4l1v3f03175F+eRTHIDC9GlfylH52wn?= =?us-ascii?Q?FYtxVXvw5looUD7uUqNZnUilZ9ODgRo9ZjAEq51K64OH6+QMudVzB1vozNQP?= =?us-ascii?Q?pHWwFNGOYXeRDjqYn7WFaRxu01VbT32rI9JSVfo1VPyKg30lSbIK0EdADTeg?= =?us-ascii?Q?Si93Bi0fGRmJ+h9/3k43xyscIXPEdzZvHeLtWBXWGH50KnLJs1GjB15xdZF0?= =?us-ascii?Q?6YmlM6xC4HL8R7IjFnFCvVbyNekDURmCPUk+nGQ8KjeTel8Fq1KYQS0avpif?= =?us-ascii?Q?NsEGs7GVXsqMlJjy56FWFPuJu8km4ZTiEUOeVF2HDlxuZ6Sg/o6lqZHDJHkL?= =?us-ascii?Q?id3q5gQXdOJfClp7YMpfRkaCFQ2xwwaUNEB+crILyW9w9y8tWmu/ymEiCquL?= =?us-ascii?Q?VJSpc1xVLbPnMndW1GHodlR/HVq1n0Zew+sHmQ1d/o1dzTYxJTBY+04x/0Xn?= =?us-ascii?Q?vBYGlWoXTizuJknnUvRDwsAh9SNx734JfLuhoSA5oUZ31Qs4pmyUyfRdrUjY?= =?us-ascii?Q?Qo0vg1fHkmswUcQByDkxZ0wS+Y9nKmwKQCXIWIFir59WrfhFcZn58jFIa7vR?= =?us-ascii?Q?XIf5sY/h+M0dwspotFKInc5WI9CwoeNx+2UO6IdJw24Mw9XI5bRr2Qeet+Ax?= =?us-ascii?Q?4SDjSyHsATrCnxp8cgNnjG2pb/+X9pcZsudQXUGDw6F9Zti2iaAhc5IdMyvT?= =?us-ascii?Q?wtlrKhr5U/+Zx/tpXJCUMON/WKHdQXXjIkEm8FR12zf54k/PdqieSCFvFfEd?= =?us-ascii?Q?T8MmIp97DYU1Y/zQVQ0tv6d5kZQUv1JZG+x+YTerZCd2tBtzGpP3BPtaJaAG?= =?us-ascii?Q?jMHexVteO5PseqHrBiH5JI2hJaQE+yv5UFTx6q9JJ/pF4hSCyqkIrbRCkJKB?= =?us-ascii?Q?JaGochdkYH82b09xYsVntqcoz7euduu0fTVa6sACPGfDfkxuVFI4S2fzTTbr?= =?us-ascii?Q?UqUgRdMBF+ygpUDfpYVbG3egNRPLZsYYD9sSuGkxjUgppsOnVtvh9xi/dUhA?= =?us-ascii?Q?tTOTs4om1gm75qO4XmiR0IiKo1jSN2wbZWBZJx5G0XbX3c/upFz4P0BV52sa?= =?us-ascii?Q?hPUZXR0boSJCoDsEyR0oP/IesjoMCE6VF4B9ipfyTXEg3GvqsOGp2CbWb1os?= =?us-ascii?Q?N/e+Jq3YxcKDYdBPV499Nwm4TAi0dALb0ihVnkx97DOgRqeiG4pAxTuLVSyV?= =?us-ascii?Q?+XD4xqGXVrUkY3JmpSCZ553rGFeSLlKb6wrUFc?= X-Forefront-PRVS: 03648EFF89 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6009001)(6069001)(39450400003)(39840400002)(39400400002)(39410400002)(43544003)(24454002)(377454003)(13464003)(6246003)(1076002)(38730400002)(53376002)(110136004)(54356999)(53936002)(9686003)(25786009)(6916009)(42882006)(2906002)(6666003)(2950100002)(47776003)(4326008)(189998001)(81166006)(66066001)(8676002)(93886004)(305945005)(76176999)(50986999)(7736002)(229853002)(50466002)(83506001)(4001350100001)(72206003)(966005)(61506002)(5660300001)(42186005)(5009440100003)(6116002)(6506006)(23726003)(55016002)(54906002)(6306002)(33656002)(7350300001)(3846002)(53546010)(478600001)(110426004)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3061; H:localhost.localdomain; FPR:; SPF:None; MLV:nov; PTR:InfoNoRecords; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3061; 23:EvALNxpjs9B+SKxuAyCZ03Sb87MGgwCXcWpkxlY6p?= =?us-ascii?Q?a2iOyGGRtfGwdRmYFwjwZd7ZkeqQVSLOZwmg6hcJofCriVnUOghy4AtGe2HC?= =?us-ascii?Q?z31SLDCrsg1LQPfxVwFBp8fGcQQ8UZZW1A2HfCcIB+FF+wfAN13OVIHzBUlf?= =?us-ascii?Q?Tw/gtAnFPagC+R+8RpsM86y7CpuHt9E9O14f2wYa733tbtLTsbvTN03y625r?= =?us-ascii?Q?Bbydz9FUSkG6Z4JJhonNgZQ31M19QjRZ7XsjrqVNf6/LK7Er3eoEYINp7uY2?= =?us-ascii?Q?i9MKXRRK9I40DRS8KZ9pKB2mORnEKIq85NvnF4ge/qhNigUWJ62Nij6Ue1TB?= =?us-ascii?Q?xyH2u68u0/KkNRo8RPirkjqa5rvWErOtdeN6mw2vyH4lNs7XPdZ9Me/GyPCr?= =?us-ascii?Q?M/rGnCoO06RJiyu4dQYov9gByoxwbHAN+9DVewb2P/PbsfFTE3m0XF08iFfX?= =?us-ascii?Q?Ha5XW/nAmcJXu5NyJkkvX9XQ8r0ezF6dXTbRFheUXDH59ZMy3RuCqQG0MwOf?= =?us-ascii?Q?SREtVQsatwHSDOSFpDLq9opHnhrE7MAyWUG0yHw9vFc5BOwqbMqKIYpHt08u?= =?us-ascii?Q?jA/kReZ/GypxHdzo7m84L7GvYUrDoFUg7FNmqbCwHNnlnZbmu5DHZuBUt3lN?= =?us-ascii?Q?KC3VJew6jstafsi4kg0YYfxLpIT/v7vyBvBOvFZZ6ZhD1ZRGutVqPkL/M6XO?= =?us-ascii?Q?4klO0cZdRtTpl/pJzTbTnJXvSjJ5E3SaxlsUhEvbTNDqG8O5LO2q/0KRgC2E?= =?us-ascii?Q?vxTzuFEXdZulv5mX2egI/41UBt3xEy5EEF4bz6ITtLfPbE1Z08BuYxupO41x?= =?us-ascii?Q?WSe42Sb0SnPUfdBbv+ecUVmhE7xrOP4FRhDsmt5wMAEV7vmSGTtEI1QagJnB?= =?us-ascii?Q?0GtJQ/rnwfiG5juEhg13Aq5kve3Hn/B7qkcYE++miojBe17n6q3H8QO/4gn5?= =?us-ascii?Q?2iWjca01eNlHOI0kB+6uS0bRJMhlE1VkM4hO5ubfRbUF3SQiE/VLIS15MO1v?= =?us-ascii?Q?ZsCIDW1UEI+1yWpgLYXT+kEhvzmIXvt47Yn3qnmZtxxJteRdpW70NLZB30Y8?= =?us-ascii?Q?bhKH9Hnynhmc/bxAg9wJ4MtjlEwns5wpA1qo/2jqAsEVpSe7VBCbMEBwrIT7?= =?us-ascii?Q?+eBDNZUtsTIDE06Ef2smnCS9UpIZFgpsYRi/ZGEdYLbbOAdrXjZlAhatnTnB?= =?us-ascii?Q?D5InSr4d8z124qf+ePiLbyXr7+9PnXfq77BFOWLXrvs+vxKXcx2Qgwwh6UYK?= =?us-ascii?Q?pmZsZCrvQGlt3jXIDyMjtu5pYkpbzGNNLV4wHzXGIUaJEatOYocMzKd3x+aN?= =?us-ascii?Q?hhln3j9D1a3nYC9dXIX53ZufJEOohGu8aOASai7hAUJI450NP++vzMTPPfoV?= =?us-ascii?Q?f3GJAJglxIh+VeT8pek351KyVFpM+g+fSLuST9tdhaTN2ef18HJZAyNR5dnm?= =?us-ascii?Q?jsGFbDnx6f0rOuylYTJSutWTEqKdu+GWuoLi4DACrRhW1Xyfl2Z?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3061; 6:y1mSQJYHNPStuLlIJIB5hEfs9HVEm36ECUijvCDfUI?= =?us-ascii?Q?PIhRbjttpn8TDLhmw9orOsDwQEEs7JzO5ifm5l0lUv8wA0ysF5y74DN4T7BG?= =?us-ascii?Q?Yr7PuUBX0Ft6wcslTLiwqoJkSjL587+7/4VEU1WA5dm5K/i2LTqZDjf+9VbG?= =?us-ascii?Q?2ozYBI2vTXqx0R6oz5KVdPAplt+PvzdHCXz5tn5k7CQ56HI52sjRACfAdjry?= =?us-ascii?Q?kGih6wL8nXx6Q+LFetpwu3KDFQnMC1pGgShzOnkyDGJh+IkutqdGhP2UMSRq?= =?us-ascii?Q?ixhmIYyq2b7m5Kxqf1YiE6a5m5yXkpbNjZ0NwFPS608l6x1Ad9by9l2dHov1?= =?us-ascii?Q?anlSEvXOUtfHdufN8eYm6ERg5ecWMCMz3uwBbmH8vT35fabGIsS7E2xXU+1H?= =?us-ascii?Q?KCHFFCYtnVyTyGeEeyRqRSByVLxOfuaeSzyvxyQTDA78MY+eSjbdVC0LD8SN?= =?us-ascii?Q?ipKdrdMnv2M9nXqDRKCX1GhKA5iaVC0IBZtn5RFlt7Wd6YT6yhyk1x3DQCi6?= =?us-ascii?Q?VRqaMbd5T45f4U4N+LVtDmP/shLhAu6J8iAXoxmmyNk5wlA36QFoQz/mbUKZ?= =?us-ascii?Q?3QoAMqIo2X6JTOoHF0JgaUqYGcmj50X4MAZi1v08GlMgbDUqOnPNSNHESSoz?= =?us-ascii?Q?0i596/p5+DmsZiRa3KiSyUi9D+yaYO83jKU0lIdRV3YOsq1P2fHCTANAVxf3?= =?us-ascii?Q?577T9j+8gnzykoHIKTC8WT6M88fztYHVBDJNwh2tLnUbhDdgTg1gcnEPCNY6?= =?us-ascii?Q?Rd2pEYzNDlO1/wZA6bnhqGD6kFHkb7Ck+7Olql6D0AItGIXWajMHfCLmyIDk?= =?us-ascii?Q?TMicxrwmIEuDzO7uZAG/sV/SY16d4bJTdsFJGPSzmO0LWwxVSK0siPBkOJEi?= =?us-ascii?Q?p34QzroOvdoomfnV1HnwSKxwsyujms/X1M3IJZ+qGDqNEgDrBRsbf8YtzczE?= =?us-ascii?Q?4oshpfYlgVsm6kig0g9EjT+ci/FkL88A4bG02m5CxqOwTME4UeO5W7GtXN7u?= =?us-ascii?Q?U=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3061; 5:sgb7AAcLfXuMbHT5Gnq+MNJHDuxJrS2MSFpmBF4QkiP9NKkgLb9BSTIC47OJtmlQ/6pGIMOgXLy7+Rr3W+TwHvYzlYr8BYo7aZU5vkoUQYTwvxtcTkojOpnkWpWq2qp1jiFJYossqltiYlI0++kmOwpMI73pVXDzHkmj+uhFb21K8c/tzyCKYAzhS7seQON9vcL1D7t9KNymXRbnU6yZOAAqg0yZePRA+3m0vhpYYXGk4jEj3XVzc94Ah+J6hw/n2LD0cYQhQaiLF893cHxjRsrMLcx4CWYchMe1sJ7rfvF1eLFSCdL+0Fk5oypIr+yB5R62dSUHgY3oyr4T62dfXXyaYqndOYwkUnjT7hgcyvGV0j56Eip4V5ROP+qnDzZ8gpxg8qMoMDYrt0Y65n3xNSqGGNPAXGPARU0teuTAYh0PAvyEmox3apc6t5zX7cj+4RXNXgGAs+BS2UbDaoASYCHzq7hU7aTo94xmgh6Ym/2I0mXB7gn63E5F5dMgGCHe; 24:ZVFLVhs/xDc7VZOuMMN9Z6uqtMzLeKJGMLq8Cl6zHf0GcdyvR6a2wW/094vip0e+sFQ9UHYrQKHU3Y/7cu40pALOjap/h69SE3oZS90Haig= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3061; 7:jT0ugpJ9S1P42/HoJe1pAyt1RQqsHawA3W4F/Spj8Az7BbLWozD4b/tAGTiGy/1mMSZ5STURd+Z93/G9c8EMXhIC9DoLUPBzZxLEv/h2A3EELHcio9zCOFpsV1i71oCMWcsPNf+lVn4IsbJPyqF/eV/eIprmumclbiN5qQ990Qeo64VQFxxCQmhkZNpwlMLHs8tK6vZ9Rm2lc/atP8TB0TcVdjNVFbBa5Qor5TzmmVcy1D+jqbAy5BdFT5AejpwnuU0MUlhXdOB6IM6Zcf23/ABRh4IM/gVEOxY4uIbd+/TiUJiOa8Z691GxNuZuOS9/E6xUWACmmj8XcStcI1TgiurdX2BlMvf344TSscU8bGTqxKjVjJ0tr36yP2gkjAjh7IqiwfY5v/y/VHQnn1iV66kdJDRo33XruhdnUC6hK+LEaiJcL1FNN2F17yd2B8/v4p8YvaeerTHyvz+vXTTbryESe07cA0cKTuJDbCAwd7anOMiRTmG/t+sptH9luLUImxzsdRP0fJlG13x611DVeN5hdcSsnTSEVe/39GDDGFCh8ifroYcNDJZY6UHQNW/VxyQJMICSOUwBgfCOmW4fl2D5EcltHeQadek6mYKAMqBBUD+0RDMcfKouWFK/clWv/1jDJbAMk6cfMyreg1wE6u2MjIbo6snX3LoUqYGZhFiSdiPc/s6KcLn3QUOuA0AV9lDq2kfBXrgHkwS1TzctGnGiJ+0xGTmKeGkbrjIB/72EFL1Ow7OUq4Xd6QRCP7LR7w1brlMP1SnvDkotuUynFGLGMOmHK1Zg1hIVlGtvc7k= X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2017 10:42:50.0159 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3061 Subject: Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jul 2017 10:42:55 -0000 On Mon, Jul 10, 2017 at 09:00:38AM +0000, Tan, Jianfeng wrote: > > > > -----Original Message----- > > From: Shijith Thotton [mailto:shijith.thotton@caviumnetworks.com] > > Sent: Monday, July 10, 2017 3:11 PM > > To: Tan, Jianfeng > > Cc: dev@dpdk.org; Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; > > Stephen Hemminger; Lu, Wenzhuo > > Subject: Re: [PATCH v2] igb_uio: issue FLR during open and release of device > > file > > > > On Mon, Jul 10, 2017 at 03:38:34AM +0000, Tan, Jianfeng wrote: > > > Hi Thotton, > > > > > > > -----Original Message----- > > > > From: Shijith Thotton [mailto:shijith.thotton@caviumnetworks.com] > > > > Sent: Friday, July 7, 2017 7:14 PM > > > > To: dev@dpdk.org > > > > Cc: Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; Stephen > > Hemminger; > > > > Tan, Jianfeng; Lu, Wenzhuo > > > > Subject: [PATCH v2] igb_uio: issue FLR during open and release of device > > file > > > > > > > > Set UIO info device file operations open and release. Call pci reset > > > > function inside open and release to clear device state at start and end. > > > > Copied this behaviour from vfio_pci kernel module code. With this patch, > > > > it is not mandatory to issue FLR by PMD's during init and close. > > > > > > I'm afraid this will not work for restarted DPDK process. In current probe(), > > we set up the I/O mem and I/O port; and those sys files are used by EAL > > IGB_UIO initialization code to map I/O mem and port. After reset in release(), > > we will lose those sys files in next open(). > > > > > > Thanks, > > > Jianfeng > > > > > > > > > > > Bus master enable and disable are added in open and release > > respectively > > > > to take care of device DMA. > > > > > > > > Signed-off-by: Shijith Thotton > > > > --- > > > > v2 changes: > > > > - Replaced pci_try_reset_function with pci_reset_function as it is not > > > > available in older kernel versions. > > > > > > > > v1 changes: > > > > - Added pci set master inside open and clear master inside release. > > > > - Remove obvious comments. > > > > > > > > RFC: http://dpdk.org/ml/archives/dev/2017-May/066917.html > > > > > > > > lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 33 > > > > +++++++++++++++++++++++++++++++ > > > > 1 file changed, 33 insertions(+) > > > > > > > > diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > > > > b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > > > > index b9d427c..07a19a3 100644 > > > > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > > > > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > > > > @@ -170,6 +170,37 @@ struct rte_uio_pci_dev { > > > > return IRQ_HANDLED; > > > > } > > > > > > > > +/** > > > > + * This gets called while opening uio device file. > > > > + */ > > > > +static int > > > > +igbuio_pci_open(struct uio_info *info, struct inode *inode) > > > > +{ > > > > + struct rte_uio_pci_dev *udev = info->priv; > > > > + struct pci_dev *dev = udev->pdev; > > > > + > > > > + pci_reset_function(dev); > > > > + > > > > + /* set bus master, which was cleared by the reset function */ > > > > + pci_set_master(dev); > > > > + > > > > + return 0; > > > > +} > > > > + > > > > +static int > > > > +igbuio_pci_release(struct uio_info *info, struct inode *inode) > > > > +{ > > > > + struct rte_uio_pci_dev *udev = info->priv; > > > > + struct pci_dev *dev = udev->pdev; > > > > + > > > > + /* stop the device from further DMA */ > > > > + pci_clear_master(dev); > > > > + > > > > + pci_reset_function(dev); > > > > + > > > > + return 0; > > > > +} > > > > + > > > > #ifdef CONFIG_XEN_DOM0 > > > > static int > > > > igbuio_dom0_mmap_phys(struct uio_info *info, struct vm_area_struct > > > > *vma) > > > > @@ -372,6 +403,8 @@ struct rte_uio_pci_dev { > > > > udev->info.version = "0.1"; > > > > udev->info.handler = igbuio_pci_irqhandler; > > > > udev->info.irqcontrol = igbuio_pci_irqcontrol; > > > > + udev->info.open = igbuio_pci_open; > > > > + udev->info.release = igbuio_pci_release; > > > > #ifdef CONFIG_XEN_DOM0 > > > > /* check if the driver run on Xen Dom0 */ > > > > if (xen_initial_domain()) > > > > -- > > > > 1.8.3.1 > > > > > > > Hi Jianfeng, > > > > I have tested the patch with LiquidIO VFs in VM using testpmd and could not > > see > > any issue over multiple runs. > > I got that, you are using pci_reset_function() instead of pci_disable_device (the function I was trying). So only one question left, from the comment of pci_reset_function(), it "saves and restores device state over the reset", then is __pci_reset_function() is more proper here? Per comments of __pci_reset_function: * Resetting the device will make the contents of PCI configuration space * random, so any caller of this must be prepared to reinitialise the * device including MSI, bus mastering, BARs, decoding IO and memory spaces, * etc. So thought, pci_reset_function would be proper as it saves and restores state. Please correct if I assumed it wrong. Shijith