DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] pci: fix level of scan debug log on BSD
@ 2017-07-11 17:10 Thomas Monjalon
  2017-08-03 10:16 ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2017-07-11 17:10 UTC (permalink / raw)
  To: dev

Printing the number of scanned devices should be a debug log,
not an error.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c
index e321461d8..9335247d8 100644
--- a/lib/librte_eal/bsdapp/eal/eal_pci.c
+++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
@@ -396,7 +396,7 @@ rte_pci_scan(void)
 
 	close(fd);
 
-	RTE_LOG(ERR, EAL, "PCI scan found %u devices\n", dev_count);
+	RTE_LOG(DEBUG, EAL, "PCI scan found %u devices\n", dev_count);
 	return 0;
 
 error:
-- 
2.13.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] pci: fix level of scan debug log on BSD
  2017-07-11 17:10 [dpdk-dev] [PATCH] pci: fix level of scan debug log on BSD Thomas Monjalon
@ 2017-08-03 10:16 ` Bruce Richardson
  2017-08-03 15:36   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2017-08-03 10:16 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

On Tue, Jul 11, 2017 at 07:10:46PM +0200, Thomas Monjalon wrote:
> Printing the number of scanned devices should be a debug log,
> not an error.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c
> index e321461d8..9335247d8 100644
> --- a/lib/librte_eal/bsdapp/eal/eal_pci.c
> +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
> @@ -396,7 +396,7 @@ rte_pci_scan(void)
>  
>  	close(fd);
>  
> -	RTE_LOG(ERR, EAL, "PCI scan found %u devices\n", dev_count);
> +	RTE_LOG(DEBUG, EAL, "PCI scan found %u devices\n", dev_count);
>  	return 0;
>  
would have gone for INFO level myself, but DEBUG works too - it's
definitely not an error.
The commit title also reads a bit strange to me. How about e.g.:
"pci: log fix level of PCI scan summary message on BSD"

Otherwise:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] pci: fix level of scan debug log on BSD
  2017-08-03 10:16 ` Bruce Richardson
@ 2017-08-03 15:36   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-08-03 15:36 UTC (permalink / raw)
  To: Bruce Richardson; +Cc: dev

03/08/2017 12:16, Bruce Richardson:
> On Tue, Jul 11, 2017 at 07:10:46PM +0200, Thomas Monjalon wrote:
> > Printing the number of scanned devices should be a debug log,
> > not an error.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
[...]
> > -	RTE_LOG(ERR, EAL, "PCI scan found %u devices\n", dev_count);
> > +	RTE_LOG(DEBUG, EAL, "PCI scan found %u devices\n", dev_count);
> >  	return 0;
> >  
> would have gone for INFO level myself, but DEBUG works too - it's
> definitely not an error.
> The commit title also reads a bit strange to me. How about e.g.:
> "pci: log fix level of PCI scan summary message on BSD"
> 
> Otherwise:
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-08-03 15:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-11 17:10 [dpdk-dev] [PATCH] pci: fix level of scan debug log on BSD Thomas Monjalon
2017-08-03 10:16 ` Bruce Richardson
2017-08-03 15:36   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).