From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id 5628B2E83 for ; Wed, 12 Jul 2017 19:20:28 +0200 (CEST) Received: by mail-wr0-f171.google.com with SMTP id c11so41336547wrc.3 for ; Wed, 12 Jul 2017 10:20:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=tW3mIkgcPvioycn7cB30YXVIme3JYB+eq2293myCGRI=; b=wfTAJfiVssvG4v722Fdzph+TMnHSp7PMZCECJZdg9Imr3xPVhYrD/vQqmt82L3zRFn 0lLB5rf7og8W0tWcayK0CRSCO43ZM3tamRkHxiylU2H8rmfnobkkZIoYIQPH0oyojlhH u5P5T8u3iIgxbX2ky/QXrg4ezMieoU2ZZ5oizS42ogjP91VyAaVu+LiHfAO6jPUvF97m 7crg7v1yBPY6610t2uj0cUeI8kswbcQVDM4vODjRtwxtWpiUNNFAIVpeac/FJIslC3HZ U6movE6uN0w2zFxlHecddCHsbThH9T07taxsSfQ38hGwJFjgt9UiD8RAX8xxJBrbrpYm 8PxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=tW3mIkgcPvioycn7cB30YXVIme3JYB+eq2293myCGRI=; b=tujrAdExgsnM1FSdaJ3vu5y+LVBzKu0aHA4rgii5J7T6JshsKB3nwXyDOgMv41ct9J qQi85p+D6VTpf5FMkaczO0Nmlk5rKbMHgZ3/TRqNEp8WqDQ5qqdeeEa0wj/QxBHKlG+K xJtzsA32bbkC0l2Pa3cpdO4kvmhSBbIDa14NJrl5SE+tZ0gyxNFK7rkbywtmb7pMBiSv gkq2vBeeqfJyzwpVCfD0+Pe3iyKBp+lJrI8HBsdH2olU/6dgyb8iOLEbWIUTDI0pC8xK E6EXMXhW85J8j9UXligTh2TkSp4jML1XUchhWprlzklfGgUVskf8ILoRS8wvtaP1gruV YPjw== X-Gm-Message-State: AIVw1119gYZqNHA3r5u/cTjbe7YvcM4L3PSF2ZfBWhUWf4ejVneHgmSf ZFv6nHKG7mT9mllv X-Received: by 10.223.154.141 with SMTP id a13mr3784442wrc.139.1499880027819; Wed, 12 Jul 2017 10:20:27 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id w96sm2727655wrc.33.2017.07.12.10.20.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jul 2017 10:20:26 -0700 (PDT) Date: Wed, 12 Jul 2017 19:20:18 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Jan Blunck Cc: dev Message-ID: <20170712172018.GD11154@bidouze.vm.6wind.com> References: <9885513c0b9107505bc8c61a40a1236533e9b7b4.1499814957.git.gaetan.rivet@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 3/8] devargs: introduce insert function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jul 2017 17:20:28 -0000 On Wed, Jul 12, 2017 at 04:20:48AM -0400, Jan Blunck wrote: > On Tue, Jul 11, 2017 at 7:25 PM, Gaetan Rivet wrote: > > Some buses will operate either in whitelist or blacklist mode. > > This mode is currently passed down by the rte_eal_devargs_add function > > with the devtype argument. > > > > When inserting devices using the hotplug API, the implicit assumption is > > that this device is being whitelisted, meaning that it is explicitly > > requested by the application to be used. This can conflict with the > > initial bus configuration. > > Actually I don't think that this is correct. If I blacklist a device > via devargs I don't want this to be probed in case my udev helper is > calling hotplug add. > This would be good for a udev handler yes. But should we expect this behavior from all potential hotplug initiators? To put it another way: should this rule be enforced at the EAL level or from those using it? And is it impossible to imagine a system that would actually need to be able to update a device, changing it from blacklisted to whitelisted on some specific condition? The fail-safe at least makes use of this ability. This is at the moment the only hotplug user. > Maybe it is better to just update the args field in case the devargs > instance is already found. > > > > > While the rte_eal_devargs_add API is being deprecated soon, it cannot > > be modified at the moment to accomodate this situation. > > As such, this new experimental API offers a bare interface for inserting > > rte_devargs without directly manipulating the global rte_devargs list. > > > > This new function expects a fully-formed rte_devargs, previously parsed > > and allocated. > > > > It does not check whether the new rte_devargs is compatible with current > > bus configuration, but will replace any eventual existing one for the same > > device, allowing the hotplug operation to proceed. i.e. a previously > > blacklisted device can be redefined as being whitelisted. > > > > Signed-off-by: Gaetan Rivet > > --- > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > > lib/librte_eal/common/eal_common_devargs.c | 12 ++++++++++++ > > lib/librte_eal/common/include/rte_devargs.h | 13 +++++++++++++ > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + > > 4 files changed, 27 insertions(+) > > > > diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > index 40cd523..8b24309 100644 > > --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > @@ -206,6 +206,7 @@ DPDK_17.08 { > > EXPERIMENTAL { > > global: > > > > + rte_eal_devargs_insert; > > rte_eal_devargs_parse; > > rte_eal_devargs_remove; > > rte_eal_hotplug_add; > > diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c > > index bcdee13..ff6c2a8 100644 > > --- a/lib/librte_eal/common/eal_common_devargs.c > > +++ b/lib/librte_eal/common/eal_common_devargs.c > > @@ -138,6 +138,18 @@ rte_eal_devargs_parse(const char *dev, struct rte_devargs *da) > > return 0; > > } > > > > +int > > +rte_eal_devargs_insert(struct rte_devargs *da) > > +{ > > + int ret; > > + > > + ret = rte_eal_devargs_remove(da->bus->name, da->name); > > + if (ret < 0) > > + return ret; > > + TAILQ_INSERT_TAIL(&devargs_list, da, next); > > + return 0; > > +} > > + > > /* store a whitelist parameter for later parsing */ > > int > > rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str) > > diff --git a/lib/librte_eal/common/include/rte_devargs.h b/lib/librte_eal/common/include/rte_devargs.h > > index 36453b6..7b63fa3 100644 > > --- a/lib/librte_eal/common/include/rte_devargs.h > > +++ b/lib/librte_eal/common/include/rte_devargs.h > > @@ -139,6 +139,19 @@ rte_eal_devargs_parse(const char *dev, > > struct rte_devargs *da); > > > > /** > > + * Insert an rte_devargs in the global list. > > + * > > + * @param da > > + * The devargs structure to insert. > > + * > > + * @return > > + * - 0 on success > > + * - Negative on error. > > + */ > > +int > > +rte_eal_devargs_insert(struct rte_devargs *da); > > + > > +/** > > * Add a device to the user device list > > * > > * For PCI devices, the format of arguments string is "PCI_ADDR" or > > diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > index a8ee349..81f6af3 100644 > > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > > @@ -211,6 +211,7 @@ DPDK_17.08 { > > EXPERIMENTAL { > > global: > > > > + rte_eal_devargs_insert; > > rte_eal_devargs_parse; > > rte_eal_devargs_remove; > > rte_eal_hotplug_add; > > -- > > 2.1.4 > > -- Gaëtan Rivet 6WIND