From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f173.google.com (mail-wr0-f173.google.com [209.85.128.173]) by dpdk.org (Postfix) with ESMTP id EE63C2030 for ; Tue, 18 Jul 2017 01:17:16 +0200 (CEST) Received: by mail-wr0-f173.google.com with SMTP id y43so4298847wrd.3 for ; Mon, 17 Jul 2017 16:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=8CTE/i4kIHry86wFx44s0vkO9zf7+MJdI2zoZD71ka4=; b=sRI/zujXrGV3gk4yqWjH36OvMckIPB0o7yJWHLZeMKvn83QZC1dcPJlVrWX/vubWcR FeHj+rczD96kXpcQHeAR4UDBq0w1gjw8UP6VZ74oYMSKjtTh4h9uY8I8lcKSxaJJ1qeD 04om23oHkOg3QOT3nzCK3pYDmhpQQRQEcBvyFSrOS0FoNAosBL2LJHNELMxttDvt1ffJ qKgI2HM9uIjy8cCVfu2I+ECQK7GagieM1uh96umbm5GOLVMqykRwsxWkpSBUgykLgRvr 8/g/hXm8oUWDIh6llqhhbDyJSaDjGbTiE4UMArSC2iVMMQL1pG3XtdFOcFKMPwIcZn6G 3kzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=8CTE/i4kIHry86wFx44s0vkO9zf7+MJdI2zoZD71ka4=; b=nmntFLmCd+ZsAcU2gvwirYcxnzzbBORrhDNoiRmDUci4iXyS+KaJ2+G1t/AAH+vJFR 81G76OBan4ckun2oEV1IhSVZweEYU3HiSVGSJ+0KhLuCFAnfhdUyUc3J0xsjK0pRNqnh d46/OdYtk+hVoLY+tkwnV8mzwbulqJw3IqYcc0jH36wA5slpLZq3A2awEHEpQl1EyvTh txJeThRlRLs82mDi3e+QAtvadUVqJ0Rn73pvoIOPNmw5mW2Iaa1W55UAbKUljp9G/uU8 D9ZJVY3esy+11oUyuresAQ67MWpoIi0gn5u5VYRy/dFMvkbUom+1dgOtK0H9tRKgdRSn dVNQ== X-Gm-Message-State: AIVw11215+OrEh1J50m7J/+ZD+X4aDXM1uSp7toSxvnd+Lh48Fhi10br glfInX7bDrbxxV5C X-Received: by 10.223.165.13 with SMTP id i13mr47812wrb.35.1500333436444; Mon, 17 Jul 2017 16:17:16 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 76sm9283761wmm.14.2017.07.17.16.17.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jul 2017 16:17:15 -0700 (PDT) Date: Tue, 18 Jul 2017 01:17:07 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Ferruh Yigit Cc: dev@dpdk.org Message-ID: <20170717231706.GV11154@bidouze.vm.6wind.com> References: <7390b7f14a1925ece0c55c6b1df8da358c725017.1500130634.git.gaetan.rivet@6wind.com> <784ab02a-2454-f209-ac52-ff1e53ec1a63@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <784ab02a-2454-f209-ac52-ff1e53ec1a63@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v10 03/11] net/failsafe: add fail-safe PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jul 2017 23:17:17 -0000 On Mon, Jul 17, 2017 at 02:56:54PM +0100, Ferruh Yigit wrote: <...> > > +Stats per queue = Y > > +Unicast MAC filter = Y > > +Queue start/stop = Y > > +Jumbo frame = Y > > +Multicast MAC filter = Y > > Is above ones supported by PMD, I don't see them unless I miss something. > Queue start/stop was an error. All others are supported as long as the slave support it. <...> > > + sdev = TX_SUBDEV(dev); > > + rte_eth_dev_info_get(PORT_ID(sdev), &PRIV(dev)->infos); > > + PRIV(dev)->infos.rx_offload_capa = rx_offload_capa; > > Is intention &= ? > rx_offload_capa is already set a little higher, and then an AND is done on it with all slaves. The "=" is correct here. Thanks for asking though, it's always useful to check :). --- I fixed all other remarks. I will wait a little for any possible additional changes you might want to point before sending the new version. -- Gaëtan Rivet 6WIND