From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0045.outbound.protection.outlook.com [104.47.36.45]) by dpdk.org (Postfix) with ESMTP id E49B92030 for ; Tue, 18 Jul 2017 12:17:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=V4VnU+BkLoHNionag7RqeLWPf0CQaFaAfgM04NnWBqs=; b=QdciWzR1REiNbD24AdAB4lGP6gWLnInLSNCOg0U6PVDPZQi5ha+0FVJfel5fHhjBF/dchKNiy1+vbOfxF5SEt8czA9LahyFDjabIOzqvwAiDVNnMi3CpnNAjSTp3qOmiC34ZCyFGgCSY2h6zOFTc8fkMlK39aMd0UG6pmwJpNUo= Authentication-Results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (14.140.2.178) by CY4PR07MB3062.namprd07.prod.outlook.com (10.172.116.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.13; Tue, 18 Jul 2017 10:17:44 +0000 Date: Tue, 18 Jul 2017 15:47:29 +0530 From: Shijith Thotton To: Stephen Hemminger Cc: dev@dpdk.org, Stephen Hemminger Message-ID: <20170718101727.GA31042@localhost.localdomain> References: <20170714183027.16021-1-stephen@networkplumber.org> <20170714183027.16021-12-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170714183027.16021-12-stephen@networkplumber.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: SG2PR01CA0077.apcprd01.prod.exchangelabs.com (10.165.10.45) To CY4PR07MB3062.namprd07.prod.outlook.com (10.172.116.143) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3d6a21bd-f141-4dfe-efb2-08d4cdc63bfa X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY4PR07MB3062; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3062; 3:Fp+bgnv/Xhkob4qusAB1S9VpVmkAqQ2Dc0Tl/3fk72He2oiSz/WvXYVGsaEyCkWxCuozDH9g2xI/aGPUsaCAxgJcJU28uEedssy3Jq3EU0+JcKwForlFdJZDG1gfaRxelZLuKCvxRdk36DCZFOwynmcnIrff36KWg6f4ZI5+g9CMv6S4ZMa2Qp4nzjYsD/L1KA7DEKbA8UWTLaaCJLyjZfYfHgb24zsLsBXhMesJ5RqOjRByUlYqnSBT+VBZH+01CsvXkLXPlxF1fN1XF2wbe3sUKDQUyoZ4O/Bq9i9JfhbokNV+e3oCagDw68+f8QXn4GGMLA0iBUHLt5Lk/iuxpmJ1OlIyTOX1DZ7R2WOwnEA1mzAO2511jh+8m+QqZhcM7fdZmeYywf0GQIa9S9qEAefnYifjJAxP6yDvoEQXfR0R2PMLjsjQIHM3BFCKZ25fi5C9j5k2LgUqn5Hx9mVAcriqx2yOHj35hLV0kxyaA7bXqZKVdLXw9OHPuSulu8ACtTRdpugLFFOEETfYKGehtpNu363Rx+jQ4N1VMPwoZM9RHMspmcettfrSJPD7b6Hll05xNkwmBTeNlbaREfCkcEZZ5WJVWp6qhHTzdTvppTE40Ro3a/w0X/37BORBPQhHQ7TLbvR8vG0QJrrMfiqT/+BF5DVwlWCFeyirZPq+zVo6ZP2XBLum3LuM/Cls3yNaP83QpXnyEujkwB/LXskakyfR/1/FmoFZhTjNWz9LxKg= X-MS-TrafficTypeDiagnostic: CY4PR07MB3062: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3062; 25:SUqWx1s5GMyt1NgGQFbVAiI4sz+IiSGhPS+zrKhurwQ7+2STo3AvIaRWKq9bwVysI/V4DqAZFmcLZ8qu48AIwO549FzWmbx8L5VB7tbCDHSr7kFdjrkrog0yK/kZdjZO4B3L6kXVMUCyPUwSvc88IOSzkT4TQlhYgN0Vp3CB1mhgWeh3p3N4Z633r/hLA3wkQwo5DdnMIqyPVLOX5uT1FuHmm5QTl3Fog5jgh/zF510E62fpQE1aFI2gH914P80v0ojlK3d4T96pI7xJt9MGz4vb+ecyG0jWi0SgR+9XTwrZukxL9UVm+u9gxt7tCrINGG7DRgeGb7fQBgW2AGgkXOl5Fp9FTW2XgmIErDEh9c0QIuSWxIY6/VT7XfPnr39mCJ9/BGOHWXap7oUv1vdslqhR0zH734ux77fIqWmcJz6vBJI9K2e7esbdncVIK/IW2xx9ARkeOeyqIVsz7d4TeOMyzYW+EP7UzogCeWMtyW81WOvCi30ANLnahLxP/dIbQf4PZjnbtU3VP22UgmHGpr7yTd3VNTgsv/zFIZJhv4P1cUAfG1HAe/2DgM13PRicPVNlGZ8P7rGt93Bth2mRaiWfiBDlfd5WbwntErkjT0NgT3aeN5/4BDwTsYzXz7Bpo+pjVeQn7BkYF6IjSeP3ddia6kwvZL7T2dow1pyn0p5GYzkwH/qUwv445L01QEO9TRugmLIoaOzMO/VxMlhz1NZYGcHLMkZl/nntAfN7MELW4+V3/ecNIOBvou7xqb190l3pFnWFOwEBtYQbHbLgi5q7AFd0kLdTJeE7ox8v/NXUOAZxacGUtPqp+Fvr/6bFG06Uc4L4gliyBNqbrlDxwrK3idJQ0LgwkcKJ9JXxC4r5X35rhWJaCDmq0UwtJuEFaD0+ZkLimIJEWKsgcsLijwZ65/vdsP0ejvyXxSKb14w= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3062; 31:K4yWH0IhjkwdrEUidZ04NpPIw3qDPFiVxi+y78zS2wUDp1lp/OaNS0yqWH4J0vyHHw82l5O9HGZIb+ERJZm4l4QDRAS+Q1U8BI+gPaIM3klOGYW+qJ0ivaZdhO6gI/ZVZmQE4ncASK/SPrRtfgDUuAieiGoflSJ8f7Akgn5H+usSUh1wECK89eTrTKH5B4Z5V5wI13BLQSUBy1rBm1XME713RIwvpt/qfKvTxAqAb7j0xdA7axRsDrgGrJabLGJPsEkbM2LVlwE82WesE16viqx3cI9TQ6pfaDAqjzuTkZ3gu7AdN+TLFhm+IJol1+7xiyxEVy4wBEhBG4uQCbGNvOjcHtt+Yxt8SMrk7nBzkF5yGVG4X1z+OnlCfQlNez2yczf+GvH8Sq8Bdgz4RY0grM+n50u0dKh/I6UyEqcLvD8tw2G8QtFiVo2ZhSHyZKUTj+XTOQIBLczcAX29b5a1IwC94O22b6Y+TBM4pgghgWinxMBDjiU2kUjSbkpkCLKdcLluwSnR5bI7Y3Apz23B1znvQpWj7ykiDreRy2ry4qPVg2y58+Vn6rzMnFDg2tfkzkj2Mvsy5E4Oqx1i3WlUxfm0tFLqPgOX0vDS1B0h5j2fP3h81kCexBE0FZEbVeG2AAS7TjFTSwxWwbsXZ45aSQu9TCNFS2+7+za1ElyKVO/f34TB/liO1xpNWJQdz0NTJmhISdx5K8BPdmv4rBdBpw== X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3062; 20:8kIPn+i2uEY7+tk4ElAdVDv9kA2jhmeU/k/f0h2nBJ4oKcw3iy0nWxw07Bx/+BEbUkfXtD5T4YBnoYdmtDnTV0A+sa7f1zYw9PrWrD+S4/KEqALv9wWVB3PWaz0cHxM5LqsX5fJ/tKjV7G36WZLo82N+O7IrnECyOk/fjelVg8+iDGlzTzDklAqGJH5/LFuYErvYWIG7YKJ0ZcTQb7b2IhsNt+PPiK/AGq3YTLWej43PVmZnKvYO6hfhXhpmSANCXt6i1yNVRKdNpNmz/R2SPbhCc+3XwugI+j4jxGRjwVPfJi2iZtWnogkvlOZZfNGbfL3DoKvK4/8HnwP5M/jlqf+m0jfBiz0WUvtHpnjtubNimpZ0V7BJ3bfXrRXPm7Rj4tAk6K5S9SfFNyLjOhtG+XtwdXDB43OvAaeO5yskGSRDw/0JFVBqBEKW9wIRZBD6jyGnjfcS+jDTpDn03TF2Sf+2mgI9a5NUSZTtCwVp8L4Ao5+9Zal+01GvpFE7ojkn8kvtUEOEuNK9phHZZeAubUCQhlX6uVSr4CogVi6Gu+0SZcT+HLT5iEEFFnsN+6UWeTM/DAM0v/lL7gSPNsObPaLI6fIWrbNTXZWLkwhU2aw= X-Exchange-Antispam-Report-Test: UriScan:(236129657087228)(148574349560750)(167848164394848); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(2017060910075)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(93006095)(10201501046)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR07MB3062; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR07MB3062; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3062; 4:0mGAzVXmZ5juWkI4CifRzq9nomHEgSn3BwohWfOXrf?= =?us-ascii?Q?OfMP/qb43r/SY1TFmu+j8dQHrJ/ZTkuL+26wqnRd1AfQcwtN9AOl4qFnGiIn?= =?us-ascii?Q?SRvY1dCy3q8Tio3pdC60/EHqbr+KbzJVSIFClGr3RPLuNPneWfcD6kb168dQ?= =?us-ascii?Q?/C3bH+Gc7ZvKP7fIO0P7w3loSl6fB7IqiKPkd79axDRxtdkm6YKBmQWuYDuc?= =?us-ascii?Q?EbsYh1+nX0vtno48GqTI8NMm2Z4nG8eVfU85qsmCzM9Z4ZDmBtf+sC+hbBVH?= =?us-ascii?Q?1BoMcIXuJvGWGI/1Etsi+xhdapGcoLIeCL9XTFLln7IvVA3vknQ+YA/zDg5k?= =?us-ascii?Q?RK7510TjrRuUMXOERO36NTagpVooYcT2PIMEqh8W9XFEixkREUAsH6RjR//E?= =?us-ascii?Q?QnzdEP8R4JtbDsROfDTxazYatwKF19s27yx712z/PnmBtaWZbaR1sfvoK5AP?= =?us-ascii?Q?vnkK5dDMHRyogVQXJZG0KDcTM9X6eIWBDmOL8BlwapxcWrfXsKxSsqVOwNa+?= =?us-ascii?Q?nSBrM5leRy+NA+cg/rkCwJgcOq0upr/tk9OICekdQgPjnCWitZwzAMFn9R2o?= =?us-ascii?Q?dZ1TZoQRnTPJTSHKMvTVzSlYzrWiQXV8BLq46+2v1zAuLHLvzTgXAoZbht72?= =?us-ascii?Q?9PlHG36/Bgf45kM0LBwQPoJ7iNPUva+USin9gvX1vZw23C6YVW85HR83O9hS?= =?us-ascii?Q?tas4j748l6V2LwO3lo8+bmLWtqJAgYyTu59s7vEn+7w7pY/s5TgNDUzZ5vfj?= =?us-ascii?Q?AUjfXw2U8X5a6LwgVp75hIHd+5fZSHEHWfxdre3DrJj8V+dMyUAyfGaokUOG?= =?us-ascii?Q?wZ2FCeyJ/Z6i3TBm3qkPI+ucA3MhTovy0VypiAt98GGo1Y3EOpZiZGd9Od0H?= =?us-ascii?Q?YqAQ7cMr3Y8JWPCPcABipog7EVlzqIMrBl9CGKj8V15lpf8HCzse+XpyGNdT?= =?us-ascii?Q?ab8DPb+OnkK7Cb2gnAUtbLUpoAh1v2baDNRc+8e+SyIOS5vM2gS33v5Nqm8D?= =?us-ascii?Q?Q6a3FxPWFWlhOx1vRHTIZaEgrS0Q7LuAkjUTxVchMyOOtxUYTdgC84TN+KYu?= =?us-ascii?Q?no/a0hnus35qqYbrSdW/OiMQpuprEduhtAXqKsNIhXn5vsvLJMDJ8Yjb26Lw?= =?us-ascii?Q?jOwa0P596C3/J9zU2dL2hxt2c7WJXy/YDVq/psmtm5BHC0DjB0rZPLTTTBaW?= =?us-ascii?Q?MKeeuJqG4Fv/etOz9tnwNOR7FkzzxAvrHk6buBX+wgynGftncqKat8SkaxsW?= =?us-ascii?Q?j9W4DxpKT4d+6H0ffDTZ4Kxmn1vQVMYTlVdddp?= X-Forefront-PRVS: 037291602B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6069001)(6009001)(39850400002)(39450400003)(39410400002)(39860400002)(39840400002)(39400400002)(24454002)(42186005)(2906002)(61506002)(6246003)(110136004)(229853002)(3846002)(50466002)(2950100002)(4001350100001)(6506006)(4326008)(47776003)(53936002)(6666003)(7350300001)(6116002)(25786009)(6916009)(38730400002)(66066001)(42882006)(23726003)(45080400002)(9686003)(1076002)(5660300001)(55016002)(7736002)(8676002)(54356999)(478600001)(81166006)(50986999)(76176999)(83506001)(189998001)(305945005)(33656002)(72206003)(8666007)(5009440100003)(110426004)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3062; H:localhost.localdomain; FPR:; SPF:None; MLV:nov; PTR:InfoNoRecords; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3062; 23:I3J5sShPCpywXCSzGFzTNb6x8RotFtmASPzBIW4VH?= =?us-ascii?Q?FUx1mR8hnJipNhM27NAsp2oqS8kxLXvoiDm259FdsOJIcPqcmXLP1SbPgDLn?= =?us-ascii?Q?LLJABgIx+lINcQchx+OyF+Z61Ud0TPOOI6i7GXSBXGc+tyriovCe1HRSNhdH?= =?us-ascii?Q?z5myfXNYX1CViiOXla0MstEIck54ilX+e4ZmKa2gubXQFaSBKwnkOl+b0k0Y?= =?us-ascii?Q?JTHCO4S/Kwzt/lYi3N15Pk7c3ipvzPZ/K2f/RTGqzDrTwKGlDo7fTFPR6E1g?= =?us-ascii?Q?n+zrYHkkL8B+qKgxJqn1EHcWLo1rhhiiw0s4TpDiBZGWwhYrz7Fy/S/aacKj?= =?us-ascii?Q?wChcmBCYM2nH5EwTOpwu+XcQXGs3nKNlkZam8kweND1TNG+IxUgO9UgExFfw?= =?us-ascii?Q?Nfkv13p0G3G4jLqQV/vbq0bdwd4Zi8Mr4ounAQBWelzd+1LZdiNufNNPXKd0?= =?us-ascii?Q?A1j5w8ADkKNwPoJdoEkIKz2e8qwTSJyycnp/ztXfa0XBiQqD/QCw1KM2JdWC?= =?us-ascii?Q?rg+Dvr8xafhHyiPfxR8AiTwZRgnwSD4ElD4RXl6B7/dnP/Czjf7O3cU1VFcJ?= =?us-ascii?Q?YqhTchQ0e+RB6h5gL3D6ajPp3C13zQYY8jF1MC8C5+vPfyammZVnPqHRkbCt?= =?us-ascii?Q?Qlvp53KGTeu4xQikBqaxFIeVibbWs94KAIcJX7Vo6pybwsIw9a6RO600XNaZ?= =?us-ascii?Q?4ofudt2mdWhHki2Zxsc9b6cCR6sTBn3vZ1oQgslT56gAKRUf4nTTdLN3r15S?= =?us-ascii?Q?i/zDq3aCnhkILubD9xMfv1JsC9TTiAzhfk4WTjgtcOiMrAXQ4R7zCMXMc11t?= =?us-ascii?Q?roWEz/kIfHmJ+Ty/DDYGX+CETzawI3gyk34sq13gGmsfBSrAg5Mh/TF34rwZ?= =?us-ascii?Q?M2zWvC1UPpKH4DSQ7GKU1fk5AkLp18q3MsmL+uER9oVD9+AUQu23DjWTV3je?= =?us-ascii?Q?pStkk7EQXaF9s+GJHXyaXFL848kIk0mQqMBJyst1d1tCJmlT6gYyryqy3JMW?= =?us-ascii?Q?cMgFly8nK9uWUIu+2ZtFTM26eAKsq+M33suyaVhQABtiYmMiYOvEtGPnW3Q+?= =?us-ascii?Q?EoTB9tT8NZL8oM+0jP18+GT666BTeYegdfVOOjNK7YFT9IwuGtkL8k6w7kVZ?= =?us-ascii?Q?OUlsxWxFcQuYkUVuHaBy8zaLvmZ0+ybtnNbQkE5RlbZSJRuWe7MvjPrTFXGA?= =?us-ascii?Q?KcFy988ygPv8Vz869KacxVArVKDCKI77tAdeBKpGRRSFBNi6AE4UZNHNzpVk?= =?us-ascii?Q?onEe0NjJnqlEdq8RQs45vsehyJn9PXxa8liNWNshYj38zZ4yGd+pFa+qyS/S?= =?us-ascii?Q?rJc/Mbosaszx5rRCqWFFIwubcSaCfkZUl+up2ywYp1QMPRbNz14EuP7d2Jm8?= =?us-ascii?Q?iaiw1IbWoooWQfp/9LjJFULczw=3D?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3062; 6:nMiZKT9Bs2R1TlQd/FMU1EzKxfpUiApg3Bw4mrlBTu?= =?us-ascii?Q?5PnlNuG9yJ7yO0t1cHxNGygp+dyBLxIfZRMjis3Zn17hrQvZUYOCNU82tz6/?= =?us-ascii?Q?vSgVLPlAGlBJBwQhYoUGKNk+DnXsm65Z8RlUEJo0hN8jLNNeDuOvP0re/R8g?= =?us-ascii?Q?Tjy0sdqXyBWNL5Mc27Je02KnIwEmdvBBS23E9gfQO87BTsWXyHYFpUDRt2po?= =?us-ascii?Q?N64h3JMgyKlh32UxcK7GJBwRkMyNl7+EJzrRR1CofON97OdJVl26hbDt0xee?= =?us-ascii?Q?i6yEImnDhRht/gYKFmD4redOW3s6W/zLz/wpjUYtIWXjMcNCPX4Ac6xIXHYr?= =?us-ascii?Q?kncUX1wv9MN5al9zOwGQFos2MDKjUqsyx1bHYFhMnGNmQSt8/zN2k505++/t?= =?us-ascii?Q?Lj2zPgp+J5wccNp9TncPJ5fZ8Iw+Nruqsac99VrlmOVLOPJuiHRxwDMObPzk?= =?us-ascii?Q?g7lmB12OfddV+YoWgTxHzzbowDJM/wSOjFalUrFMoUhfSVoF/UrJPHuUbi+2?= =?us-ascii?Q?5fQxUoQUzNDsf3s9xqDSg7cxbiHsawfHqd3vZRJmPUU/3J6FVZg69yGo5qhq?= =?us-ascii?Q?UCzfWOurMz/7up2O8I7ugTXU7dYBUczXEF55fosQTDG+Fle6yjIvjR8QxBsk?= =?us-ascii?Q?27RPlyqApVBT2F6mcEZpgPxItnNcWuArxEpB3+O9pHS9ZLLHF48vGEXCZ91i?= =?us-ascii?Q?9/bmqdV0zaBfHhUkM9AlgCXOcnP6JUSspBWTuziNI0SAZLbXIj+S8ssSkcFP?= =?us-ascii?Q?rw6+4nOmfBneN2aWmMg8MeE2ljXFsEz33/MzmFeP7J3iJvv5QYsuh1f26XzT?= =?us-ascii?Q?/ONglBUKjREWpTFdyO/JNe6QMGnvmHfdSbS7ABPtQv7NzwYVUMth5QmNBESe?= =?us-ascii?Q?qFF6Mcc3jpTc+d7dTOfKDgdedoqoBxVvW1xJVg0IosJXWZHwdrigV9O6Gn/j?= =?us-ascii?Q?khRpQ7etj+uY4ch4dk6Gwpgd64MnMy0Zl8Kb0/VGW+fBqe/QhVE+rrhw7cKQ?= =?us-ascii?Q?Y=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3062; 5:2HsRHxCWxNR/+sbBTp1OyHTvJi6u7BWV2q0iaOC/2H4U7qJbfCyEa+ilj3UqM8IlFAUu97dM9dTl4mxPZJl39l9ZjgL1s0WxDoxT3mfRnAZ6vlQ0qx59VZ7PxmvmRyCSnLZQy0F4vRWL/DrFWUCyQEfk0CU9M3pUl9WdTMJzeaqYx7xM0ZJm9tYk/dTKxh3aF2n3CYNwkRqnnCVsmVruazRfh5uYl/c0nmMO8x2rLW28oGCXqS5SzAPmzv/rDMQj4yBr5FFHxk3/nMUKf6dVocAgNscAqyATEwP3YBBxglczCRI485g+wuuEaXIvKIv6RBkVmmMNDBv3AciBamVQjrB7/fyceOdiJWrzEjDB0DCTqcz/ch/MwEEbWyw+ofcTy8SHVPMgFMxJKkqiaLuh4cyaXjNlDGl+KgF/k5XTguQQSuHPpzXY5iawBlItVuQlSfSylBJfatTJuvbgOhWSiTmMdrEw7/lEVytBTyL+Xe/fKI4a1ECaxdficZimtrA8; 24:FRZRy7IwmWjyS4jgpPifpNF4TMSbtLsPsdR7qgycvjrBCSOR7rd+xd4Py5ryB9GN509r4WEj83VdAabPiXL1yzN2lCQWP0k0HGxFsOUhXnk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3062; 7:OtbEid3SsEstk+jCnxGwh9ALRDWn1tvFuP+aoA0PtJNFWMFC+qyuDh43SpBh0+b5MROGX9i0RgGhF63WSkC88vySXxg/wcqTcd3+M1exlrHUOC2+UVaGmqOhbe6PKs0mp5XKPtf7Maz7aFkhYTlh69rccBpVjFuH3LzM/Fyw5Xsd0cvgDp/gttC2e1zmkK/1MSyb0URX5+h/AJtW2DRS2Dv6a3ORaoa2rXngNJaZ6wdOP556/bvBMUQm+cSyZk6E7TJ1xu0C1SAhxJ3YO58avNfIgHhr4R7J4XUeGC4Uuvx6eBophj123wnCm5LAI/a6HcB0qdkEIO8cQkZtCzHGELqEs4a+xhBbo1m/k4PpJY64RLd5MoEBmUwlUE6cvExSQ0mbDdEzqYM8cM0mUG9utoc1pLX1KPKu2yFZ+gCyGhK74iA3C+wxBIPsUERD6vQQlM9k5b4argST4Kyo8ptWTnKfuJmxKarWaM0Xz+fXZTOTcv+nfK/pdcqWAseDUzzRSbmlyZEM09K2+/ppCuvw4uYgMDlidb2AwQdDtIS+f4fbLWv0zyighONT8jc1UE0+h/UzzKF7Wt+xE69WdPYkm5K1EIKfsFV1NFgrDweAzZJST4aDkh7oDkjMJNG+OGbboB/AVLDB/ezCOfVq37iRLI6zzTivbvquFferV2AhA9y8MbyUDMoscZEfIhXrfCzWGyNCWMC7EwGM0A8hdZKHhMbdMGkhRpg/ymv5ImWyEobL015MjtCZQ7JckmcVbvPne9Ccsy7F3157kraFQE6SoO2zl2cgdHcEEgyu+qujx5s= X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2017 10:17:44.5696 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3062 Subject: Re: [dpdk-dev] [RFC 11/14] liquidio: use _rte_eth_link_update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jul 2017 10:17:48 -0000 On Fri, Jul 14, 2017 at 11:30:24AM -0700, Stephen Hemminger wrote: > Use the new link update API, and cleanup the logic in the the > link update routine. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/liquidio/lio_ethdev.c | 76 ++++++++++----------------------------- > 1 file changed, 19 insertions(+), 57 deletions(-) > > diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c > index 479936a52ff9..95dc7232601e 100644 > --- a/drivers/net/liquidio/lio_ethdev.c > +++ b/drivers/net/liquidio/lio_ethdev.c > @@ -888,32 +888,6 @@ lio_dev_vlan_filter_set(struct rte_eth_dev *eth_dev, uint16_t vlan_id, int on) > return 0; > } > > -/** > - * Atomically writes the link status information into global > - * structure rte_eth_dev. > - * > - * @param eth_dev > - * - Pointer to the structure rte_eth_dev to read from. > - * - Pointer to the buffer to be saved with the link status. > - * > - * @return > - * - On success, zero. > - * - On failure, negative value. > - */ > -static inline int > -lio_dev_atomic_write_link_status(struct rte_eth_dev *eth_dev, > - struct rte_eth_link *link) > -{ > - struct rte_eth_link *dst = ð_dev->data->dev_link; > - struct rte_eth_link *src = link; > - > - if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst, > - *(uint64_t *)src) == 0) > - return -1; > - > - return 0; > -} > - > static uint64_t > lio_hweight64(uint64_t w) > { > @@ -933,45 +907,33 @@ lio_dev_link_update(struct rte_eth_dev *eth_dev, > int wait_to_complete __rte_unused) > { > struct lio_device *lio_dev = LIO_DEV(eth_dev); > - struct rte_eth_link link, old; > + struct rte_eth_link link; > > /* Initialize */ > - link.link_status = ETH_LINK_DOWN; > - link.link_speed = ETH_SPEED_NUM_NONE; > - link.link_duplex = ETH_LINK_HALF_DUPLEX; > - memset(&old, 0, sizeof(old)); > - > + memset(&link, 0, sizeof(link)); > /* Return what we found */ > if (lio_dev->linfo.link.s.link_up == 0) { > - /* Interface is down */ > - if (lio_dev_atomic_write_link_status(eth_dev, &link)) > - return -1; > - if (link.link_status == old.link_status) > - return -1; > - return 0; > - } > - > - link.link_status = ETH_LINK_UP; /* Interface is up */ > - link.link_duplex = ETH_LINK_FULL_DUPLEX; > - switch (lio_dev->linfo.link.s.speed) { > - case LIO_LINK_SPEED_10000: > - link.link_speed = ETH_SPEED_NUM_10G; > - break; > - case LIO_LINK_SPEED_25000: > - link.link_speed = ETH_SPEED_NUM_25G; > - break; > - default: > + link.link_status = ETH_LINK_DOWN; > link.link_speed = ETH_SPEED_NUM_NONE; > link.link_duplex = ETH_LINK_HALF_DUPLEX; > - } > - > - if (lio_dev_atomic_write_link_status(eth_dev, &link)) > - return -1; > + } else { > + link.link_status = ETH_LINK_UP; /* Interface is up */ > + link.link_duplex = ETH_LINK_FULL_DUPLEX; > + switch (lio_dev->linfo.link.s.speed) { > + case LIO_LINK_SPEED_10000: > + link.link_speed = ETH_SPEED_NUM_10G; > + break; > + case LIO_LINK_SPEED_25000: > + link.link_speed = ETH_SPEED_NUM_25G; > + break; > + default: > + link.link_speed = ETH_SPEED_NUM_NONE; > + link.link_duplex = ETH_LINK_HALF_DUPLEX; > + } > > - if (link.link_status == old.link_status) > - return -1; > + } > > - return 0; > + return _rte_eth_link_update(eth_dev, &link); > } > > /** > -- > 2.11.0 > Tested-by: Shijith Thotton Thanks, Shijith