From: Thomas Monjalon <thomas@monjalon.net>
To: keith.wiles@intel.com
Cc: dev@dpdk.org
Subject: [dpdk-dev] [pktgen PATCH 1/6] remove unused functions
Date: Wed, 26 Jul 2017 01:21:02 +0300 [thread overview]
Message-ID: <20170725222107.23203-2-thomas@monjalon.net> (raw)
In-Reply-To: <20170725222107.23203-1-thomas@monjalon.net>
clang compilations stops on unused static functions.
Some are removed, other one is commented out, according to the context.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
app/lpktgenlib.c | 12 ++----------
lib/common/l2p.c | 34 ----------------------------------
2 files changed, 2 insertions(+), 44 deletions(-)
diff --git a/app/lpktgenlib.c b/app/lpktgenlib.c
index dccf3cd..bd1dff3 100644
--- a/app/lpktgenlib.c
+++ b/app/lpktgenlib.c
@@ -82,6 +82,7 @@ setf_integer(lua_State *L, const char *name, lua_Integer value)
lua_setfield(L, -2, name);
}
+#if 0 /* not used */
/**************************************************************************//**
*
* setf_integer - Helper routine to set Lua variables.
@@ -100,6 +101,7 @@ setf_function(lua_State *L, const char *name, lua_CFunction fn)
lua_pushcclosure(L, fn, 0);
lua_setfield(L, -2, name);
}
+#endif
/**************************************************************************//**
*
@@ -207,16 +209,6 @@ getf_string(lua_State *L, const char *field)
return value;
}
-static inline void
-parse_portlist(const char *buf, void *pl)
-{
-#if (RTE_VERSION >= RTE_VERSION_NUM(2, 0, 0, 0))
- rte_parse_portlist((char *)(uintptr_t)buf, pl);
-#else
- cmdline_parse_portlist(NULL, buf, pl, PORTLIST_TOKEN_SIZE);
-#endif
-}
-
/**************************************************************************//**
*
* pktgen_set - Set a number of Pktgen values.
diff --git a/lib/common/l2p.c b/lib/common/l2p.c
index 45ac363..3783236 100644
--- a/lib/common/l2p.c
+++ b/lib/common/l2p.c
@@ -79,14 +79,6 @@ typedef struct lcore_port_s {
static lp_t lp_data, *lp = &lp_data;
-static inline uint8_t
-_bget(uint8_t *p, uint16_t idx)
-{
- int32_t c = (idx / 8);
-
- return p[c] & (1 << (idx - (c * 8)));
-}
-
static inline int
_btst(uint8_t *p, uint16_t idx)
{
@@ -279,32 +271,6 @@ pg_parse_port_list(char *list, ps_t *ps)
return 0;
}
-static inline void
-pg_dump_lcore_map(const char *t, uint8_t *m)
-{
- int i;
-
- fprintf(stderr, "%s( ", t);
-
- for (i = 0; i < RTE_MAX_LCORE; i++)
- if (_btst(m, i) )
- fprintf(stderr, "%d ", i);
- fprintf(stderr, ")");
-}
-
-static inline void
-pg_dump_port_map(const char *t, uint8_t *m)
-{
- int i;
-
- fprintf(stderr, "%s( ", t);
-
- for (i = 0; i < RTE_MAX_ETHPORTS; i++)
- if (_btst(m, i) )
- fprintf(stderr, "%d ", i);
- fprintf(stderr, ")");
-}
-
/**************************************************************************//**
*
* pg_parse_matrix - Parse the command line argument for port configuration
--
2.13.2
next prev parent reply other threads:[~2017-07-25 22:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 22:21 [dpdk-dev] [pktgen PATCH 0/6] fix compilation Thomas Monjalon
2017-07-25 22:21 ` Thomas Monjalon [this message]
2017-07-25 22:21 ` [dpdk-dev] [pktgen PATCH 2/6] fix screen type saving Thomas Monjalon
2017-07-25 22:21 ` [dpdk-dev] [pktgen PATCH 3/6] fix compilation of printf based functions Thomas Monjalon
2017-07-25 22:21 ` [dpdk-dev] [pktgen PATCH 4/6] fix compilation with gcc 7 Thomas Monjalon
2017-07-25 22:21 ` [dpdk-dev] [pktgen PATCH 5/6] fix 32-bit build Thomas Monjalon
2017-07-25 22:21 ` [dpdk-dev] [pktgen PATCH 6/6] fix build with dpdk-17.08-rc2 Thomas Monjalon
2017-07-26 3:54 ` [dpdk-dev] [pktgen PATCH 0/6] fix compilation Wiles, Keith
2017-07-26 4:40 ` Roberts, Lee A.
2017-07-26 5:39 ` Thomas Monjalon
2017-07-26 14:35 ` [dpdk-dev] hierarchy_commit() message displayed when not using TM Wiles, Keith
2017-07-26 14:58 ` Lu, Wenzhuo
2017-07-26 14:52 ` [dpdk-dev] [pktgen PATCH 0/6] fix compilation Wiles, Keith
2017-07-26 15:01 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725222107.23203-2-thomas@monjalon.net \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).