From: Zhiyong Yang <zhiyong.yang@intel.com>
To: dev@dpdk.org
Cc: maxime.coquelin@redhat.com, yliu@fridaylinux.org,
Zhiyong Yang <zhiyong.yang@intel.com>
Subject: [dpdk-dev] [PATCH 2/2] virtio: use macro to replace magic number
Date: Thu, 3 Aug 2017 09:21:50 +0800 [thread overview]
Message-ID: <20170803012150.59703-3-zhiyong.yang@intel.com> (raw)
In-Reply-To: <20170803012150.59703-1-zhiyong.yang@intel.com>
To use macro instead of magic number in order to enhance code
readability.
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
drivers/net/virtio/virtio_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c
index e6da6802b..55b717c03 100644
--- a/drivers/net/virtio/virtio_pci.c
+++ b/drivers/net/virtio/virtio_pci.c
@@ -553,7 +553,7 @@ get_cfg_addr(struct rte_pci_device *dev, struct virtio_pci_cap *cap)
uint32_t offset = cap->offset;
uint8_t *base;
- if (bar > 5) {
+ if (bar >= PCI_MAX_RESOURCE) {
PMD_INIT_LOG(ERR, "invalid bar: %u", bar);
return NULL;
}
--
2.13.3
next prev parent reply other threads:[~2017-08-03 1:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 1:21 [dpdk-dev] [PATCH 0/2] virtio: cleanup virtio code Zhiyong Yang
2017-08-03 1:21 ` [dpdk-dev] [PATCH 1/2] virtio: fix the wrong indent Zhiyong Yang
2017-08-03 1:21 ` Zhiyong Yang [this message]
2017-08-30 12:03 ` [dpdk-dev] [PATCH 0/2] virtio: cleanup virtio code Maxime Coquelin
2017-09-01 3:05 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803012150.59703-3-zhiyong.yang@intel.com \
--to=zhiyong.yang@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).