From: Thomas Monjalon <thomas@monjalon.net>
To: jerin.jacob@caviumnetworks.com
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] eventdev: fix missing includes
Date: Fri, 4 Aug 2017 12:20:35 +0200 [thread overview]
Message-ID: <20170804102035.4051-1-thomas@monjalon.net> (raw)
The PCI helper file depends on some EAL definitions.
Spotted with devtools/check-includes.sh:
error: implicit declaration of function ‘rte_eal_process_type’
error: ‘RTE_PROC_PRIMARY’ undeclared
error: implicit declaration of function ‘rte_socket_id’
There was also this error because the inline keyword was missing:
error: ‘rte_event_pmd_pci_probe’ defined but not used
Fixes: 9a8269d56942 ("eventdev: make PCI probe and remove functions optional")
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
lib/Makefile | 2 +-
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/Makefile b/lib/Makefile
index 86caba17b..22962910d 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -69,7 +69,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += librte_ip_frag
DEPDIRS-librte_ip_frag := librte_eal librte_mempool librte_mbuf librte_ether
DEPDIRS-librte_ip_frag += librte_hash
DIRS-$(CONFIG_RTE_LIBRTE_GRO) += librte_gro
-DEPDIRS-librte_gro := librte_eal librte_mbuf librte_ether librte_net
+DEPDIRS-librte_gro := librte_eal librte_mbuf
DIRS-$(CONFIG_RTE_LIBRTE_JOBSTATS) += librte_jobstats
DEPDIRS-librte_jobstats := librte_eal
DIRS-$(CONFIG_RTE_LIBRTE_METRICS) += librte_metrics
diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
index 1dbba373c..b6bd7319e 100644
--- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h
+++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
@@ -47,6 +47,8 @@ extern "C" {
#include <string.h>
+#include <rte_eal.h>
+#include <rte_lcore.h>
#include <rte_pci.h>
#include "rte_eventdev_pmd.h"
@@ -58,7 +60,7 @@ typedef int (*eventdev_pmd_pci_callback_t)(struct rte_eventdev *dev);
* Wrapper for use by pci drivers as a .probe function to attach to a event
* interface.
*/
-static int
+static inline int
rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv,
struct rte_pci_device *pci_dev,
size_t private_data_size,
--
2.13.2
next reply other threads:[~2017-08-04 10:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 10:20 Thomas Monjalon [this message]
2017-08-04 10:35 ` Jerin Jacob
2017-08-04 10:44 ` Thomas Monjalon
2017-08-04 10:47 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2017-08-04 12:32 ` [dpdk-dev] [PATCH] " Mcnamara, John
2017-08-04 23:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170804102035.4051-1-thomas@monjalon.net \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).