From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <shreyansh.jain@nxp.com>
Received: from NAM02-CY1-obe.outbound.protection.outlook.com
(mail-cys01nam02on0040.outbound.protection.outlook.com [104.47.37.40])
by dpdk.org (Postfix) with ESMTP id BAAE656A1
for <dev@dpdk.org>; Sat, 12 Aug 2017 12:12:45 +0200 (CEST)
Received: from BN6PR03CA0057.namprd03.prod.outlook.com (2603:10b6:404:4c::19)
by SN2PR03MB2271.namprd03.prod.outlook.com (2603:10b6:804:d::16) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1341.17; Sat, 12
Aug 2017 10:12:44 +0000
Received: from BN1BFFO11FD043.protection.gbl (2a01:111:f400:7c10::1:112) by
BN6PR03CA0057.outlook.office365.com (2603:10b6:404:4c::19) with Microsoft
SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1341.21 via
Frontend Transport; Sat, 12 Aug 2017 10:12:44 +0000
Authentication-Results: spf=fail (sender IP is 192.88.168.50)
smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed)
header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com;
Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not
designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com;
client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net;
Received: from tx30smr01.am.freescale.net (192.88.168.50) by
BN1BFFO11FD043.mail.protection.outlook.com (10.58.144.106) with Microsoft
SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id
15.1.1304.16 via Frontend Transport; Sat, 12 Aug 2017 10:12:44 +0000
Received: from Tophie.ap.freescale.net ([10.232.14.39])
by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v7CACZ79013163;
Sat, 12 Aug 2017 03:12:36 -0700
From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: <dev@dpdk.org>
CC: <thomas@monjalon.net>, <jblunck@infradead.org>, Shreyansh Jain
<shreyansh.jain@nxp.com>
Date: Sat, 12 Aug 2017 15:52:20 +0530
Message-ID: <20170812102220.27773-1-shreyansh.jain@nxp.com>
X-Mailer: git-send-email 2.9.3
X-EOPAttributedMessage: 0
X-Matching-Connectors: 131470063642267019;
(91ab9b29-cfa4-454e-5278-08d120cd25b8); ()
X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI;
SFV:NSPM;
SFS:(10009020)(6009001)(336005)(39860400002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(33646002)(6916009)(36756003)(48376002)(356003)(50226002)(305945005)(106466001)(105606002)(97736004)(2906002)(4326008)(85426001)(54906002)(77096006)(626005)(498600001)(86362001)(110136004)(6666003)(5003940100001)(53936002)(8656003)(5660300001)(68736007)(189998001)(47776003)(1076002)(8936002)(8676002)(50986999)(104016004)(50466002)(81166006)(2351001)(81156014);
DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR03MB2271; H:tx30smr01.am.freescale.net;
FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en;
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN1BFFO11FD043;
1:LyTOdY+WU9oWthw6fAYeMzzgGwMPQkkgIbk18arVu?=
=?us-ascii?Q?UCLKFGQjTRm1tegosLnq76u6bJ/bXYcArA+b6As9jgoV/6r1QVvT5rzQxXry?=
=?us-ascii?Q?ODG/R13XBbXAHfBh48EE1NYdfsmtJ6du+NrXn1hxfmkSKEJaVdof+QGfvWpW?=
=?us-ascii?Q?xfZNUVdUUwGiRuDHA+apNTbFK+kEnpjQhEMJgQqmuFWa1NecFWYYGK0dVxiH?=
=?us-ascii?Q?RTUwz6LsmHQpfKeDve8BtC3b7rvziawLuo81ZDRTgDgnWdmsd8FsM99p6+V8?=
=?us-ascii?Q?Hllx9HQOzslAYTWXqFTov670l1kRKfyVWh4m//HjvryEfdTvX360+tFqv9kU?=
=?us-ascii?Q?bpNrm4b0V44IQ2lAtWIwMq3EpZ6p9oy6vBt/Du/K4dcIMLDMgm9pXxoBBFQ/?=
=?us-ascii?Q?4YLTTpo3neRu1hVmmd47gKSgwzNgqRhIlnp4+VMK4KqRrjS6BItDBMVpqaG3?=
=?us-ascii?Q?g+wzf8Kc2krRGjFA5ctyjQRel28B2s3l+vP54wgAgf9V0DSKDhSALrFceoNX?=
=?us-ascii?Q?WzXHNynMgsZb+NlSirHCxBEI0Qiygv0oNAsJypFKcit2vFoHN7YTsVyMMQG0?=
=?us-ascii?Q?YjDUrW3/hIwxV6RZx/5xXmXvmsXz9ljSc1TmNy26trzqv18Q2ygt2T/V6l5Q?=
=?us-ascii?Q?cfNG8Hx6HPYJbxvzoYpJjSHty6uMjLU1QMx5tJQDjk3bnAS9NM6qFpHqQR5r?=
=?us-ascii?Q?q9sEVy8S+0kjTJzQhiS2BEOiQ2o8mqa3wQ7vEBwdYilu/ymcwlGQxlXYAulY?=
=?us-ascii?Q?4D4bvtwqKIzRRvHX+Lcn42UvxNIwakA+0oxd/nMNfboMABIfp0E/VzTGZOER?=
=?us-ascii?Q?PGVvn88OKXuSFjmJsGQ/kpqoi8vLt3+DRRxEF/G9Vs0IUFrncbVIIuIlqyh5?=
=?us-ascii?Q?UNj8ZBL5w89gn0as+8WXD0/AcrwjkJbANsvix/kjR0R9acvvEoMD16wLxEQm?=
=?us-ascii?Q?a+MZByc/ic0NJbM9VmAXfmgi+MBLMIuq8mPPPvXoQ=3D=3D?=
MIME-Version: 1.0
Content-Type: text/plain
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e704b511-3169-43ad-6c2a-08d4e16aac73
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(300000503095)(300135400095)(2017052603031)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);
SRVR:SN2PR03MB2271;
X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2271;
3:Rm0PeM7D6HOzrK7hmJ1qrAqEmlOh1psSTUrnxGtipJjsahNam7RoaATeXmWXjR5ax1D/rCPl7yeBH4B66mKun0BkBVzvsS0BaTXNTGpzKF5j1/CUBNsyGqhqutHzR0/k2LRJ2k1oieQ88J9Vti1rxfBhZ0lW+ZmtpwjyENajxRlNsrPP2dyMOhkuCVBlYnyyaipu/JmBNxYz0PZwI5ELjqeLZA2npnWvbFMqLX8fqncotRtMCIUvD0CaZIBPn4ZEr5ai9+I7mxUvisPoveeQ5Ltog9wr2a0+3XlZH9ox0BYk0rcMCDEZCqBEzXIBLAucxcTxJYm/MEIhzWD1nEj3dBhRHKOdfcJZ9c7k6mQfOgI=;
25:8IwAv13BWNR/eqkmzde3GnLd/+LYx0mOypJm62eWflZ02slse/kRyrMzffVQf0AxtIalkyKrFSBkhYIpFmKV+MkQq14rOBYNChUWnBLZd7xTCMGhv9/Wem6DIlEASBjXJnHz+MFLWgoa68Olw4Zm+0NIifJmgr8npYAkal/6VMyn579ljEJ34IStNbsaGDRteLjtdzw58VEgw4fi31WRE/BjoaGne/o6L4wdRp8VbYqT3hxzWe+/bEkqo0nMMa8bQfFIdhoA5u2BbUAwUjizrMQAwKbXK8cLXA0pq/Eaorbfyu2lG/njfT6xynbmUw5GvX6keyYeVW5HJfc88Zi4oA==
X-MS-TrafficTypeDiagnostic: SN2PR03MB2271:
X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2271;
31:apIlwzymFxHQ21Od351oS6RcFvM+FSM/7dVQ7WpTZ6sJq92Up+lDOa9aPPDSFUvvzDvQRpC+s/T8cBmk4iIeeBrs6oEKaRGGShJF84W36DocZ4vUxKsX/+S1QjFEC+REu2LcoXrRcXNC2yOd/IjzTjlLxrKRdta89Mv5eYh5b+Pwhvo6SoOtyndzxbnTZxaqaGWG/r+yGgkkg967GxWIudlGOCjPrrPkxUyuWCOJ5YU=;
4:7ebcNlz+BTTeilKuOan01b+kbJy0DIELxZNC8CIPFAdErsACtGI/moc8vnOX54cXB/4xp50WlAbSx17M0M1/SO3VQ7usk8MarqvGmyrwtowQtXxFL2efTY6lfEgfKUpVfBJnGdViQK+uV2KJoR6ORv2tWUanPQTHa0tT8RKuwfbYlla2oaqtMCUWyr66LFqBd2N7wnc+NVzYUK3R+JraSpvyCSJVr7SoeYN7zX/vfS0P64rsFPJ2+0wuFyQAcCe1NfKXAGyssQrDp6+SRT7PZaoWoZj9b6iRxk8zX/xuzz4=
X-Exchange-Antispam-Report-Test: UriScan:(185117386973197);
X-Microsoft-Antispam-PRVS: <SN2PR03MB227164E92542AB921B0E2B18908E0@SN2PR03MB2271.namprd03.prod.outlook.com>
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(13016025)(5005006)(13018025)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6096035)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123556025)(20161123563025)(20161123565025)(20161123561025)(20161123559100)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);
SRVR:SN2PR03MB2271; BCL:0; PCL:0;
RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095);
SRVR:SN2PR03MB2271;
X-Forefront-PRVS: 039735BC4E
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR03MB2271;
23:c21T7pcYXOuI+dcgnWzk4ymTwSmMvcNbVUeUDGmD9?=
=?us-ascii?Q?nMy8fqU5mUPgAFMvbQPI2/QQ8Il+3ytMc4iu+S/IzCkDtRogWuI+z0oIr60M?=
=?us-ascii?Q?/LxneVo9CIHu1PlM3z0RmN8h78FS3v1owyMvfv20NE2p0SvvcfSfjeQtSETy?=
=?us-ascii?Q?kWSRZ+8hurUaTZP8Cqr9o8TNfh0rbKIYjrZ9VwrmnIIBXUdbKbW4pUm2VZYl?=
=?us-ascii?Q?L6RqdzBRXQHLmK+iZHAVG9KEKbQ5CUkQWBXy/u3tGFGHcC0XGkSPV/59DUFy?=
=?us-ascii?Q?hWkBUmyDoskdzubttAFTzwl79Ie/HrV5me2U4T9Jo1mQbMUy4yzofBACoZP4?=
=?us-ascii?Q?cUFmQEP0mwwWpf+SqgjIZRrm9vXFbJI6JZdQYWvo0XNR5clNf/Sj3NtGczjs?=
=?us-ascii?Q?SZxYUP1WxB0fiFnYa/b4z8AtXb49cP7wzewbRKRp1Ecb3WA4AzId/5PKPTS5?=
=?us-ascii?Q?krqDqwwJd9PN8okmbvQoFLXMEI/DRUQqwOyv6EbICSXzKVlMNQJ12idblsAn?=
=?us-ascii?Q?eEZpn1ElKvXPiiOjSg1Yfcs0KXysUa18b3JEAlD0GiZG0TpkWzOaWKQvS4tA?=
=?us-ascii?Q?pD76naruRKN6RFEn2HCKUvQabNjWBAYs6Y1M+mPZSKrA4Tz2uqg7gKSSZD4e?=
=?us-ascii?Q?cqQyoPc0u8U+cyrhe990tBSnn9utj7BnrjwkhCU2gCgJQ9lOeECvSim1/p0U?=
=?us-ascii?Q?ExRDjtPhZFoMbYBuQ2fm3JNuUjAzCh+wz5EBHg7zn69giMLP/o6Fde7B2xYd?=
=?us-ascii?Q?Zx2U/CZE/hc8HdXGDqYBsry+mtomo0QnZOtJqW0/mwbyIgVutO6/ZDBCRISJ?=
=?us-ascii?Q?5d05tqtpEYtd4B0owri4QaDn02wtaR7V3z1XyYaUu4+0G5KVj7wvXFZP14Uk?=
=?us-ascii?Q?ZwaS02ZTRjPcopvKq0QQN5ic9vJSAcxx9nk0xM+tX7YXCvzuSpEsukdbkMdJ?=
=?us-ascii?Q?+pRjxYxPVOhRf9VsPTFXfNDpkWdJwR6XmeK8pMGD3s937u4g7M/S6ZlAGUNW?=
=?us-ascii?Q?Jtt1EvcM8MnNCMIc1mWhrMfkPFb0dBFs9cfPr83O0nocXMmHzhfJrEaF5uTR?=
=?us-ascii?Q?xOAUsoeY8exPgsU1qlPBl4IqMBDPEmhvR/ZDcRvbfwE0ImF1g=3D=3D?=
X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2271;
6:1kr9OdoezNE8c8nyv+LTEDtWjY7LbZEOF2fdm5mE7GgEWdhwK1SrGwpunloIxTtxyWXnOnpPZ9mVUCCE8l+vG3KBclrdR09kmfIrR60gazqlFKdzjpJQ24SsH5oKET7MS6/IgcJU8MHl23LsyAcbqWHgQeWE20CaOoCvMUnzeD/uKZLtgAlCEEMB9Xh/QguEJnq+IXS2ZEoOykgZsaLsEzYFeQOY66a6H60+GavNqI/lWuooqnT3B1yL572cTPMdjnLPsl3FWgv0aWp+OHpt5wpgHcVMbZjzbglk5HQ78k8N6DiNdD1Nz5IjecphphUtlLrqkA7CGVwoFshn7GlnxQ==;
5:wHdRja4fmiDLtU368JZ9hd9tKaj2HX9FxubXenOWBf44CDLqCxQbNo5hD26rJ7MgXKqcefRfHKCVL1IAwBucFkYD5x+6VypqTFu0tulI7ZBreF6ENkiadqapfuizoBC8aJWEa6eZiJvqbT0lr4Tdhw==;
24:OTDQwwnSeqOkzoKpSbckenIa2N3XcdTgKbc5QZXUbuP7aRlhbyuNXAOJZHz31iMQ1u1Bf/2jk9WpndNNmwOklk/A6lXqiA6w9aitkBhQ/Mw=;
7:llOSFi+Udqq6yG69u6CABztGHlhtBGA1G/VoVXB7yZ0F75wRKNnc/qd2+eIL6SqwkSFh3pf49az1aMHqq21lqJGZ29XMcHOfKgJKLwu/0XU4ss9A8F9QVwpDeEdjZPwt4/F0KpC4cgeeZoDhIdltwTpkdy1H+zKiuC0k7Ud7s7QzSIRrZxJ8BuJJH9tAH8G0xNuf0CvJMZJMiJ3FgKhAtepl2uJ4oUlGk4iqNDHDB4w=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2017 10:12:44.0395 (UTC)
X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50];
Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2271
Subject: [dpdk-dev] [PATCH] eal: bus scan and probe never fail
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Aug 2017 10:12:47 -0000
Bus scan is responsible for finding devices over *all* buses.
Some of these buses might not be able to scan but that should
not prevent other buses to be scanned.
Same is the case for probing. It is possible that some devices which
were scanned didn't have a specific driver. That should not prevent
other buses from being probed.
Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
Until now, this decision was left onto author of bus specific scan and
probe function. But, that is incorrect.
---
lib/librte_eal/common/eal_common_bus.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c
index 08bec2d..58e1084 100644
--- a/lib/librte_eal/common/eal_common_bus.c
+++ b/lib/librte_eal/common/eal_common_bus.c
@@ -73,11 +73,9 @@ rte_bus_scan(void)
TAILQ_FOREACH(bus, &rte_bus_list, next) {
ret = bus->scan();
- if (ret) {
+ if (ret)
RTE_LOG(ERR, EAL, "Scan for (%s) bus failed.\n",
bus->name);
- return ret;
- }
}
return 0;
@@ -97,20 +95,16 @@ rte_bus_probe(void)
}
ret = bus->probe();
- if (ret) {
+ if (ret)
RTE_LOG(ERR, EAL, "Bus (%s) probe failed.\n",
bus->name);
- return ret;
- }
}
if (vbus) {
ret = vbus->probe();
- if (ret) {
+ if (ret)
RTE_LOG(ERR, EAL, "Bus (%s) probe failed.\n",
vbus->name);
- return ret;
- }
}
return 0;
--
2.9.3