From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg0-f42.google.com (mail-pg0-f42.google.com [74.125.83.42])
 by dpdk.org (Postfix) with ESMTP id 0C10811D4
 for <dev@dpdk.org>; Tue, 22 Aug 2017 06:01:34 +0200 (CEST)
Received: by mail-pg0-f42.google.com with SMTP id i12so110575995pgr.3
 for <dev@dpdk.org>; Mon, 21 Aug 2017 21:01:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=afnlciudaGcKFrcD+Nu8TcYGN8iOPb5ZgQqtQTVs2+0=;
 b=2R2idKLm6L5sak2rq9v1n2yLppObgeB2Af232aTqZU6MBiAr6y9KcP4nzE3pHKi2QR
 E1yhkNlI8BN4UXCjAuJRmiazOYReeyanDyvlCIOKoOIVLWB9VeJ+GUFTlZuKNJCgntvV
 ZZ/00zPcGgQrhi7sjICuhL7axjCmwFXFY+IKPTsbI2MKG76MPUBe6fol9Zz4XkjWl99I
 LNMYIuZ1PbfX84UO4ahmu5TmhxmMbJz6CKjxV0TayeGX5Is8qR9lBydraSOwSsA7fx3Y
 d+FrpQIw/DBPB/C4QgTIQyU/Ks16c8NGYbc7iKEwVPTfG12Vcbqqfp263gL3DOIgK/Ts
 A0Uw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=afnlciudaGcKFrcD+Nu8TcYGN8iOPb5ZgQqtQTVs2+0=;
 b=TmiVoZCkdf5U4iIWJ4WHPBZnpYUq5cuqcd2K4lEi9g7uIDSNNAUOQg1eKZAuoHSIfA
 tQK27p6ly4eg/6Owisf4zwo1C00PiEYVDTsJvPfDpr4KTp/AXelVd9WNf1pypW4fyVNP
 gUvCMK5RhqfINHE67hG49GirSdQDu8Tw+sKAp0DgCagcL2IUgisbgUxwPoTljJbMBpnR
 la4aUnTVjVdooPkiAYS2NSV/uWOaqCMX04/qcQU/7TTVXfM/gLquTpxtDuaN3iprolZc
 iJJRjtBP1FXCeuKFono5Fbai2ErOLxskGkMsl8hkIK7NV1QKocfma3V8QYIkMKILDaDG
 whuA==
X-Gm-Message-State: AHYfb5iTeQs5RFnC1Ocmkmo4q4CUYi1g70dmSIJq30n2X3ZIV26YIrtE
 oeaVexU1iRfscGA6
X-Received: by 10.84.229.78 with SMTP id d14mr5811210pln.8.1503374494288;
 Mon, 21 Aug 2017 21:01:34 -0700 (PDT)
Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])
 by smtp.gmail.com with ESMTPSA id 16sm30724818pfn.188.2017.08.21.21.01.33
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Mon, 21 Aug 2017 21:01:34 -0700 (PDT)
Date: Mon, 21 Aug 2017 21:01:32 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Yipeng Wang <yipeng1.wang@intel.com>
Cc: vincent.jardin@6wind.com, bruce.richardson@intel.com,
 konstantin.ananyev@intel.com, thomas@monjalon.net, dev@dpdk.org,
 charlie.tai@intel.com, sameh.gobriel@intel.com, ren.wang@intel.com
Message-ID: <20170821210132.5dd74b10@xeon-e3>
In-Reply-To: <1503361193-36699-1-git-send-email-yipeng1.wang@intel.com>
References: <1503361193-36699-1-git-send-email-yipeng1.wang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 0/7] Add Membership Library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Aug 2017 04:01:35 -0000

On Mon, 21 Aug 2017 17:19:46 -0700
Yipeng Wang <yipeng1.wang@intel.com> wrote:

> This patch set implements two types of set-summaries, i.e., hash-table based
> set-summary (HTSS) and Vector Bloom Filter (vBF). HTSS supports both the
> non-cache and cache modes. The non-cache mode can incur a small chance of
> false-positives which is the case when the set-summary indicates a key belongs
> to a given set while actually it is not. The cache mode can also have
> false-negatives in addition to false-positives. False-negatives means the case
> when the set-summary indicates a key does not belong to a given set while
> actually it does. This happens because cache mode allows new key to evict
> existing keys. vBF only has false-positives similar to the non-cache HTSS.
> However, one can set the false-positive rate arbitrarily. HTSS's
> false-positive rate is determined by the hash-table size and the signature size.

I don't think it makes sense to merge two different types  of  tables in one
API. Especially in DPDK where every cycle counts. You are taking an extra branch
on each lookup. The user of this API is likely to know exactly what type
of objects and look are desired.