From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com [209.85.128.174]) by dpdk.org (Postfix) with ESMTP id 348FE90F2 for ; Tue, 22 Aug 2017 11:08:38 +0200 (CEST) Received: by mail-wr0-f174.google.com with SMTP id z91so117676278wrc.4 for ; Tue, 22 Aug 2017 02:08:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=87X6kSoAlPrD57lDwqNjXp1GwSgFcJLU1TCDVhRUGR4=; b=l7A2ulwqRIRS3JeUx4Ke6wTI+kBsw8igMu9/WCgRmIWIQMkvjAz5fc31UEvYi3Rifs 6o0g/9Qpri2ybn3dazJpa7iNamoga+LsI9MdjWrwxJOWHhiBTj9XTF64vfemM7dd201L ZvaD2KUIhI22shp76VUg0A3cbTSTMVduaC1cQ9z9+XFEM3w+XSPN8ATC1UVdkGOtqsmr h+CTP7PO9gRLVvnAGD0xDNBAT5N1rL/jtm6MZR0lLSp+Lip6NiLmqzVZCqi4afN4jOC3 +f3YaxynFssqR3mBhsf/wXAku14CRnHmpYuSsfUnfAtbSvNA4e+kG9fslSUuokgzjSfg oB9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=87X6kSoAlPrD57lDwqNjXp1GwSgFcJLU1TCDVhRUGR4=; b=QRe0ZBqebPxEDdHJ8cy1Cc9qLLzceKkzwy4W4oqlUm9Of3yvyruzJLyVhg1Gix2Wh/ SvBCKLzmidWjHxl/B2YfceVfyl+sFQVY5jqAR1E8Z7ivCfpnQOXfDwba8Vn74t+HpxSW AY/AcWfrY1Kxx2bbrgs7MpIhHFfMp8yDK3a9Y8xQ1/NMUaEtDQbqrv8O0PXlyEcWXwla v8CJmjdy5KDObPrLaqe52qP/ZrvdGqHM1Fv7kH6859QUpMumYkivN1ibLrtu3phVDV53 Hwfi45pIgCBu3AT5ysVmuhS4FWH6ewIyirLK2mprhuMAmjdw5RkYC4eskoCfCpuEwYxK kOVw== X-Gm-Message-State: AHYfb5gRSSv4C3CtEo+Z5dpCSO/rOYo5hhXgmoec7sZwXdFI2UXjMbEQ 9HOh2VTzPEPbA4Nw X-Received: by 10.223.161.8 with SMTP id o8mr11635777wro.213.1503392917892; Tue, 22 Aug 2017 02:08:37 -0700 (PDT) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id r6sm7815673wrg.73.2017.08.22.02.08.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Aug 2017 02:08:37 -0700 (PDT) Date: Tue, 22 Aug 2017 11:08:28 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Ferruh Yigit Cc: Adrien Mazarguil , dev@dpdk.org, Shahaf Shuler Message-ID: <20170822090828.GD12995@autoinstall.dev.6wind.com> References: <25c0dbd5-2a87-c881-c412-b549a65dfec3@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <25c0dbd5-2a87-c881-c412-b549a65dfec3@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 3/5] net/mlx5: fix non working secondary process by removing it X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Aug 2017 09:08:38 -0000 On Thu, Aug 17, 2017 at 03:38:22PM +0100, Ferruh Yigit wrote: > On 8/1/2017 1:09 PM, Nelio Laranjeiro wrote: > > Secondary process is a copy/paste of the mlx4 drivers, it was never > > tested and it even segfault at the secondary process start in the > > mlx5_pci_probe(). > > Does this means multi process support for mlx5 broken with this patch? > If so features file and release notes should be updated if this won't be > fixed back in this release.. No currently the secondary process in mlx5 is not working at all. This is only removing a non working code from the PMD. > And what is special required for mlx5 secondary process support? There is some work to make this secondary process work correctly, but as it will be totally different, it does not make sense to keep a non working code to replace it by a working one. Concerning the release note and features, this new implementation is expected in 17.11 same release as this patch. > > This makes more sense to wipe this non working feature to re-write a > > working and functional version. > > > > Fixes: a48deada651b ("mlx5: allow operation in secondary processes") > > > > Signed-off-by: Nelio Laranjeiro > > Acked-by: Shahaf Shuler > > <...> I'll update the feature documentation in a v2 to remove the "Multiprocess aware" from the feature list in this patch. It will be added back with the new implementation. Thanks, -- Nélio Laranjeiro 6WIND