From: David Harton <dharton@cisco.com>
To: thomas@monjalon.net
Cc: dev@dpdk.org, David Harton <dharton@cisco.com>
Subject: [dpdk-dev] [PATCH] ethdev: stop overriding rx_nombuf by rte_eth_stats_get
Date: Tue, 22 Aug 2017 21:19:37 -0400 [thread overview]
Message-ID: <20170823011937.37579-1-dharton@cisco.com> (raw)
rte_eth_stats_get() unconditonally would set rx_nombuf
even if the device was setting the value. A check has
been added in rte_eth_stats_get() to leave the device
value in-tact when non-zero.
Signed-off-by: David Harton <dharton@cisco.com>
---
lib/librte_ether/rte_ethdev.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 0597641..0319e39 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -1336,8 +1336,11 @@ struct rte_eth_dev *
memset(stats, 0, sizeof(*stats));
RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->stats_get, -ENOTSUP);
- stats->rx_nombuf = dev->data->rx_mbuf_alloc_failed;
(*dev->dev_ops->stats_get)(dev, stats);
+ /* only set rx_nombuf if not set by the device */
+ if (!stats->rx_nombuf) {
+ stats->rx_nombuf = dev->data->rx_mbuf_alloc_failed;
+ }
return 0;
}
--
1.8.3.1
next reply other threads:[~2017-08-23 1:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 1:19 David Harton [this message]
2017-08-23 2:55 ` [dpdk-dev] [PATCH v2 1/2] " David Harton
2017-08-23 7:51 ` Thomas Monjalon
2017-08-23 12:18 ` David Harton (dharton)
2017-08-23 13:24 ` Thomas Monjalon
2017-08-23 21:27 ` David Harton (dharton)
2017-08-23 21:35 ` Thomas Monjalon
2017-08-23 21:56 ` Stephen Hemminger
2017-08-23 22:19 ` David Harton (dharton)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823011937.37579-1-dharton@cisco.com \
--to=dharton@cisco.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).