From: David Harton <dharton@cisco.com>
To: wenzhuo.lu@intel.co, konstantin.ananyev@intel.com
Cc: dev@dpdk.org, David Harton <dharton@cisco.com>
Subject: [dpdk-dev] [PATCH] ixgbe: initialize scattered_rx during dev_configure
Date: Tue, 22 Aug 2017 21:33:33 -0400 [thread overview]
Message-ID: <20170823013333.40576-1-dharton@cisco.com> (raw)
An application may want to manipulate the MTU settings of
a device without having to start the device first.
In order to remove the need to start the device the
ixgbe/ixgbevf drivers need to initialize the scattered_rx
value during dev_configure.
Signed-off-by: David Harton <dharton@cisco.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 22171d8..e85bdb4 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2372,6 +2372,13 @@ static int eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev)
intr->flags |= IXGBE_FLAG_NEED_LINK_UPDATE;
/*
+ * Update scattered_rx so we can update MTU immediately
+ * following configure without having to start the device
+ */
+ if (dev->data->dev_conf.rxmode.enable_scatter)
+ dev->data->scattered_rx = 1;
+
+ /*
* Initialize to TRUE. If any of Rx queues doesn't meet the bulk
* allocation or vector Rx preconditions we will reset it.
*/
@@ -4949,6 +4956,13 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
#endif
/*
+ * Update scattered_rx so we can update MTU immediately
+ * following configure without having to start the device
+ */
+ if (dev->data->dev_conf.rxmode.enable_scatter)
+ dev->data->scattered_rx = 1;
+
+ /*
* Initialize to TRUE. If any of Rx queues doesn't meet the bulk
* allocation or vector Rx preconditions we will reset it.
*/
--
1.8.3.1
next reply other threads:[~2017-08-23 1:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 1:33 David Harton [this message]
2017-08-23 10:31 ` Ananyev, Konstantin
2017-08-23 12:56 ` David Harton (dharton)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823013333.40576-1-dharton@cisco.com \
--to=dharton@cisco.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=wenzhuo.lu@intel.co \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).